From: Markus Armbruster <armbru@redhat.com>
To: Peter Xu <peterx@redhat.com>
Cc: "Steve Sistare" <steven.sistare@oracle.com>,
qemu-devel@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>,
"Thomas Huth" <thuth@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Fabiano Rosas" <farosas@suse.de>,
"Leonardo Bras" <leobras@redhat.com>,
"Anthony PERARD" <anthony.perard@citrix.com>,
"Stefan Berger" <stefanb@linux.vnet.ibm.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Stefano Stabellini" <sstabellini@kernel.org>,
"Paul Durrant" <paul@xen.org>, "Eric Blake" <eblake@redhat.com>,
"Richard Henderson" <richard.henderson@linaro.org>
Subject: Re: [PATCH V9 00/12] fix migration of suspended runstate
Date: Mon, 08 Jan 2024 13:47:39 +0100 [thread overview]
Message-ID: <87a5pgt2j8.fsf@pond.sub.org> (raw)
In-Reply-To: <ZZY2FFq3-CGFbGPN@x1n> (Peter Xu's message of "Thu, 4 Jan 2024 12:37:40 +0800")
Peter Xu <peterx@redhat.com> writes:
> On Wed, Jan 03, 2024 at 12:05:29PM -0800, Steve Sistare wrote:
>> Migration of a guest in the suspended runstate is broken. The incoming
>> migration code automatically tries to wake the guest, which is wrong;
>> the guest should end migration in the same runstate it started. Further,
>> after saving a snapshot in the suspended state and loading it, the vm_start
>> fails. The runstate is RUNNING, but the guest is not.
>>
>> See the commit messages for the details.
>
> I was planning to wait for an ack from Markus, but I noticed Markus will
> only be back next week. So I queued it for now, and we can work on top
> just in case.
Merge into master in commit c8193acc078e297fd46b6229e02b819b65c6702e.
I had a look at the QAPI schema changes [PATCH 02]. They look good to
me now. Thanks!
prev parent reply other threads:[~2024-01-08 12:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-03 20:05 [PATCH V9 00/12] fix migration of suspended runstate Steve Sistare
2024-01-03 20:05 ` [PATCH V9 01/12] cpus: vm_was_suspended Steve Sistare
2024-01-03 20:05 ` [PATCH V9 02/12] cpus: stop vm in suspended runstate Steve Sistare
2024-01-03 20:05 ` [PATCH V9 03/12] cpus: check running not RUN_STATE_RUNNING Steve Sistare
2024-01-03 20:05 ` [PATCH V9 04/12] cpus: vm_resume Steve Sistare
2024-01-03 20:05 ` [PATCH V9 05/12] migration: propagate suspended runstate Steve Sistare
2024-01-03 20:05 ` [PATCH V9 06/12] migration: preserve " Steve Sistare
2024-01-03 20:05 ` [PATCH V9 07/12] migration: preserve suspended for snapshot Steve Sistare
2024-01-03 20:05 ` [PATCH V9 08/12] migration: preserve suspended for bg_migration Steve Sistare
2024-01-03 20:05 ` [PATCH V9 09/12] tests/qtest: migration events Steve Sistare
2024-01-03 20:05 ` [PATCH V9 10/12] tests/qtest: option to suspend during migration Steve Sistare
2024-01-03 20:05 ` [PATCH V9 11/12] tests/qtest: precopy migration with suspend Steve Sistare
2024-01-03 20:05 ` [PATCH V9 12/12] tests/qtest: postcopy " Steve Sistare
2024-01-04 4:37 ` [PATCH V9 00/12] fix migration of suspended runstate Peter Xu
2024-01-08 12:47 ` Markus Armbruster [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a5pgt2j8.fsf@pond.sub.org \
--to=armbru@redhat.com \
--cc=anthony.perard@citrix.com \
--cc=berrange@redhat.com \
--cc=eblake@redhat.com \
--cc=farosas@suse.de \
--cc=kraxel@redhat.com \
--cc=leobras@redhat.com \
--cc=paul@xen.org \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=sstabellini@kernel.org \
--cc=stefanb@linux.vnet.ibm.com \
--cc=steven.sistare@oracle.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.