From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AAF91C47073 for ; Thu, 4 Jan 2024 09:43:21 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 50AEDEA1; Thu, 4 Jan 2024 10:43:09 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 50AEDEA1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1704361399; bh=HA6ooV9l++QsMmLio7h3R/ZioLQ6j2dW+H/ofh16A3M=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=ZtDkStezJb0/RS6c9uKjKroW4TLLH30tkXzBGjBVXbVMZ6+9u11Me3RCyxaKIb7em GBzO6s2RnjreM8H07/b2o7xBz5h08Jrjoyv69xo1RodZfFVpL6t7+vNK0VWatFa9vf /f4fifZWsRGdoQe6u/ZCr7Y/bMjHD8vilPuW4ltk= Received: by alsa1.perex.cz (Postfix, from userid 50401) id C72BAF805A8; Thu, 4 Jan 2024 10:42:42 +0100 (CET) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 295E8F8055B; Thu, 4 Jan 2024 10:42:42 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 64946F804B0; Thu, 4 Jan 2024 10:42:38 +0100 (CET) Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 6F1AFF80086 for ; Thu, 4 Jan 2024 10:42:34 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 6F1AFF80086 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=PzZ4zto4; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=AlRtKVuy; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=PzZ4zto4; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=AlRtKVuy Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 2503C21EDE; Thu, 4 Jan 2024 09:42:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1704361354; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=I1BgDm0+zuhPj9lChPaCbqlhdvr7I7RHxGTrTc1Gpt4=; b=PzZ4zto4yN3EqhB4UWzpxLgIxRZY898bzUOfdRzd+nFp4V2NEu3cv3OUREocEfqV3g6QdS jeJSgxaoDzq2rpysQV/NslcG54C7G31kBQpygYc6C0SZdVR75BR8BRXoLpZHRJ4yGLAIDk 3OvYcpU0bXktL9W1dvKGxsEfO2B270g= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1704361354; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=I1BgDm0+zuhPj9lChPaCbqlhdvr7I7RHxGTrTc1Gpt4=; b=AlRtKVuypGdci03xEQ5S6OpBaSgcubbrAAv/tDyabCQaEg9YZWs50Of89oypf+w8orT/iv rd5Yj94oHHdYJBBA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1704361354; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=I1BgDm0+zuhPj9lChPaCbqlhdvr7I7RHxGTrTc1Gpt4=; b=PzZ4zto4yN3EqhB4UWzpxLgIxRZY898bzUOfdRzd+nFp4V2NEu3cv3OUREocEfqV3g6QdS jeJSgxaoDzq2rpysQV/NslcG54C7G31kBQpygYc6C0SZdVR75BR8BRXoLpZHRJ4yGLAIDk 3OvYcpU0bXktL9W1dvKGxsEfO2B270g= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1704361354; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=I1BgDm0+zuhPj9lChPaCbqlhdvr7I7RHxGTrTc1Gpt4=; b=AlRtKVuypGdci03xEQ5S6OpBaSgcubbrAAv/tDyabCQaEg9YZWs50Of89oypf+w8orT/iv rd5Yj94oHHdYJBBA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 0090C137E8; Thu, 4 Jan 2024 09:42:33 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap1.dmz-prg2.suse.org with ESMTPSA id ib5VOol9lmVOZAAAD6G6ig (envelope-from ); Thu, 04 Jan 2024 09:42:33 +0000 Date: Thu, 04 Jan 2024 10:42:33 +0100 Message-ID: <87a5pla0za.wl-tiwai@suse.de> From: Takashi Iwai To: Mark Hills Cc: Geraldo Nascimento , alsa-devel@alsa-project.org Subject: Re: Regression in Final Scratch 'ScratchAmp' quirk (DJ interface) In-Reply-To: References: <05f7b47d-1762-c6aa-ddb1-3c6f6128cf44@xwax.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Spamd-Bar: / X-Spamd-Result: default: False [0.44 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; TO_DN_SOME(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+]; MX_GOOD(-0.01)[]; MID_CONTAINS_FROM(1.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_CC(0.00)[gmail.com,alsa-project.org]; RCVD_TLS_ALL(0.00)[]; BAYES_HAM(-0.25)[73.31%] Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=PzZ4zto4; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=AlRtKVuy X-Rspamd-Queue-Id: 2503C21EDE Message-ID-Hash: XLGUC5WVFOHY5AMV5B7Q5G3LKAXLC4PJ X-Message-ID-Hash: XLGUC5WVFOHY5AMV5B7Q5G3LKAXLC4PJ X-MailFrom: tiwai@suse.de X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.9 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, 04 Jan 2024 00:53:40 +0100, Geraldo Nascimento wrote: > > On Wed, Jan 03, 2024 at 03:54:29PM +0000, Mark Hills wrote: > > The ScratchAmp worked perfectly with a quirk, but now that seems to have > > regressed and the device is no longer detected [1]. > > > > It's design is from 2002, based on class-compliant (Philips UDA1325H) > > chips. It hides itself behind a 'vendor specific' description, presumably > > as it was launched in a closed system with specific hardware and software > > for DJ'ing. > > Hi Mark, great fan of your work with xwax here. > > Perhaps adding USB_DEVICE_VENDOR_SPEC(0x103d, 0x0100) and > USB_DEVICE_VENDOR_SPEC(0x103d, 0x0101) to quirks-table.h can do the > trick? Yes, something like below. If this doesn't work, try to replace USB_DEVICE_VENDOR_SPEC() with USB_AUDIO_DEVICE() in the patch. In anyway, please give lsusb -v output of the specific device, too. Takashi -- 8< -- --- a/sound/usb/quirks-table.h +++ b/sound/usb/quirks-table.h @@ -169,6 +169,10 @@ { USB_AUDIO_DEVICE(0x046d, 0x08f6) }, { USB_AUDIO_DEVICE(0x046d, 0x0990) }, +/* Stanton ScratchAmp */ +{ USB_DEVICE_VENDOR_SPEC(0x103d, 0x0100) }, +{ USB_DEVICE_VENDOR_SPEC(0x103d, 0x0101) }, + /* * Yamaha devices */