All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: bo liu <bo.liu@senarytech.com>
Cc: perex@perex.cz, tiwai@suse.com, linux-sound@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] Fix headset auto detect fail in cx8070 and SN6140
Date: Fri, 29 Dec 2023 16:15:15 +0100	[thread overview]
Message-ID: <87a5ptxcos.wl-tiwai@suse.de> (raw)
In-Reply-To: <20231227071008.13665-1-bo.liu@senarytech.com>

On Wed, 27 Dec 2023 08:10:06 +0100,
bo liu wrote:
> 
> CX8070 and SN6140 will get wrong headset type when use OMTP headset, then the headset mic will not work.
> 
> Signed-off-by: bo liu <bo.liu@senarytech.com>

Well, the patch series has a serious problem, unfortunately.

Basically the patch that is submitted to the upstream should be in the
final form.  But this series puts the coding style errors and then
corrects multiple times in the series.  This is absolutely no-go.

Create a "perfect patch", and submit it, instead.

For that, you'll need to give a bit more detailed patch description.
Currently it says nothing but the problem.  It doesn't mention how and
what to be fixed / changed.  Ideally speaking, the patch should have a
description that is self-explanatory.

Last but not least, please put the proper subject prefix.
In your case, it'd be like "ALSA: hda/conexant:".

Please try to address the above points and resubmit.


thanks,

Takashi

      parent reply	other threads:[~2023-12-29 15:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20231227071008.13665-1-bo.liu@senarytech.com>
2023-12-27  7:10 ` [PATCH 2/3] Fix headset auto detect fail in cx8070 and SN6140 bo liu
2023-12-27  7:10 ` [PATCH 3/3] " bo liu
2023-12-29 15:15 ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a5ptxcos.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=bo.liu@senarytech.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.