From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 78789C35274 for ; Mon, 18 Dec 2023 18:51:34 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 13D0F10E100; Mon, 18 Dec 2023 18:51:34 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id D728710E3EC for ; Mon, 18 Dec 2023 18:51:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1702925484; x=1734461484; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version:content-transfer-encoding; bh=m/BAqVtnWKDNn7QxaLlP8H8HdpsPYfglSRq2rgWWj8w=; b=Vy9xOPVYtWaG1XNpGs42XxRC6/q50mp/g/JT7UsHpg6XheHV/NWD9D1Q UrrF1y9hEjgoLgaHjXpXau+H9GSqtGGLX/tDzVCMu1Hzza6C9/9GKZKgS B+pDbhVcixemFe9FOlrzq8ogfLNkJNygle4T8y6x4/RvYEzwJgzgb14tl yOdfiMGTdeiOtYJjNE8LYuUTSc2OcWmEfPwlnEqs7ryC6Nv9FEyxXM4Es ngcuOyDt9vK4uo72qQdl/vuyAA8bi7b1v3NsggeMgvv2nvI5OmZfRLOEy scnvZQQvp5XzzfYnIPt74bN2Z/axTLDahzYuStq18AndABepeCzFF6rdn w==; X-IronPort-AV: E=McAfee;i="6600,9927,10928"; a="380531601" X-IronPort-AV: E=Sophos;i="6.04,286,1695711600"; d="scan'208";a="380531601" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Dec 2023 10:51:23 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10928"; a="841581167" X-IronPort-AV: E=Sophos;i="6.04,286,1695711600"; d="scan'208";a="841581167" Received: from adixit-mobl.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.209.85.106]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Dec 2023 10:51:23 -0800 Date: Mon, 18 Dec 2023 10:51:03 -0800 Message-ID: <87a5q7uyy0.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Thomas =?ISO-8859-1?Q?Hellstr=F6m?= Subject: Re: [PATCH] drm/xe: Fix build without CONFIG_FAULT_INJECTION In-Reply-To: <9ab982c2-f278-e54d-09b4-e6738c443dce@linux.intel.com> References: <20231218143023.1688831-1-rodrigo.vivi@intel.com> <9ab982c2-f278-e54d-09b4-e6738c443dce@linux.intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Himal Prasad Ghimiray , intel-gfx@lists.freedesktop.org, Lucas De Marchi , Oded Gabbay , Rodrigo Vivi Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Mon, 18 Dec 2023 06:57:14 -0800, Thomas Hellstr=F6m wrote: > > > On 12/18/23 15:30, Rodrigo Vivi wrote: > > Ideally this header could be included without the CONFIG_FAULT_INJECTION > > and it would take care itself for the includes it needs. > > So, let's temporary workaround this by moving this below and including > > only when CONFIG_FAULT_INJECTION is selected to avoid build breakages. > > > > Another solution would be us including the linux/types.h as well, but > > this creates unnecessary cases. > > > > Reference: https://lore.kernel.org/all/20230816134748.979231-1-himal.pr= asad.ghimiray@intel.com/ > > Cc: Himal Prasad Ghimiray > > Cc: Oded Gabbay > > Cc: Thomas Hellstr=F6m > > Cc: Lucas De Marchi > > Signed-off-by: Rodrigo Vivi > LGTM. > > Reviewed-by: Thomas Hellstr=F6m Hmm, msm/msm_drv.c doesn't seem to need to do this. Anyway maybe ok for a temporary fix...