From: Fabiano Rosas <farosas@suse.de>
To: Het Gala <het.gala@nutanix.com>, qemu-devel@nongnu.org
Cc: prerna.saxena@nutanix.com, quintela@redhat.com,
berrange@redhat.com, peter.maydell@linaro.org, armbru@redhat.com,
Het Gala <het.gala@nutanix.com>
Subject: Re: [PATCH] migration: Simplify initial conditionals in migration for better readability
Date: Tue, 05 Dec 2023 09:58:24 -0300 [thread overview]
Message-ID: <87a5qon6vj.fsf@suse.de> (raw)
In-Reply-To: <20231205080039.197615-1-het.gala@nutanix.com>
Het Gala <het.gala@nutanix.com> writes:
> The inital conditional statements in qmp migration functions is harder
> to understand than necessary. It is better to get all errors out of
> the way in the beginning itself to have better readability and error
> handling.
>
> Signed-off-by: Het Gala <het.gala@nutanix.com>
> Suggested-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Fabiano Rosas <farosas@suse.de>
next prev parent reply other threads:[~2023-12-05 12:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-05 8:00 [PATCH] migration: Simplify initial conditionals in migration for better readability Het Gala
2023-12-05 8:03 ` Het Gala
2023-12-05 12:58 ` Fabiano Rosas [this message]
2023-12-11 13:13 ` Het Gala
2024-01-04 7:43 ` Het Gala
2024-01-04 8:07 ` Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a5qon6vj.fsf@suse.de \
--to=farosas@suse.de \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=het.gala@nutanix.com \
--cc=peter.maydell@linaro.org \
--cc=prerna.saxena@nutanix.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.