From: Jani Nikula <jani.nikula@intel.com>
To: kernel test robot <yujie.liu@intel.com>, Oak Zeng <oak.zeng@intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>,
intel-xe@lists.freedesktop.org, oe-kbuild-all@lists.linux.dev
Subject: Re: [Intel-xe] [drm-xe:oak/drm-evictable-lru 2911/3055] drivers/gpu/drm/i915/display/intel_display_power.h: linux/mutex.h is included more than once.
Date: Tue, 07 Nov 2023 10:41:51 +0200 [thread overview]
Message-ID: <87a5rqymy8.fsf@intel.com> (raw)
In-Reply-To: <202311070416.8nPv4n6G-lkp@intel.com>
On Tue, 07 Nov 2023, kernel test robot <yujie.liu@intel.com> wrote:
> tree: https://gitlab.freedesktop.org/drm/xe/kernel.git oak/drm-evictable-lru
Why do we have this stale branch? I don't think developers should push
their branches to xe/kernel.git but their own repos instead.
BR,
Jani.
> head: d1f59526925ae851c6abf77af8ae6f8c3cffeebd
> commit: 304baa8c20cfad330a6c7cad47d86043e968642c [2911/3055] FIXME: drm/i915: add a lot of includes in intel_display_power.h
> compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <yujie.liu@intel.com>
> | Closes: https://lore.kernel.org/r/202311070416.8nPv4n6G-lkp@intel.com/
>
> includecheck warnings: (new ones prefixed by >>)
>>> drivers/gpu/drm/i915/display/intel_display_power.h: linux/mutex.h is included more than once.
>>> drivers/gpu/drm/i915/display/intel_display_power.h: linux/workqueue.h is included more than once.
>
> vim +9 drivers/gpu/drm/i915/display/intel_display_power.h
>
> 8
> > 9 #include <linux/mutex.h>
> 10 #include <linux/workqueue.h>
> 11
> 12 #include "intel_wakeref.h"
> 13 #include <linux/types.h>
> 14 #include <linux/bitops.h>
> > 15 #include <linux/mutex.h>
> 16 #include <linux/workqueue.h>
> 17 #include "intel_runtime_pm.h"
> 18
--
Jani Nikula, Intel
WARNING: multiple messages have this Message-ID (diff)
From: Jani Nikula <jani.nikula@intel.com>
To: kernel test robot <yujie.liu@intel.com>, Oak Zeng <oak.zeng@intel.com>
Cc: oe-kbuild-all@lists.linux.dev, intel-xe@lists.freedesktop.org,
Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: Re: [drm-xe:oak/drm-evictable-lru 2911/3055] drivers/gpu/drm/i915/display/intel_display_power.h: linux/mutex.h is included more than once.
Date: Tue, 07 Nov 2023 10:41:51 +0200 [thread overview]
Message-ID: <87a5rqymy8.fsf@intel.com> (raw)
In-Reply-To: <202311070416.8nPv4n6G-lkp@intel.com>
On Tue, 07 Nov 2023, kernel test robot <yujie.liu@intel.com> wrote:
> tree: https://gitlab.freedesktop.org/drm/xe/kernel.git oak/drm-evictable-lru
Why do we have this stale branch? I don't think developers should push
their branches to xe/kernel.git but their own repos instead.
BR,
Jani.
> head: d1f59526925ae851c6abf77af8ae6f8c3cffeebd
> commit: 304baa8c20cfad330a6c7cad47d86043e968642c [2911/3055] FIXME: drm/i915: add a lot of includes in intel_display_power.h
> compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <yujie.liu@intel.com>
> | Closes: https://lore.kernel.org/r/202311070416.8nPv4n6G-lkp@intel.com/
>
> includecheck warnings: (new ones prefixed by >>)
>>> drivers/gpu/drm/i915/display/intel_display_power.h: linux/mutex.h is included more than once.
>>> drivers/gpu/drm/i915/display/intel_display_power.h: linux/workqueue.h is included more than once.
>
> vim +9 drivers/gpu/drm/i915/display/intel_display_power.h
>
> 8
> > 9 #include <linux/mutex.h>
> 10 #include <linux/workqueue.h>
> 11
> 12 #include "intel_wakeref.h"
> 13 #include <linux/types.h>
> 14 #include <linux/bitops.h>
> > 15 #include <linux/mutex.h>
> 16 #include <linux/workqueue.h>
> 17 #include "intel_runtime_pm.h"
> 18
--
Jani Nikula, Intel
next prev parent reply other threads:[~2023-11-07 8:42 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-06 20:48 [drm-xe:oak/drm-evictable-lru 2911/3055] drivers/gpu/drm/i915/display/intel_display_power.h: linux/mutex.h is included more than once kernel test robot
2023-11-07 2:39 ` kernel test robot
2023-11-07 2:39 ` [Intel-xe] " kernel test robot
2023-11-07 8:41 ` Jani Nikula [this message]
2023-11-07 8:41 ` Jani Nikula
2023-11-07 14:53 ` [Intel-xe] " Zeng, Oak
2023-11-07 14:53 ` Zeng, Oak
2023-11-07 16:24 ` [Intel-xe] " Lucas De Marchi
2023-11-07 16:24 ` Lucas De Marchi
2023-11-08 10:02 ` Jani Nikula
2023-11-08 10:02 ` Jani Nikula
2023-11-08 15:43 ` Lucas De Marchi
2023-11-08 15:43 ` Lucas De Marchi
2023-11-08 17:37 ` Jani Nikula
2023-11-08 17:37 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a5rqymy8.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=oak.zeng@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=rodrigo.vivi@intel.com \
--cc=yujie.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.