All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Ellerman <mpe@ellerman.id.au>
To: Eddie James <eajames@linux.ibm.com>, linuxppc-dev@lists.ozlabs.org
Cc: paulus@samba.org
Subject: Re: KUEP broken on FSP2?
Date: Tue, 10 Oct 2023 00:14:07 +1100	[thread overview]
Message-ID: <87a5ssrl9c.fsf@mail.lhotse> (raw)
In-Reply-To: <fdaadc46-7476-9237-e104-1d2168526e72@linux.ibm.com>

Eddie James <eajames@linux.ibm.com> writes:
> Hi,
>
> I'm attempting to run linux 6.1 on my FSP2, but my kernel crashes 
> attempting to get into userspace. The init script works, but the first 
> binary (mount) I run results in oops. Can anyone help me to debug this 
> further or suggest anything?

Hi Eddie,

It looks like breakage in syscall_exit_finish.

Can you test this? Patch is against v6.1.

cheers


diff --git a/arch/powerpc/kernel/entry_32.S b/arch/powerpc/kernel/entry_32.S
index 3fc7c9886bb7..decd2594fb9c 100644
--- a/arch/powerpc/kernel/entry_32.S
+++ b/arch/powerpc/kernel/entry_32.S
@@ -135,7 +135,8 @@ ret_from_syscall:
 	lis	r4,icache_44x_need_flush@ha
 	lwz	r5,icache_44x_need_flush@l(r4)
 	cmplwi	cr0,r5,0
-	bne-	2f
+	bne-	.L44x_icache_flush
+.L44x_icache_flush_return:
 #endif /* CONFIG_PPC_47x */
 	kuep_unlock
 	lwz	r4,_LINK(r1)
@@ -170,10 +171,11 @@ syscall_exit_finish:
 	b	1b
 
 #ifdef CONFIG_44x
-2:	li	r7,0
+.L44x_icache_flush:
+	li	r7,0
 	iccci	r0,r0
 	stw	r7,icache_44x_need_flush@l(r4)
-	b	1b
+	b	.L44x_icache_flush_return
 #endif  /* CONFIG_44x */
 
 	.globl	ret_from_fork

  parent reply	other threads:[~2023-10-09 13:15 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-05 19:06 KUEP broken on FSP2? Eddie James
2023-10-06  5:21 ` Christophe Leroy
2023-10-06 15:43   ` Eddie James
2023-10-06 15:55     ` Christophe Leroy
2023-10-06 16:16       ` Eddie James
2023-10-09 13:14 ` Michael Ellerman [this message]
2023-10-09 15:12   ` Eddie James
2023-10-09 16:02     ` Christophe Leroy
2023-10-10 11:03       ` Michael Ellerman
2023-10-10 10:59     ` Michael Ellerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a5ssrl9c.fsf@mail.lhotse \
    --to=mpe@ellerman.id.au \
    --cc=eajames@linux.ibm.com \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.