From: Jonathan Corbet <corbet@lwn.net>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Randy Dunlap <rdunlap@infradead.org>,
Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH v2 1/1] Documentation: core-api: Drop :export: for int_log.h
Date: Tue, 25 Jul 2023 07:12:25 -0600 [thread overview]
Message-ID: <87a5vkb0ee.fsf@meer.lwn.net> (raw)
In-Reply-To: <20230725104956.47806-1-andriy.shevchenko@linux.intel.com>
Andy Shevchenko <andriy.shevchenko@linux.intel.com> writes:
> The :export: keyword makes sense only for C-files, where EXPORT_SYMBOL()
> might appear. Otherwise kernel-doc may not produce anything out of this
> file.
>
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Fixes: f97fa3dcb2db ("lib/math: Move dvb_math.c into lib/math/int_log.c")
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Reviewed-by: Randy Dunlap <rdunlap@infradead.org>
> Acked-by: Jonathan Corbet <corbet@lwn.net>
> ---
> v2: added tags (Randy, Jonathan), assumed to go via ASoC tree
> Documentation/core-api/kernel-api.rst | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/Documentation/core-api/kernel-api.rst b/Documentation/core-api/kernel-api.rst
> index a526fbe06f86..ae92a2571388 100644
> --- a/Documentation/core-api/kernel-api.rst
> +++ b/Documentation/core-api/kernel-api.rst
> @@ -166,7 +166,6 @@ Integer log and power Functions
> -------------------------------
>
> .. kernel-doc:: include/linux/int_log.h
> - :export:
>
So I still can't take this patch for the reasons described before. It
looks like Mark took the patch that added the problem, so perhaps he
should be a recipient of this one too? I'll add him to the CC...
jon
next prev parent reply other threads:[~2023-07-25 13:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-25 10:49 [PATCH v2 1/1] Documentation: core-api: Drop :export: for int_log.h Andy Shevchenko
2023-07-25 13:12 ` Jonathan Corbet [this message]
2023-07-25 13:16 ` Andy Shevchenko
2023-07-25 13:46 ` Mark Brown
2023-07-25 14:06 ` Andy Shevchenko
2023-07-25 14:27 ` Mark Brown
2023-07-25 14:40 ` Andy Shevchenko
2023-07-25 14:51 ` Mark Brown
2023-07-25 15:16 ` Andy Shevchenko
2023-07-25 19:20 ` Mark Brown
2023-07-26 14:45 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a5vkb0ee.fsf@meer.lwn.net \
--to=corbet@lwn.net \
--cc=andriy.shevchenko@linux.intel.com \
--cc=broonie@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.