From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0E39F806 for ; Thu, 13 Jul 2023 07:11:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 66801C433C7; Thu, 13 Jul 2023 07:11:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689232265; bh=87u0uVc4m8dwK8STDxzH0B+JYZxw5H4A6cpYY4fUcVk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=M5fe+3Nv4uWw9xUEl4og0bNdulsAG4Wv0aOOpcut/4qnoKnCyrm6dSLGl01WhldJ8 EqlEfcPTDutXMKutBbqlqPAhAG8/XaX4OK7tvv/H40PpO+r5UhoNWlpr/hd08+/rEm hMyafnmXLXOwvRr50TVv53BUYRFKv8Zinx4TV+fC90rV06ENE3B5fFoURSIClKzVj3 9f64FljrixqF9IWrMzYZOf/P98GuARa3nCKM2M+f1XALLAzDVphHM3VDossr6llC6H u5/FdCDfCEjr1JN/qP4FqOWV/hw8SBC0IAAr0rw2Fb//i/BR5ktXEkNVbLBW9zhtsp duOA+ZEHbV6hQ== Received: from ip-185-104-136-29.ptr.icomera.net ([185.104.136.29] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1qJqTe-00Chhs-Re; Thu, 13 Jul 2023 08:11:03 +0100 Date: Thu, 13 Jul 2023 08:11:00 +0100 Message-ID: <87a5w09th7.wl-maz@kernel.org> From: Marc Zyngier To: Oliver Upton Cc: "chenxiang (M)" , Zenghui Yu , kvmarm@lists.linux.dev, James Morse , Suzuki K Poulose , stable@vger.kernel.org Subject: Re: [PATCH] KVM: arm64: vgic-v4: Consistently request doorbell irq for blocking vCPU In-Reply-To: References: <20230710175553.1477762-1-oliver.upton@linux.dev> <86jzv6x66q.wl-maz@kernel.org> <14acf0fd-e5eb-8a14-986a-b8fe4a44cec9@huawei.com> <86zg41utno.wl-maz@kernel.org> <092f42c5-02d1-6f05-ea92-0eae3a55341e@hisilicon.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.104.136.29 X-SA-Exim-Rcpt-To: oliver.upton@linux.dev, chenxiang66@hisilicon.com, yuzenghui@huawei.com, kvmarm@lists.linux.dev, james.morse@arm.com, suzuki.poulose@arm.com, stable@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Thu, 13 Jul 2023 07:01:39 +0100, Oliver Upton wrote: > > On Thu, Jul 13, 2023 at 01:57:46PM +0800, chenxiang (M) wrote: > > > Of course, it is totally untested... ;-) But I like that the doorbell > > > request is solely driven by the WFI state, and we avoid leaking the > > > knowledge outside of the vgic code. > > > > I have tested this approach and it also solves the issue. Please feel free > > to add: > > Tested-by: Xiang Chen > > Excellent, thanks for testing a couple of iterations for us here. Marc, > do you want to add a changelog to this? Done [1]. I've nicked most of your changelog, so you get a CDB tag ;-) Thanks, M. [1] https://lore.kernel.org/all/20230713070657.3873244-1-maz@kernel.org/ -- Without deviation from the norm, progress is not possible.