From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 04E5F611B for ; Thu, 15 Jun 2023 09:51:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 676D6C433C0; Thu, 15 Jun 2023 09:51:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686822705; bh=LM3vizWVElx+XfZb1koUqZg3HSV3Fg3PE1hrl5+LRp0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=bzsuyyxMQlSLtVRMItcciPoEa51HDduUY67+4FH6T9eqX5DL5rykCB57E8j22ySOI fEInuWSONKmCE3dZWGG5uXQWiXxltaXOOujHPc9rUy+ANFzJKbux1OTjaF+lukND6+ CVW2XmdhclNq6hjeBaqVGAZULGtsINeD+xzENFX8nQq0/HHKUqLoF48sEkTxea5sJN 7X9qy7AaqhTVQHU3DCyr5LUwECyPUcHB+3TVp0tDa9owbnPQDBdW3imxwO+xVGM9GE eFJ6NZQ/ChA7ndOLb+qDKjykXX0ZztXg+AvmBQxOWsGJHpWR9Go9NBSb00miTpbqUn myC6vOkzOc1Ow== Received: from [213.175.39.66] (helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1q9jdm-005ZDI-Ha; Thu, 15 Jun 2023 10:51:43 +0100 Date: Thu, 15 Jun 2023 10:51:42 +0100 Message-ID: <87a5x1qci9.wl-maz@kernel.org> From: Marc Zyngier To: Oliver Upton Cc: kvmarm@lists.linux.dev, James Morse , Suzuki K Poulose , Zenghui Yu , Will Deacon , Catalin Marinas , linux-arm-kernel@lists.infradead.org, Darren Hart , D Scott Phillips Subject: Re: [PATCH 0/3] KVM: arm64: Work around Ampere1 erratum AC03_CPU_38 In-Reply-To: <20230609220104.1836988-1-oliver.upton@linux.dev> References: <20230609220104.1836988-1-oliver.upton@linux.dev> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 213.175.39.66 X-SA-Exim-Rcpt-To: oliver.upton@linux.dev, kvmarm@lists.linux.dev, james.morse@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, will@kernel.org, catalin.marinas@arm.com, linux-arm-kernel@lists.infradead.org, darren@os.amperecomputing.com, scott@os.amperecomputing.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Fri, 09 Jun 2023 23:01:01 +0100, Oliver Upton wrote: > > Hi folks, > > Small series to work around a CPU erratum on AmpereOne. While the > implementation does not advertise support for FEAT_HAFDBS (due to > another erratum), the associated control bits do not have RES0 behavior > as required by the architecture. > > Usage of HAFDBS at stage-1 is unaffected, since HA and HD are only > enabled on implementations that advertise the feature. However, KVM > relies on HA having RES0 semantics if the feature isn't implemented. The > end result is that KVM enables a broken hardware access flag > implementation that could lead to correctness issues. > > Applies to 6.4-rc1. Tested with access_tracking_perf_test, verifying > that KVM is indeed taking Access Flag faults. For the series: Reviewed-by: Marc Zyngier M. -- Without deviation from the norm, progress is not possible. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D045BEB64DC for ; Thu, 15 Jun 2023 09:52:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=XbK266kdgVxZuxvEudG+yUzH2mW3Gprcm1Dsw8x+hCk=; b=kfM9hiBT/uiJNL Y8JD6wVj0lsx7q1JR952nC4oMQn02xTBTcbOJVAagNtUhxHUBHeMCIN0FcQo2bFwI0BNSbklHUA0Z kM+9Eu6cZWx3GtJTQVr42XxrlzN0NhkbQLcCXvw6z4eYp2m0AiImxYkT5g5NaxwF39S2U3XTZuOUI ce20wzTTkIZWrOz11oSJxYMzijYu71CNdZP6LUcmXRxdpgDqcULYiX7xstUM6u+Dfbn749uE9rPB8 s0JMrmPDLjFN6aGX43PLct3xGwq5NTM++U7qsSuXH2uAaufmNuIBc/XJsaXSLhfheiiEw/iGh0VGS U1cN4dxNnfZLveTq9Kwg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q9jdt-00ENIR-0a; Thu, 15 Jun 2023 09:51:49 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q9jdq-00ENEf-1V for linux-arm-kernel@lists.infradead.org; Thu, 15 Jun 2023 09:51:47 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0B9DB62D0F; Thu, 15 Jun 2023 09:51:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 676D6C433C0; Thu, 15 Jun 2023 09:51:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686822705; bh=LM3vizWVElx+XfZb1koUqZg3HSV3Fg3PE1hrl5+LRp0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=bzsuyyxMQlSLtVRMItcciPoEa51HDduUY67+4FH6T9eqX5DL5rykCB57E8j22ySOI fEInuWSONKmCE3dZWGG5uXQWiXxltaXOOujHPc9rUy+ANFzJKbux1OTjaF+lukND6+ CVW2XmdhclNq6hjeBaqVGAZULGtsINeD+xzENFX8nQq0/HHKUqLoF48sEkTxea5sJN 7X9qy7AaqhTVQHU3DCyr5LUwECyPUcHB+3TVp0tDa9owbnPQDBdW3imxwO+xVGM9GE eFJ6NZQ/ChA7ndOLb+qDKjykXX0ZztXg+AvmBQxOWsGJHpWR9Go9NBSb00miTpbqUn myC6vOkzOc1Ow== Received: from [213.175.39.66] (helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1q9jdm-005ZDI-Ha; Thu, 15 Jun 2023 10:51:43 +0100 Date: Thu, 15 Jun 2023 10:51:42 +0100 Message-ID: <87a5x1qci9.wl-maz@kernel.org> From: Marc Zyngier To: Oliver Upton Cc: kvmarm@lists.linux.dev, James Morse , Suzuki K Poulose , Zenghui Yu , Will Deacon , Catalin Marinas , linux-arm-kernel@lists.infradead.org, Darren Hart , D Scott Phillips Subject: Re: [PATCH 0/3] KVM: arm64: Work around Ampere1 erratum AC03_CPU_38 In-Reply-To: <20230609220104.1836988-1-oliver.upton@linux.dev> References: <20230609220104.1836988-1-oliver.upton@linux.dev> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 213.175.39.66 X-SA-Exim-Rcpt-To: oliver.upton@linux.dev, kvmarm@lists.linux.dev, james.morse@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, will@kernel.org, catalin.marinas@arm.com, linux-arm-kernel@lists.infradead.org, darren@os.amperecomputing.com, scott@os.amperecomputing.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230615_025146_542012_6140A5CB X-CRM114-Status: GOOD ( 17.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 09 Jun 2023 23:01:01 +0100, Oliver Upton wrote: > > Hi folks, > > Small series to work around a CPU erratum on AmpereOne. While the > implementation does not advertise support for FEAT_HAFDBS (due to > another erratum), the associated control bits do not have RES0 behavior > as required by the architecture. > > Usage of HAFDBS at stage-1 is unaffected, since HA and HD are only > enabled on implementations that advertise the feature. However, KVM > relies on HA having RES0 semantics if the feature isn't implemented. The > end result is that KVM enables a broken hardware access flag > implementation that could lead to correctness issues. > > Applies to 6.4-rc1. Tested with access_tracking_perf_test, verifying > that KVM is indeed taking Access Flag faults. For the series: Reviewed-by: Marc Zyngier M. -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel