From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1CC2EC77B75 for ; Mon, 22 May 2023 09:29:03 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q11pW-0006Nx-T3; Mon, 22 May 2023 05:27:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q11pN-0006NT-SV for qemu-devel@nongnu.org; Mon, 22 May 2023 05:27:45 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q11pJ-0008SI-OS for qemu-devel@nongnu.org; Mon, 22 May 2023 05:27:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1684747655; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=svl96UbgxOrNJsGyBEyVrVo2uzgo2T8dXkCqRYlrzOI=; b=LaN2a2vz5gpdmuAhaVsVy7xDkrqw/SUx33HVhDFCqvAn24s7x0kQUPTPj+DFiSEMghHOVU FkhVd/9OHJ6ZtPh3u2G/TE+ncxxjAenQidOGvL0v8HE+EDuAGp13kNlFGvNNWQlpESMwze Zw39zJ64iAaVMI8PFBUMu1ZVCU84W1c= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-624-mF6LJuzGOeeRWE03K9YUMA-1; Mon, 22 May 2023 05:27:29 -0400 X-MC-Unique: mF6LJuzGOeeRWE03K9YUMA-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id EF444185A78B; Mon, 22 May 2023 09:27:28 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.39.192.91]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 88FE5140E95D; Mon, 22 May 2023 09:27:28 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 56F6421E692E; Mon, 22 May 2023 11:27:27 +0200 (CEST) From: Markus Armbruster To: "Michael S. Tsirkin" Cc: Vladimir Sementsov-Ogievskiy , qemu-devel@nongnu.org, eblake@redhat.com, eduardo@habkost.net, berrange@redhat.com, pbonzini@redhat.com, marcel.apfelbaum@gmail.com, philmd@linaro.org, antonkuchin@yandex-team.ru, den-plotnikov@yandex-team.ru Subject: Re: [PATCH v7 1/4] qapi/qdev.json: unite DEVICE_* event data into single structure References: <20230421103207.845847-1-vsementsov@yandex-team.ru> <20230421103207.845847-2-vsementsov@yandex-team.ru> <20230518160434-mutt-send-email-mst@kernel.org> Date: Mon, 22 May 2023 11:27:27 +0200 In-Reply-To: <20230518160434-mutt-send-email-mst@kernel.org> (Michael S. Tsirkin's message of "Thu, 18 May 2023 16:06:28 -0400") Message-ID: <87a5xwogw0.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 Received-SPF: pass client-ip=170.10.133.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org "Michael S. Tsirkin" writes: > On Fri, Apr 21, 2023 at 01:32:04PM +0300, Vladimir Sementsov-Ogievskiy wrote: >> DEVICE_DELETED and DEVICE_UNPLUG_GUEST_ERROR has equal data, let's >> refactor it to one structure. That also helps to add new events >> consistently. >> >> Signed-off-by: Vladimir Sementsov-Ogievskiy > > Can QAPI maintainers please review this patchset? > It's been a month. It's been a busy month; sorry for the delay. >> --- >> qapi/qdev.json | 39 +++++++++++++++++++++++++++------------ >> 1 file changed, 27 insertions(+), 12 deletions(-) >> >> diff --git a/qapi/qdev.json b/qapi/qdev.json >> index 2708fb4e99..135cd81586 100644 >> --- a/qapi/qdev.json >> +++ b/qapi/qdev.json >> @@ -114,16 +114,37 @@ >> { 'command': 'device_del', 'data': {'id': 'str'} } >> >> ## >> -# @DEVICE_DELETED: >> +# @DeviceAndPath: >> # >> -# Emitted whenever the device removal completion is acknowledged by the guest. >> -# At this point, it's safe to reuse the specified device ID. Device removal can >> -# be initiated by the guest or by HMP/QMP commands. >> +# In events we designate devices by both their ID (if the device has one) >> +# and QOM path. >> +# >> +# Why we need ID? User specify ID in device_add command and in command line >> +# and expects same identifier in the event data. >> +# >> +# Why we need QOM path? Some devices don't have ID and we still want to emit >> +# events for them. >> +# >> +# So, we have a bit of redundancy, as QOM path for device that has ID is >> +# always /machine/peripheral/ID. But that's hard to change keeping both >> +# simple interface for most users and universality for the generic case. Hmm. I appreciate rationale, but I'm not sure it fits here. Would readers be worse off if we dropped it? >> # >> # @device: the device's ID if it has one >> # >> # @path: the device's QOM path >> # >> +# Since: 8.0 >> +## >> +{ 'struct': 'DeviceAndPath', >> + 'data': { '*device': 'str', 'path': 'str' } } >> + > > Should be Since: 8.1 no? Yes. Please format like ## # @DeviceAndPath: # # In events we designate devices by both their ID (if the device has # one) and QOM path. # # Why we need ID? User specify ID in device_add command and in # command line and expects same identifier in the event data. # # Why we need QOM path? Some devices don't have ID and we still want # to emit events for them. # # So, we have a bit of redundancy, as QOM path for device that has ID # is always /machine/peripheral/ID. But that's hard to change keeping # both simple interface for most users and universality for the # generic case. # # @device: the device's ID if it has one # # @path: the device's QOM path # # Since: 8.0 ## to blend in with recent commit a937b6aa739 (qapi: Reformat doc comments to conform to current conventions). >> +## >> +# @DEVICE_DELETED: >> +# >> +# Emitted whenever the device removal completion is acknowledged by the guest. >> +# At this point, it's safe to reuse the specified device ID. Device removal can >> +# be initiated by the guest or by HMP/QMP commands. >> +# Conflict resolution: # Emitted whenever the device removal completion is acknowledged by # the guest. At this point, it's safe to reuse the specified device # ID. Device removal can be initiated by the guest or by HMP/QMP # commands. >> # Since: 1.5 >> # >> # Example: >> @@ -134,18 +155,13 @@ >> # "timestamp": { "seconds": 1265044230, "microseconds": 450486 } } >> # >> ## >> -{ 'event': 'DEVICE_DELETED', >> - 'data': { '*device': 'str', 'path': 'str' } } >> +{ 'event': 'DEVICE_DELETED', 'data': 'DeviceAndPath' } >> >> ## >> # @DEVICE_UNPLUG_GUEST_ERROR: >> # >> # Emitted when a device hot unplug fails due to a guest reported error. >> # >> -# @device: the device's ID if it has one >> -# >> -# @path: the device's QOM path >> -# >> # Since: 6.2 >> # >> # Example: >> @@ -156,5 +172,4 @@ >> # "timestamp": { "seconds": 1615570772, "microseconds": 202844 } } >> # >> ## >> -{ 'event': 'DEVICE_UNPLUG_GUEST_ERROR', >> - 'data': { '*device': 'str', 'path': 'str' } } >> +{ 'event': 'DEVICE_UNPLUG_GUEST_ERROR', 'data': 'DeviceAndPath' } >> -- >> 2.34.1