From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DBB22C77B75 for ; Mon, 22 May 2023 06:39:20 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q0zBs-0000KQ-Po; Mon, 22 May 2023 02:38:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q0zBq-0000K8-Ik for qemu-devel@nongnu.org; Mon, 22 May 2023 02:38:42 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q0zBl-0007kc-G8 for qemu-devel@nongnu.org; Mon, 22 May 2023 02:38:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1684737515; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jBaySRTwv+bppajLdfrfx8I2knxfsIL8HJLvl5wsBDc=; b=Y0ookLrSo4ZFp3+oLD5+XnglduXSmklsu+e693utIahBinVVywGQC6dISW2mNch0RoinaN C2cWWrOLLjhQVRS9LRHg7R82ZhwEUAHQds2V4hS13uQtC0bnCPRJz6ZnTI/meq1ESdlFDJ w5pW1pwArYsTFuBLyUXCrfLBAHu5RGo= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-434-WZ-2m3mVP6aQFb4Evp8_Zg-1; Mon, 22 May 2023 02:38:32 -0400 X-MC-Unique: WZ-2m3mVP6aQFb4Evp8_Zg-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 891C485A5A8; Mon, 22 May 2023 06:38:31 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.39.192.91]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0E3EC7AF5; Mon, 22 May 2023 06:38:30 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id BAFEB21E692E; Mon, 22 May 2023 08:38:29 +0200 (CEST) From: Markus Armbruster To: Jonathan Cameron Cc: , Michael Tsirkin , Fan Ni , , , Ira Weiny , Alison Schofield , Michael Roth , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Dave Jiang , Daniel P . =?utf-8?Q?Berrang=C3=A9?= , Eric Blake , Mike Maslenkin , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , Thomas Huth Subject: Re: [PATCH v5 4/6] hw/cxl: QMP based poison injection support References: <20230423162013.4535-1-Jonathan.Cameron@huawei.com> <20230423162013.4535-5-Jonathan.Cameron@huawei.com> Date: Mon, 22 May 2023 08:38:29 +0200 In-Reply-To: <20230423162013.4535-5-Jonathan.Cameron@huawei.com> (Jonathan Cameron's message of "Sun, 23 Apr 2023 17:20:11 +0100") Message-ID: <87a5xwrhui.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 Received-SPF: pass client-ip=170.10.133.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Jonathan Cameron writes: > Inject poison using qmp command cxl-inject-poison to add an entry to the > poison list. > > For now, the poison is not returned CXL.mem reads, but only via the > mailbox command Get Poison List. So a normal memory read to an address > that is on the poison list will not yet result in a synchronous exception > (and similar for partial cacheline writes). > That is left for a future patch. > > See CXL rev 3.0, sec 8.2.9.8.4.1 Get Poison list (Opcode 4300h) > > Kernel patches to use this interface here: > https://lore.kernel.org/linux-cxl/cover.1665606782.git.alison.schofield@intel.com/ > > To inject poison using qmp (telnet to the qmp port) > { "execute": "qmp_capabilities" } > > { "execute": "cxl-inject-poison", > "arguments": { > "path": "/machine/peripheral/cxl-pmem0", > "start": 2048, > "length": 256 > } > } > > Adjusted to select a device on your machine. > > Note that the poison list supported is kept short enough to avoid the > complexity of state machine that is needed to handle the MORE flag. > > Reviewed-by: Fan Ni > Reviewed-by: Ira Weiny > Signed-off-by: Jonathan Cameron > > --- > v5: > - Picked up Fan Ni's tag > - Use ROUND_DOWN() as suggestion by Philippe > - Update qapi docs to 8.1 > - Added comment to clarify the lack of synchronous poison exceptions > that has been left for a future patch set. > --- > hw/cxl/cxl-mailbox-utils.c | 90 +++++++++++++++++++++++++++++++++++++ > hw/mem/cxl_type3.c | 56 +++++++++++++++++++++++ > hw/mem/cxl_type3_stubs.c | 6 +++ > include/hw/cxl/cxl.h | 1 + > include/hw/cxl/cxl_device.h | 20 +++++++++ > qapi/cxl.json | 18 ++++++++ > 6 files changed, 191 insertions(+) Please add [diff] orderFile = scripts/git.orderfile to your .git/config, so that QAPI schema changes come first in diffs. [...] > diff --git a/qapi/cxl.json b/qapi/cxl.json > index 4be7d46041..ca3af3f0b2 100644 > --- a/qapi/cxl.json > +++ b/qapi/cxl.json > @@ -5,6 +5,24 @@ > # = CXL devices > ## > > +## > +# @cxl-inject-poison: > +# > +# Poison records indicate that a CXL memory device knows that a particular > +# memory region may be corrupted. This may be because of locally detected > +# errors (e.g. ECC failure) or poisoned writes received from other components > +# in the system. This injection mechanism enables testing of the OS handling > +# of poison records which may be queried via the CXL mailbox. > +# > +# @path: CXL type 3 device canonical QOM path > +# @start: Start address - must be 64 byte aligned. > +# @length: Length of poison to inject - must be a multiple of 64 bytes. > +# > +# Since: 8.1 > +## > +{ 'command': 'cxl-inject-poison', > + 'data': { 'path': 'str', 'start': 'uint64', 'length': 'uint64' }} > + > ## > # @CxlUncorErrorType: > # Please format like ## # @cxl-inject-poison: # # Poison records indicate that a CXL memory device knows that a # particular memory region may be corrupted. This may be because of # locally detected errors (e.g. ECC failure) or poisoned writes # received from other components in the system. This injection # mechanism enables testing of the OS handling of poison records which # may be queried via the CXL mailbox. # # @path: CXL type 3 device canonical QOM path # # @start: Start address - must be 64 byte aligned. # # @length: Length of poison to inject - must be a multiple of 64 # bytes. # # Since: 8.1 ## to blend in with recent commit a937b6aa739 (qapi: Reformat doc comments to conform to current conventions). The blank lines help with catching certain errors. rST loves to surprise... > +{ 'command': 'cxl-inject-poison', > + 'data': { 'path': 'str', 'start': 'uint64', 'length': 'uint64' }} > + Make this 'length': 'size'. Just to signal intent; it generates the same code. > ## > # @CxlUncorErrorType: > # With that Acked-by: Markus Armbruster