From: Kalle Valo <kvalo@kernel.org>
To: "Toke Høiland-Jørgensen" <toke@toke.dk>
Cc: Simon Horman <simon.horman@corigine.com>,
Peter Seiderer <ps.report@gmx.net>,
linux-wireless@vger.kernel.org,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Gregg Wonderly <greggwonderly@seqtechllc.com>
Subject: Re: [PATCH v1] wifi: ath9k: fix AR9003 mac hardware hang check register offset calculation
Date: Tue, 25 Apr 2023 08:50:08 +0300 [thread overview]
Message-ID: <87a5ywqzn3.fsf@kernel.org> (raw)
In-Reply-To: <87bkjgmd9g.fsf@toke.dk> ("Toke \=\?utf-8\?Q\?H\=C3\=B8iland-J\?\= \=\?utf-8\?Q\?\=C3\=B8rgensen\=22's\?\= message of "Sat, 22 Apr 2023 12:18:03 +0200")
Toke Høiland-Jørgensen <toke@toke.dk> writes:
> Simon Horman <simon.horman@corigine.com> writes:
>
>>> - for (i = 0; i < NUM_STATUS_READS; i++) {
>>> - if (queue < 6)
>>> - dma_dbg_chain = REG_READ(ah, AR_DMADBG_4);
>>> - else
>>> - dma_dbg_chain = REG_READ(ah, AR_DMADBG_5);
>>> + if (queue < 6) {
>>> + dbg_reg = AR_DMADBG_4;
>>> + reg_offset = i * 5;
>>
>> Hi Peter,
>>
>> unless my eyes are deceiving me, i is not initialised here.
>
> Nice catch! Hmm, I wonder why my test compile didn't complain about
> that? Or maybe it did and I overlooked it? Anyway, Kalle, I already
> delegated this patch to you in patchwork, so please drop it
Ok, will drop.
> and I'll try to do better on reviewing the next one :)
No worries, reviewing is hard and things always slip past. But great
that we now have more people reviewing, thanks Simon for catching this.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2023-04-25 5:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-20 20:43 [PATCH v1] wifi: ath9k: fix AR9003 mac hardware hang check register offset calculation Peter Seiderer
2023-04-20 22:17 ` Toke Høiland-Jørgensen
2023-04-22 8:50 ` Simon Horman
2023-04-22 9:42 ` Peter Seiderer
2023-04-22 10:18 ` Toke Høiland-Jørgensen
2023-04-22 13:22 ` Peter Seiderer
2023-04-22 13:33 ` Toke Høiland-Jørgensen
2023-04-25 5:50 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a5ywqzn3.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=greggwonderly@seqtechllc.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=ps.report@gmx.net \
--cc=simon.horman@corigine.com \
--cc=toke@toke.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.