From: Fabiano Rosas <farosas@suse.de>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Cc: qemu-arm@nongnu.org, "Peter Maydell" <peter.maydell@linaro.org>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Claudio Fontana" <cfontana@suse.de>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Alexander Graf" <agraf@csgraf.de>,
"Cornelia Huck" <cohuck@redhat.com>
Subject: Re: [PATCH v8 03/11] target/arm: Move aa32_max_features out of cpu_tcg.c
Date: Fri, 10 Mar 2023 10:28:49 -0300 [thread overview]
Message-ID: <87a60kenvy.fsf@suse.de> (raw)
In-Reply-To: <3f660759-b37a-6b9e-3eaa-1f879db5ed48@linaro.org>
Richard Henderson <richard.henderson@linaro.org> writes:
> On 3/9/23 12:14, Fabiano Rosas wrote:
>> In preparation to moving the cpu_tcg.c code into a 32-bit, tcg-only
>> file, move the aa32_max_features function which is shared between
>> 32/64/tcg/non-tcg into cpu.c.
>>
>> Signed-off-by: Fabiano Rosas <farosas@suse.de>
>> ---
>> target/arm/cpu.c | 69 ++++++++++++++++++++++++++++++++++++++++++++
>> target/arm/cpu_tcg.c | 69 --------------------------------------------
>> 2 files changed, 69 insertions(+), 69 deletions(-)
>
> I'm not keen on this, as it's completely tcg.
>
> Perhaps it would be better to let -cpu max devolve to aarch64_a57_initfn when tcg is not
> available (i.e. qtest_enabled())? Move all of the tcg stuff out of aarch64_max_initfn
> into tcg/cpu64.c.
>
> Thoughts?
>
That's what I had in v6. I would prefer it that way as well. Perhaps I
was too quick in changing it.
https://lore.kernel.org/all/20230217201150.22032-20-farosas@suse.de/
Unless anyone says otherwise, I'll revert back to that state.
next prev parent reply other threads:[~2023-03-10 13:28 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-09 20:14 [PATCH v8 00/11] target/arm: Allow CONFIG_TCG=n builds Fabiano Rosas
2023-03-09 20:14 ` [PATCH v8 01/11] target/arm: Move cortex sysregs into a separate file Fabiano Rosas
2023-03-09 20:14 ` [PATCH v8 02/11] target/arm: Move 64-bit TCG CPUs into tcg/ Fabiano Rosas
2023-03-09 20:14 ` [PATCH v8 03/11] target/arm: Move aa32_max_features out of cpu_tcg.c Fabiano Rosas
2023-03-09 21:08 ` Richard Henderson
2023-03-10 13:28 ` Fabiano Rosas [this message]
2023-03-09 20:14 ` [PATCH v8 04/11] target/arm: move cpu_tcg to tcg/cpu32.c Fabiano Rosas
2023-03-09 20:14 ` [PATCH v8 05/11] arm/Kconfig: Always select SEMIHOSTING when TCG is present Fabiano Rosas
2023-03-09 20:14 ` [PATCH v8 06/11] arm/Kconfig: Do not build TCG-only boards on a KVM-only build Fabiano Rosas
2023-03-09 20:14 ` [PATCH v8 07/11] gitlab-ci: Check building KVM-only aarch64 target Fabiano Rosas
2023-03-09 20:14 ` [PATCH v8 08/11] tests/qtest: Fix tests when no KVM or TCG are present Fabiano Rosas
2023-03-10 10:08 ` Michael S. Tsirkin
2023-03-10 13:06 ` Fabiano Rosas
2023-03-10 15:17 ` Thomas Huth
2023-03-10 15:37 ` Fabiano Rosas
2023-03-10 16:14 ` Thomas Huth
2023-03-10 17:05 ` Fabiano Rosas
2023-03-10 10:13 ` Michael S. Tsirkin
2023-03-10 13:23 ` Fabiano Rosas
2023-03-11 19:28 ` Michael S. Tsirkin
2023-03-09 20:14 ` [PATCH v8 09/11] tests/avocado: Pass parameters to migration test Fabiano Rosas
2023-03-13 8:55 ` Philippe Mathieu-Daudé
2023-03-09 20:14 ` [PATCH v8 10/11] target/arm: gdbstub: Guard M-profile code with CONFIG_TCG Fabiano Rosas
2023-03-09 20:41 ` Richard Henderson
2023-03-13 8:58 ` Philippe Mathieu-Daudé
2023-03-09 20:14 ` [PATCH v8 11/11] target/arm: gdbstub: Guard pauth " Fabiano Rosas
2023-03-09 20:44 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a60kenvy.fsf@suse.de \
--to=farosas@suse.de \
--cc=agraf@csgraf.de \
--cc=alex.bennee@linaro.org \
--cc=cfontana@suse.de \
--cc=cohuck@redhat.com \
--cc=ehabkost@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.