From: Markus Armbruster <armbru@redhat.com>
To: Juan Quintela <quintela@redhat.com>
Cc: qemu-devel@nongnu.org, "Eduardo Habkost" <eduardo@habkost.net>,
"Yanan Wang" <wangyanan55@huawei.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Eric Blake" <eblake@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: Re: [PATCH v4 3/4] multifd: Only sync once each full round of memory
Date: Fri, 10 Feb 2023 07:29:32 +0100 [thread overview]
Message-ID: <87a61mxcc3.fsf@pond.sub.org> (raw)
In-Reply-To: <20230209233730.38288-4-quintela@redhat.com> (Juan Quintela's message of "Fri, 10 Feb 2023 00:37:29 +0100")
Juan Quintela <quintela@redhat.com> writes:
> We need to add a new flag to mean to sync at that point.
> Notice that we still synchronize at the end of setup and at the end of
> complete stages.
>
> Signed-off-by: Juan Quintela <quintela@redhat.com>
>
> ---
>
> Add missing qemu_fflush(), now it passes all tests always.
> ---
[...]
> diff --git a/migration/migration.c b/migration/migration.c
> index b2844d374f..9eb061319d 100644
> --- a/migration/migration.c
> +++ b/migration/migration.c
> @@ -2710,8 +2710,6 @@ bool migrate_multifd_sync_after_each_section(void)
> {
> MigrationState *s = migrate_get_current();
>
> - return true;
> - // We will change this when code gets in.
> return s->enabled_capabilities[MIGRATION_CAPABILITY_MULTIFD_SYNC_AFTER_EACH_SECTION];
> }
Ah, nevermind.
[...]
next prev parent reply other threads:[~2023-02-10 6:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-09 23:37 [PATCH v4 0/4] Eliminate multifd flush Juan Quintela
2023-02-09 23:37 ` [PATCH v4 1/4] multifd: Create property multifd-sync-after-each-section Juan Quintela
2023-02-10 6:28 ` Markus Armbruster
2023-02-09 23:37 ` [PATCH v4 2/4] multifd: Protect multifd_send_sync_main() calls Juan Quintela
2023-02-09 23:37 ` [PATCH v4 3/4] multifd: Only sync once each full round of memory Juan Quintela
2023-02-10 6:29 ` Markus Armbruster [this message]
2023-02-09 23:37 ` [PATCH v4 4/4] ram: Document migration ram flags Juan Quintela
2023-02-10 20:56 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a61mxcc3.fsf@pond.sub.org \
--to=armbru@redhat.com \
--cc=dgilbert@redhat.com \
--cc=eblake@redhat.com \
--cc=eduardo@habkost.net \
--cc=marcel.apfelbaum@gmail.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=wangyanan55@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.