From: Vlad Buslov <vladbu@nvidia.com>
To: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Cc: <davem@davemloft.net>, <kuba@kernel.org>, <pabeni@redhat.com>,
<pablo@netfilter.org>, <netdev@vger.kernel.org>,
<netfilter-devel@vger.kernel.org>, <jhs@mojatatu.com>,
<xiyou.wangcong@gmail.com>, <jiri@resnulli.us>, <ozsh@nvidia.com>,
<simon.horman@corigine.com>
Subject: Re: [PATCH net-next v2 3/7] netfilter: flowtable: allow unidirectional rules
Date: Tue, 17 Jan 2023 19:31:45 +0200 [thread overview]
Message-ID: <87a62hcbjm.fsf@nvidia.com> (raw)
In-Reply-To: <Y8a7f2AXVMx8WWPc@t14s.localdomain>
On Tue 17 Jan 2023 at 12:15, Marcelo Ricardo Leitner <marcelo.leitner@gmail.com> wrote:
> On Fri, Jan 13, 2023 at 05:55:44PM +0100, Vlad Buslov wrote:
>> Modify flow table offload to support unidirectional connections by
>> extending enum nf_flow_flags with new "NF_FLOW_HW_BIDIRECTIONAL" flag. Only
>> offload reply direction when the flag is not set. This infrastructure
> ^^^ s///, I believe? :-)
Good catch!
>
> ...
>> - ok_count += flow_offload_tuple_add(offload, flow_rule[1],
>> - FLOW_OFFLOAD_DIR_REPLY);
>> + if (test_bit(NF_FLOW_HW_BIDIRECTIONAL, &offload->flow->flags))
>> + ok_count += flow_offload_tuple_add(offload, flow_rule[1],
>> + FLOW_OFFLOAD_DIR_REPLY);
>> if (ok_count == 0)
next prev parent reply other threads:[~2023-01-17 17:37 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-13 16:55 [PATCH net-next v2 0/7] Allow offloading of UDP NEW connections via act_ct Vlad Buslov
2023-01-13 16:55 ` [PATCH net-next v2 1/7] net: flow_offload: provision conntrack info in ct_metadata Vlad Buslov
2023-01-17 14:42 ` Pablo Neira Ayuso
2023-01-17 17:43 ` Vlad Buslov
2023-01-17 15:04 ` Marcelo Ricardo Leitner
2023-01-17 15:09 ` Marcelo Ricardo Leitner
2023-01-17 17:28 ` Vlad Buslov
2023-01-19 4:15 ` Marcelo Ricardo Leitner
2023-01-17 17:25 ` Vlad Buslov
2023-01-13 16:55 ` [PATCH net-next v2 2/7] netfilter: flowtable: fixup UDP timeout depending on ct state Vlad Buslov
2023-01-13 16:55 ` [PATCH net-next v2 3/7] netfilter: flowtable: allow unidirectional rules Vlad Buslov
2023-01-17 15:15 ` Marcelo Ricardo Leitner
2023-01-17 17:31 ` Vlad Buslov [this message]
2023-01-13 16:55 ` [PATCH net-next v2 4/7] netfilter: flowtable: allow updating offloaded rules asynchronously Vlad Buslov
2023-01-17 15:28 ` Marcelo Ricardo Leitner
2023-01-17 17:33 ` Vlad Buslov
2023-01-17 17:47 ` Marcelo Ricardo Leitner
2023-01-13 16:55 ` [PATCH net-next v2 5/7] net/sched: act_ct: set ctinfo in meta action depending on ct state Vlad Buslov
2023-01-13 16:55 ` [PATCH net-next v2 6/7] net/sched: act_ct: offload UDP NEW connections Vlad Buslov
2023-01-17 15:41 ` Marcelo Ricardo Leitner
2023-01-17 17:36 ` Vlad Buslov
2023-01-17 17:56 ` Marcelo Ricardo Leitner
2023-01-17 19:12 ` Vlad Buslov
2023-01-19 4:18 ` Marcelo Ricardo Leitner
2023-01-13 16:55 ` [PATCH net-next v2 7/7] netfilter: nf_conntrack: allow early drop of offloaded UDP conns Vlad Buslov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a62hcbjm.fsf@nvidia.com \
--to=vladbu@nvidia.com \
--cc=davem@davemloft.net \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=marcelo.leitner@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=ozsh@nvidia.com \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
--cc=simon.horman@corigine.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.