From: "Alex Bennée" <alex.bennee@linaro.org>
To: Evgeny Iakovlev <eiakovlev@linux.microsoft.com>
Cc: qemu-devel@nongnu.org, bmeng.cn@gmail.com, philmd@linaro.org
Subject: Re: [PATCH v2] semihosting: add O_BINARY flag in host_open for NT compatibility
Date: Fri, 06 Jan 2023 13:51:18 +0000 [thread overview]
Message-ID: <87a62vpy8z.fsf@linaro.org> (raw)
In-Reply-To: <20230106102018.20520-1-eiakovlev@linux.microsoft.com>
Evgeny Iakovlev <eiakovlev@linux.microsoft.com> writes:
> Windows open(2) implementation opens files in text mode by default and
> needs a Windows-only O_BINARY flag to open files as binary. QEMU already
> knows about that flag in osdep and it is defined to 0 on non-Windows,
> so we can just add it to the host_flags for better compatibility.
>
> Signed-off-by: Evgeny Iakovlev <eiakovlev@linux.microsoft.com>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
Queued to semihosting/next, thanks.
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
next prev parent reply other threads:[~2023-01-06 13:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-06 10:20 [PATCH v2] semihosting: add O_BINARY flag in host_open for NT compatibility Evgeny Iakovlev
2023-01-06 13:51 ` Alex Bennée [this message]
2023-01-06 14:13 ` Peter Maydell
2023-01-06 15:33 ` Alex Bennée
2023-01-06 16:28 ` Peter Maydell
2023-01-06 18:22 ` Evgeny Iakovlev
2023-01-06 18:58 ` Peter Maydell
2023-01-16 15:56 ` eiakovlev
2023-01-16 16:25 ` Alex Bennée
2023-01-16 16:39 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a62vpy8z.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=bmeng.cn@gmail.com \
--cc=eiakovlev@linux.microsoft.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.