Re: [igt-dev] [PATCH i-g-t] tools/intel_vbt_decode: decode VBT MIPI sequence v4 native flag

[Jani Nikula <jani.nikula@intel.com>]

On Tue, 29 Nov 2022, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> On Tue, Nov 29, 2022 at 10:47:10AM +0200, Jani Nikula wrote:
>> MIPI sequence v4 has a flag for native/non-native GPIO.
>
> An naturally zero docs on what it actually means. But looks like
> we're just meant to poke various DE registers for the "native" case.

Yeah.

Related to [1] and [2], where I'm trying to poke said registers, with
varying success.

BR,
Jani.


[1] https://gitlab.freedesktop.org/drm/intel/-/issues/6131
[2] https://cgit.freedesktop.org/~jani/drm/log/?h=dsi-gpio

>
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
>> 
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>> ---
>>  tools/intel_vbt_decode.c | 8 ++++++--
>>  1 file changed, 6 insertions(+), 2 deletions(-)
>> 
>> diff --git a/tools/intel_vbt_decode.c b/tools/intel_vbt_decode.c
>> index a63bfdda142a..94a910b5c107 100644
>> --- a/tools/intel_vbt_decode.c
>> +++ b/tools/intel_vbt_decode.c
>> @@ -2049,8 +2049,12 @@ static const uint8_t *mipi_dump_gpio(const uint8_t *data, uint8_t seq_version)
>>  		number = *data++;
>>  		flags = *data++;
>>  
>> -		printf("\t\t\tGPIO index %u, number %u, set %d (0x%02x)\n",
>> -		       index, number, flags & 1, flags);
>> +		if (seq_version >= 4)
>> +			printf("\t\t\tGPIO index %u, number %u, native %d, set %d (0x%02x)\n",
>> +			       index, number, !(flags & 2), flags & 1, flags);
>> +		else
>> +			printf("\t\t\tGPIO index %u, number %u, set %d (0x%02x)\n",
>> +			       index, number, flags & 1, flags);
>>  	} else {
>>  		index = *data++;
>>  		flags = *data++;
>> -- 
>> 2.34.1

-- 
Jani Nikula, Intel Open Source Graphics Center