From: Thomas Gleixner <tglx@linutronix.de>
To: Dan Carpenter <error27@gmail.com>,
oe-kbuild@lists.linux.dev,
"Ahmed S. Darwish" <darwi@linutronix.de>
Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev,
Ammar Faizi <ammarfaizi2@gnuweeb.org>,
GNU/Weeb Mailing List <gwml@vger.gnuweeb.org>
Subject: Re: [ammarfaizi2-block:tglx/devel/devmsi 46/86] kernel/irq/msi.c:399 msi_domain_get_virq() warn: inconsistent returns '&dev->msi.data->mutex'.
Date: Sat, 12 Nov 2022 18:41:06 +0100 [thread overview]
Message-ID: <87a64wcbpp.ffs@tglx> (raw)
In-Reply-To: <202211070346.0vaondmd-lkp@intel.com>
On Mon, Nov 07 2022 at 15:39, Dan Carpenter wrote:
> smatch warnings:
> kernel/irq/msi.c:399 msi_domain_get_virq() warn: inconsistent returns '&dev->msi.data->mutex'.
>
> vim +399 kernel/irq/msi.c
>
> 495c66aca3da70 Thomas Gleixner 2021-12-06 378 msi_lock_descs(dev);
> 022573e1aaf074 Ahmed S. Darwish 2022-11-03 379
> 022573e1aaf074 Ahmed S. Darwish 2022-11-03 380 base = msi_get_domain_base_index(dev, domid);
> 022573e1aaf074 Ahmed S. Darwish 2022-11-03 381 if (base < 0)
> 022573e1aaf074 Ahmed S. Darwish 2022-11-03 382 return 0;
>
> msi_unlock_descs();?
Indeed.
prev parent reply other threads:[~2022-11-12 17:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-06 19:28 [ammarfaizi2-block:tglx/devel/devmsi 46/86] kernel/irq/msi.c:399 msi_domain_get_virq() warn: inconsistent returns '&dev->msi.data->mutex' kernel test robot
2022-11-07 12:39 ` Dan Carpenter
2022-11-12 17:41 ` Thomas Gleixner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a64wcbpp.ffs@tglx \
--to=tglx@linutronix.de \
--cc=ammarfaizi2@gnuweeb.org \
--cc=darwi@linutronix.de \
--cc=error27@gmail.com \
--cc=gwml@vger.gnuweeb.org \
--cc=lkp@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=oe-kbuild@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.