All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: "Víctor Colombo" <victor.colombo@eldorado.org.br>,
	qemu-devel@nongnu.org, qemu-ppc@nongnu.org, clg@kaod.org,
	danielhb413@gmail.com, david@gibson.dropbear.id.au,
	groug@kaod.org, aurelien@aurel32.net, peter.maydell@linaro.org,
	balaton@eik.bme.hu, matheus.ferst@eldorado.org.br,
	lucas.araujo@eldorado.org.br, leandro.lupori@eldorado.org.br,
	lucas.coutinho@eldorado.org.br
Subject: Re: [RFC PATCH 0/4] Idea for using hardfloat in PPC
Date: Fri, 07 Oct 2022 14:42:55 +0100	[thread overview]
Message-ID: <87a667iw84.fsf@linaro.org> (raw)
In-Reply-To: <f78ab23d-6cab-9b60-37c4-7486546c6a0e@linaro.org>


Richard Henderson <richard.henderson@linaro.org> writes:

> On 10/5/22 07:37, Víctor Colombo wrote:
>> However, the impact in performance was not the expected. In x86_64 I
>> had a small 3% improvement, while in a Power9 machine there was a small
>> performance loss, as can be seem below (100 executions).
>> |        | min [s] | max [s] | avg [s] |
>> | before | 122.309 | 123.459 | 122.747 |
>> | after  | 123.906 | 125.016 | 124.373 |
>
> I hope this is because you didn't handle the most common cases: add, sub, mul, div.
>
> The logic seems plausible, as far as it goes, and would work for the
> FR bit as well which afair isn't handled at all at the moment.  I'll
> review properly in a little while.

I wonder if this is something that could be generalised and pushed up
into the fpu stuff itself. We could after all cache the op and
decomposed parameters here in a generic way. The trick would be working
out how to do that without slowing down the current common case.

Is ppc unique in not persisting the inexact flag from previous
operations?

>
>
> r~


-- 
Alex Bennée


  reply	other threads:[~2022-10-07 15:27 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-05 14:37 [RFC PATCH 0/4] Idea for using hardfloat in PPC Víctor Colombo
2022-10-05 14:37 ` [RFC PATCH 1/4] target/ppc: prepare instructions to work with caching last FP insn Víctor Colombo
2022-10-05 14:37 ` [RFC PATCH 2/4] target/ppc: Implement instruction caching for fsqrt Víctor Colombo
2022-10-05 14:37 ` [RFC PATCH 3/4] target/ppc: Implement instruction caching for muladd Víctor Colombo
2022-10-05 14:37 ` [RFC PATCH 4/4] target/ppc: Enable hardfpu for Power Víctor Colombo
2022-10-05 20:37 ` [RFC PATCH 0/4] Idea for using hardfloat in PPC Richard Henderson
2022-10-07 13:42   ` Alex Bennée [this message]
2022-10-07 15:06     ` Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a667iw84.fsf@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=aurelien@aurel32.net \
    --cc=balaton@eik.bme.hu \
    --cc=clg@kaod.org \
    --cc=danielhb413@gmail.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=groug@kaod.org \
    --cc=leandro.lupori@eldorado.org.br \
    --cc=lucas.araujo@eldorado.org.br \
    --cc=lucas.coutinho@eldorado.org.br \
    --cc=matheus.ferst@eldorado.org.br \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=victor.colombo@eldorado.org.br \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.