From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B25D3C38145 for ; Fri, 2 Sep 2022 14:17:11 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BECE110E846; Fri, 2 Sep 2022 14:17:10 +0000 (UTC) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id A9B5210E846 for ; Fri, 2 Sep 2022 14:17:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1662128223; x=1693664223; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=1piibPXngaghAUzc44z5EzDqyHK+Yze7lCUvqNWnXew=; b=dUnU7lIiX0P2hXeNi0IaNq6+xqO5LCEnxvEcfWTAvaUmE1am44O/ofuD ii3/vZgk7bVeXsittwbOZl/J5M3fKaZXr6bg6BFfQ6KU0dYM3c1Exd8s1 uCI1UiSijQtwv2JABi5gB+8eubf4H+Hhwr8FJ0If9SRXQ95w4L0CPmgfL He3knujzrpb28Qcm5XN+cCVNhqFtMNyMuruADG9MI2Rz1B6ihxtaR6tD8 bz2RRcF5jOoZVXHZ3AR+syNkYaGgWEm2GnrZsjNjXZrccKc5dwaNDXTRS 6peI8EQoS3nL5g34UGAh0vVNf0LTrRt2iXnmAFi6+rod4+495tb+kXGl/ g==; X-IronPort-AV: E=McAfee;i="6500,9779,10457"; a="295995976" X-IronPort-AV: E=Sophos;i="5.93,283,1654585200"; d="scan'208";a="295995976" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Sep 2022 07:17:03 -0700 X-IronPort-AV: E=Sophos;i="5.93,283,1654585200"; d="scan'208";a="674368594" Received: from runshen1-mobl1.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.212.175.236]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Sep 2022 07:17:02 -0700 Date: Fri, 02 Sep 2022 07:16:48 -0700 Message-ID: <87a67hoo8f.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Rodrigo Vivi In-Reply-To: <20220902095126.373036-2-rodrigo.vivi@intel.com> References: <20220902095126.373036-1-rodrigo.vivi@intel.com> <20220902095126.373036-2-rodrigo.vivi@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Subject: Re: [Intel-gfx] [PATCH 2/2] drm/i915: Let's avoid even early init if SLPC is used. X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Fri, 02 Sep 2022 02:51:26 -0700, Rodrigo Vivi wrote: > > diff --git a/drivers/gpu/drm/i915/gt/intel_rps.c b/drivers/gpu/drm/i915/gt/intel_rps.c > index 6fadde4ee7bf..c29652281f2e 100644 > --- a/drivers/gpu/drm/i915/gt/intel_rps.c > +++ b/drivers/gpu/drm/i915/gt/intel_rps.c > @@ -1960,6 +1960,9 @@ void gen5_rps_irq_handler(struct intel_rps *rps) > > void intel_rps_init_early(struct intel_rps *rps) > { > + if (rps_uses_slpc(rps)) > + return; > + Hi Rodrigo, Let me double check with you, this works correctly at this place, correct? Looks like things to make this work should get initialized in intel_uc_init_early() which is called just before intel_rps_init_early() so looks ok (can't tell for sure with all those uc macros :/): Reviewed-by: Ashutosh Dixit > mutex_init(&rps->lock); > mutex_init(&rps->power.mutex); > > -- > 2.37.2 >