From: Philippe Gerum <rpm@xenomai.org>
To: Jussi Viiri <ilmai@iki.fi>
Cc: xenomai@lists.linux.dev
Subject: Re: [PATCH] revl: Add empty Send + Sync implementations for Event
Date: Wed, 24 Aug 2022 12:12:35 +0200 [thread overview]
Message-ID: <87a67tgc1i.fsf@xenomai.org> (raw)
In-Reply-To: <0990af90-25f5-fdb7-8438-3d65d7dfe528@iki.fi>
Jussi Viiri <ilmai@iki.fi> writes:
> Event wasn't safe to send across threads. Fixed.
>
> ---
>
> From 0782e7d6c5f9189fe85f8f340721e1bcec3d16b2 Mon Sep 17 00:00:00 2001
> From: Jussi Viiri <ilmai@iki.fi>
> Date: Tue, 23 Aug 2022 22:49:01 +0300
> Subject: [PATCH 3/3] Add empty Send + Sync implementations for Event
>
> ---
> src/event.rs | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/src/event.rs b/src/event.rs
> index 7fdfd23..f469c43 100644
> --- a/src/event.rs
> +++ b/src/event.rs
> @@ -76,6 +76,9 @@ impl WaitTimeoutResult {
>
> pub struct Event(UnsafeCell<evl_event>);
>
> +unsafe impl Send for Event {}
> +unsafe impl Sync for Event {}
> +
> impl Event {
> pub fn new(builder: Builder) -> Result<Self, Error> {
> let this = Self(UnsafeCell::new(unsafe {
LGTM. We enforce the developer's certificate of origin as defined by the
linux kernel project, please send all patches with a Signed-off-by line
(resending this one as well).
Thanks,
--
Philippe.
next prev parent reply other threads:[~2022-08-24 10:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-23 19:57 [PATCH] revl: Add empty Send + Sync implementations for Event Jussi Viiri
2022-08-24 10:12 ` Philippe Gerum [this message]
[not found] ` <cacc03cf-7bf6-2e48-caf1-63bbdd40b2aa@iki.fi>
2022-08-26 7:55 ` Jussi Viiri
2022-08-26 8:21 ` Philippe Gerum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a67tgc1i.fsf@xenomai.org \
--to=rpm@xenomai.org \
--cc=ilmai@iki.fi \
--cc=xenomai@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.