From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by smtp.lore.kernel.org (Postfix) with ESMTP id AEB8CC433EF for ; Tue, 26 Jul 2022 10:00:31 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 224914C49B; Tue, 26 Jul 2022 06:00:31 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@kernel.org Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id mSDCf6tD1JMJ; Tue, 26 Jul 2022 06:00:29 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id A83D74C499; Tue, 26 Jul 2022 06:00:29 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 374C14C499 for ; Tue, 26 Jul 2022 06:00:28 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id WT2Je+x9ZhzF for ; Tue, 26 Jul 2022 06:00:27 -0400 (EDT) Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id DCD9C4C495 for ; Tue, 26 Jul 2022 06:00:26 -0400 (EDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 630C2B811C7; Tue, 26 Jul 2022 10:00:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1B096C341C0; Tue, 26 Jul 2022 10:00:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1658829624; bh=lVR454/l8b9nh35sqhdWBxPKaE+Kv5ClI+XinX72svY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=GOf5SmE4BZFpHTm6PQb6Aome4X/MvjdlYbEAgGBqFm8lJuEAn8958GavDeHoF9MXA +fXbhsWjZ+gSsNaICj/kPuMWScev/6w7EKtRhdQ505jGW1m5rEllHBZ9ybkWIjoOz1 c3q4cm40QlIHR14ra9jRa/Owk1cJITYS4Qz1hMJgxJUQPW//xBF5oOl1J67hhjy0Tp wUt2/Ir96FOPEfWyJtXs1ls5GZMRgm4NLphkT4dhP2NOrzFYpguUwTTyrU0JvyAc5p e/CtU5IXiibo9ZdPw3xVAyJIL4riB8DbdQSpUGYv14iqQsoYDgksj26a6yBV1mXD+5 44B3X9gmdl7xA== Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1oGHMT-00A3QI-Nn; Tue, 26 Jul 2022 11:00:21 +0100 Date: Tue, 26 Jul 2022 11:00:21 +0100 Message-ID: <87a68wxkga.wl-maz@kernel.org> From: Marc Zyngier To: Kalesh Singh Subject: Re: [PATCH v6 12/17] KVM: arm64: Add PROTECTED_NVHE_STACKTRACE Kconfig In-Reply-To: <20220726073750.3219117-13-kaleshsingh@google.com> References: <20220726073750.3219117-1-kaleshsingh@google.com> <20220726073750.3219117-13-kaleshsingh@google.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: kaleshsingh@google.com, mark.rutland@arm.com, broonie@kernel.org, madvenka@linux.microsoft.com, tabba@google.com, oliver.upton@linux.dev, will@kernel.org, qperret@google.com, james.morse@arm.com, alexandru.elisei@arm.com, suzuki.poulose@arm.com, catalin.marinas@arm.com, andreyknvl@gmail.com, vincenzo.frascino@arm.com, mhiramat@kernel.org, ast@kernel.org, wangkefeng.wang@huawei.com, elver@google.com, keirf@google.com, yuzenghui@huawei.com, ardb@kernel.org, oupton@google.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, android-mm@google.com, kernel-team@android.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Cc: wangkefeng.wang@huawei.com, catalin.marinas@arm.com, ast@kernel.org, vincenzo.frascino@arm.com, will@kernel.org, android-mm@google.com, kvmarm@lists.cs.columbia.edu, madvenka@linux.microsoft.com, kernel-team@android.com, elver@google.com, broonie@kernel.org, linux-arm-kernel@lists.infradead.org, andreyknvl@gmail.com, linux-kernel@vger.kernel.org, mhiramat@kernel.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu T24gVHVlLCAyNiBKdWwgMjAyMiAwODozNzo0NSArMDEwMCwKS2FsZXNoIFNpbmdoIDxrYWxlc2hz aW5naEBnb29nbGUuY29tPiB3cm90ZToKPiAKPiBUaGlzIGNhbiBiZSB1c2VkIHRvIGRpc2FibGUg c3RhY2t0cmFjZSBmb3IgdGhlIHByb3RlY3RlZCBLVk0KPiBuVkhFIGh5cGVydmlzb3IsIGluIG9y ZGVyIHRvIHNhdmUgb24gdGhlIGFzc29jaWF0ZWQgbWVtb3J5IHVzYWdlLgo+IAo+IFRoaXMgb3B0 aW9uIGlzIGRpc2FibGVkIGJ5IGRlZmF1bHQsIHNpbmNlIHByb3RlY3RlZCBLVk0gaXMgbm90IHdp ZGVseQo+IHVzZWQgb24gcGxhdGZvcm1zIG90aGVyIHRoYW4gQW5kcm9pZCBjdXJyZW50bHkuCj4g Cj4gU2lnbmVkLW9mZi1ieTogS2FsZXNoIFNpbmdoIDxrYWxlc2hzaW5naEBnb29nbGUuY29tPgo+ IFJldmlld2VkLWJ5OiBGdWFkIFRhYmJhIDx0YWJiYUBnb29nbGUuY29tPgo+IFRlc3RlZC1ieTog RnVhZCBUYWJiYSA8dGFiYmFAZ29vZ2xlLmNvbT4KPiAtLS0KPiAKPiBDaGFuZ2VzIGluIHY2Ogo+ ICAgLSBBZGQgRnVhZOKAmXMgUmV2aWV3ZWQtYnkgYW5kIFRlc3RlZC1ieSB0YWdzCj4gCj4gQ2hh bmdlcyBpbiB2NToKPiAgIC0gTWFrZSBQUk9URUNURURfTlZIRV9TVEFDS1RSQUNFIGRlcGVuZCBv biBOVkhFX0VMMl9ERUJVRywgcGVyIE1hcmMKPiAKPiAgYXJjaC9hcm02NC9rdm0vS2NvbmZpZyB8 IDE1ICsrKysrKysrKysrKysrKwo+ICAxIGZpbGUgY2hhbmdlZCwgMTUgaW5zZXJ0aW9ucygrKQo+ IAo+IGRpZmYgLS1naXQgYS9hcmNoL2FybTY0L2t2bS9LY29uZmlnIGIvYXJjaC9hcm02NC9rdm0v S2NvbmZpZwo+IGluZGV4IDhhNWZiYmYwODRkZi4uMDljOTk1ODY5OTE2IDEwMDY0NAo+IC0tLSBh L2FyY2gvYXJtNjQva3ZtL0tjb25maWcKPiArKysgYi9hcmNoL2FybTY0L2t2bS9LY29uZmlnCj4g QEAgLTQ2LDYgKzQ2LDIxIEBAIG1lbnVjb25maWcgS1ZNCj4gIAo+ICAJICBJZiB1bnN1cmUsIHNh eSBOLgo+ICAKPiArY29uZmlnIFBST1RFQ1RFRF9OVkhFX1NUQUNLVFJBQ0UKPiArCWJvb2wgIlBy b3RlY3RlZCBLVk0gaHlwZXJ2aXNvciBzdGFja3RyYWNlcyIKPiArCWRlcGVuZHMgb24gTlZIRV9F TDJfREVCVUcKPiArCWRlZmF1bHQgbgo+ICsJaGVscAo+ICsJICBTYXkgWSBoZXJlIHRvIGVuYWJs ZSBwS1ZNIGh5cGVydmlzb3Igc3RhY2t0cmFjZXMgb24gaHlwX3BhbmljKCkKPiArCj4gKwkgIElm IHlvdSBhcmUgbm90IHVzaW5nIHByb3RlY3RlZCBuVkhFIChwS1ZNKSwgc2F5IE4uCj4gKwo+ICsJ ICBJZiB1c2luZyBwcm90ZWN0ZWQgblZIRSBtb2RlLCBidXQgY2Fubm90IGFmZm9yZCB0aGUgYXNz b2NpYXRlZAo+ICsJICBtZW1vcnkgY29zdCAobGVzcyB0aGFuIDAuNzUgcGFnZSBwZXIgQ1BVKSBv ZiBwS1ZNIHN0YWNrdHJhY2VzLAo+ICsJICBzYXkgTi4KPiArCj4gKwkgIElmIHVuc3VyZSwgc2F5 IE4uCj4gKwo+ICBjb25maWcgTlZIRV9FTDJfREVCVUcKPiAgCWJvb2wgIkRlYnVnIG1vZGUgZm9y IG5vbi1WSEUgRUwyIG9iamVjdCIKPiAgCWRlcGVuZHMgb24gS1ZNCgpIYXZpbmcgTlZIRV9FTDJf REVCVUcgYWZ0ZXIgUFJPVEVDVEVEX05WSEVfU1RBQ0tUUkFDRSBpcyBwcmV0dHkgb2RkCndoZW4g eW91IHVzZSAnbWFrZSBtZW51Y29uZmlnJywgYXMgdGhlIG5ldyBvcHRpb24gYXBwZWFycyBvdXQg b2YKc2VxdWVuY2UuCgpJJ2xsIG1vdmUgaXQgYXJvdW5kLCBubyBuZWVkIHRvIHJlc3BpbiBmb3Ig dGhpcy4KClRoYW5rcywKCglNLgoKLS0gCldpdGhvdXQgZGV2aWF0aW9uIGZyb20gdGhlIG5vcm0s IHByb2dyZXNzIGlzIG5vdCBwb3NzaWJsZS4KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18Ka3ZtYXJtIG1haWxpbmcgbGlzdAprdm1hcm1AbGlzdHMuY3MuY29s dW1iaWEuZWR1Cmh0dHBzOi8vbGlzdHMuY3MuY29sdW1iaWEuZWR1L21haWxtYW4vbGlzdGluZm8v a3ZtYXJtCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BFEC7C433EF for ; Tue, 26 Jul 2022 10:02:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3fzrIgMrPjKLsH+J5fkvrOScN1UtDM3XsIFenAjseXc=; b=l3xbUHSIOt+8SU 93nHEQ7rHp57bCeWyCgfVkXIzKhmpXEZz/85rt9S+8aaLONHMyhR5NPXCj7O/K6AP1Kjs123w63Md sx56JA7QXrB9IAqNFu2CPvZRp4UYGGeA7jhzfc3n80f4uNFmL13a4eiYbu1lSCSP8WpDSPRxe65of nfmdS+/Y87OlZeDHqY2s5EMk25CTXXYWD56Df4wrcUPU0JSueYWTmNUbpZY1z63bmrKFX0X8hY75/ 6mnlNZTeX+JP1gHme21hcztV4myCibyRjUENvTZwjiM+uv3yewaX0KKFisjuSAqufyH4Fu/59pyja ChFka57VLLr3ESnKVr9w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oGHMl-00C4S2-QS; Tue, 26 Jul 2022 10:00:40 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oGHMZ-00C4Do-DH for linux-arm-kernel@lists.infradead.org; Tue, 26 Jul 2022 10:00:29 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 630C2B811C7; Tue, 26 Jul 2022 10:00:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1B096C341C0; Tue, 26 Jul 2022 10:00:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1658829624; bh=lVR454/l8b9nh35sqhdWBxPKaE+Kv5ClI+XinX72svY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=GOf5SmE4BZFpHTm6PQb6Aome4X/MvjdlYbEAgGBqFm8lJuEAn8958GavDeHoF9MXA +fXbhsWjZ+gSsNaICj/kPuMWScev/6w7EKtRhdQ505jGW1m5rEllHBZ9ybkWIjoOz1 c3q4cm40QlIHR14ra9jRa/Owk1cJITYS4Qz1hMJgxJUQPW//xBF5oOl1J67hhjy0Tp wUt2/Ir96FOPEfWyJtXs1ls5GZMRgm4NLphkT4dhP2NOrzFYpguUwTTyrU0JvyAc5p e/CtU5IXiibo9ZdPw3xVAyJIL4riB8DbdQSpUGYv14iqQsoYDgksj26a6yBV1mXD+5 44B3X9gmdl7xA== Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1oGHMT-00A3QI-Nn; Tue, 26 Jul 2022 11:00:21 +0100 Date: Tue, 26 Jul 2022 11:00:21 +0100 Message-ID: <87a68wxkga.wl-maz@kernel.org> From: Marc Zyngier To: Kalesh Singh Cc: mark.rutland@arm.com, broonie@kernel.org, madvenka@linux.microsoft.com, tabba@google.com, oliver.upton@linux.dev, will@kernel.org, qperret@google.com, james.morse@arm.com, alexandru.elisei@arm.com, suzuki.poulose@arm.com, catalin.marinas@arm.com, andreyknvl@gmail.com, vincenzo.frascino@arm.com, mhiramat@kernel.org, ast@kernel.org, wangkefeng.wang@huawei.com, elver@google.com, keirf@google.com, yuzenghui@huawei.com, ardb@kernel.org, oupton@google.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, android-mm@google.com, kernel-team@android.com Subject: Re: [PATCH v6 12/17] KVM: arm64: Add PROTECTED_NVHE_STACKTRACE Kconfig In-Reply-To: <20220726073750.3219117-13-kaleshsingh@google.com> References: <20220726073750.3219117-1-kaleshsingh@google.com> <20220726073750.3219117-13-kaleshsingh@google.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: kaleshsingh@google.com, mark.rutland@arm.com, broonie@kernel.org, madvenka@linux.microsoft.com, tabba@google.com, oliver.upton@linux.dev, will@kernel.org, qperret@google.com, james.morse@arm.com, alexandru.elisei@arm.com, suzuki.poulose@arm.com, catalin.marinas@arm.com, andreyknvl@gmail.com, vincenzo.frascino@arm.com, mhiramat@kernel.org, ast@kernel.org, wangkefeng.wang@huawei.com, elver@google.com, keirf@google.com, yuzenghui@huawei.com, ardb@kernel.org, oupton@google.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, android-mm@google.com, kernel-team@android.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220726_030027_825465_AF0C5CBD X-CRM114-Status: GOOD ( 23.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlLCAyNiBKdWwgMjAyMiAwODozNzo0NSArMDEwMCwKS2FsZXNoIFNpbmdoIDxrYWxlc2hz aW5naEBnb29nbGUuY29tPiB3cm90ZToKPiAKPiBUaGlzIGNhbiBiZSB1c2VkIHRvIGRpc2FibGUg c3RhY2t0cmFjZSBmb3IgdGhlIHByb3RlY3RlZCBLVk0KPiBuVkhFIGh5cGVydmlzb3IsIGluIG9y ZGVyIHRvIHNhdmUgb24gdGhlIGFzc29jaWF0ZWQgbWVtb3J5IHVzYWdlLgo+IAo+IFRoaXMgb3B0 aW9uIGlzIGRpc2FibGVkIGJ5IGRlZmF1bHQsIHNpbmNlIHByb3RlY3RlZCBLVk0gaXMgbm90IHdp ZGVseQo+IHVzZWQgb24gcGxhdGZvcm1zIG90aGVyIHRoYW4gQW5kcm9pZCBjdXJyZW50bHkuCj4g Cj4gU2lnbmVkLW9mZi1ieTogS2FsZXNoIFNpbmdoIDxrYWxlc2hzaW5naEBnb29nbGUuY29tPgo+ IFJldmlld2VkLWJ5OiBGdWFkIFRhYmJhIDx0YWJiYUBnb29nbGUuY29tPgo+IFRlc3RlZC1ieTog RnVhZCBUYWJiYSA8dGFiYmFAZ29vZ2xlLmNvbT4KPiAtLS0KPiAKPiBDaGFuZ2VzIGluIHY2Ogo+ ICAgLSBBZGQgRnVhZOKAmXMgUmV2aWV3ZWQtYnkgYW5kIFRlc3RlZC1ieSB0YWdzCj4gCj4gQ2hh bmdlcyBpbiB2NToKPiAgIC0gTWFrZSBQUk9URUNURURfTlZIRV9TVEFDS1RSQUNFIGRlcGVuZCBv biBOVkhFX0VMMl9ERUJVRywgcGVyIE1hcmMKPiAKPiAgYXJjaC9hcm02NC9rdm0vS2NvbmZpZyB8 IDE1ICsrKysrKysrKysrKysrKwo+ICAxIGZpbGUgY2hhbmdlZCwgMTUgaW5zZXJ0aW9ucygrKQo+ IAo+IGRpZmYgLS1naXQgYS9hcmNoL2FybTY0L2t2bS9LY29uZmlnIGIvYXJjaC9hcm02NC9rdm0v S2NvbmZpZwo+IGluZGV4IDhhNWZiYmYwODRkZi4uMDljOTk1ODY5OTE2IDEwMDY0NAo+IC0tLSBh L2FyY2gvYXJtNjQva3ZtL0tjb25maWcKPiArKysgYi9hcmNoL2FybTY0L2t2bS9LY29uZmlnCj4g QEAgLTQ2LDYgKzQ2LDIxIEBAIG1lbnVjb25maWcgS1ZNCj4gIAo+ICAJICBJZiB1bnN1cmUsIHNh eSBOLgo+ICAKPiArY29uZmlnIFBST1RFQ1RFRF9OVkhFX1NUQUNLVFJBQ0UKPiArCWJvb2wgIlBy b3RlY3RlZCBLVk0gaHlwZXJ2aXNvciBzdGFja3RyYWNlcyIKPiArCWRlcGVuZHMgb24gTlZIRV9F TDJfREVCVUcKPiArCWRlZmF1bHQgbgo+ICsJaGVscAo+ICsJICBTYXkgWSBoZXJlIHRvIGVuYWJs ZSBwS1ZNIGh5cGVydmlzb3Igc3RhY2t0cmFjZXMgb24gaHlwX3BhbmljKCkKPiArCj4gKwkgIElm IHlvdSBhcmUgbm90IHVzaW5nIHByb3RlY3RlZCBuVkhFIChwS1ZNKSwgc2F5IE4uCj4gKwo+ICsJ ICBJZiB1c2luZyBwcm90ZWN0ZWQgblZIRSBtb2RlLCBidXQgY2Fubm90IGFmZm9yZCB0aGUgYXNz b2NpYXRlZAo+ICsJICBtZW1vcnkgY29zdCAobGVzcyB0aGFuIDAuNzUgcGFnZSBwZXIgQ1BVKSBv ZiBwS1ZNIHN0YWNrdHJhY2VzLAo+ICsJICBzYXkgTi4KPiArCj4gKwkgIElmIHVuc3VyZSwgc2F5 IE4uCj4gKwo+ICBjb25maWcgTlZIRV9FTDJfREVCVUcKPiAgCWJvb2wgIkRlYnVnIG1vZGUgZm9y IG5vbi1WSEUgRUwyIG9iamVjdCIKPiAgCWRlcGVuZHMgb24gS1ZNCgpIYXZpbmcgTlZIRV9FTDJf REVCVUcgYWZ0ZXIgUFJPVEVDVEVEX05WSEVfU1RBQ0tUUkFDRSBpcyBwcmV0dHkgb2RkCndoZW4g eW91IHVzZSAnbWFrZSBtZW51Y29uZmlnJywgYXMgdGhlIG5ldyBvcHRpb24gYXBwZWFycyBvdXQg b2YKc2VxdWVuY2UuCgpJJ2xsIG1vdmUgaXQgYXJvdW5kLCBubyBuZWVkIHRvIHJlc3BpbiBmb3Ig dGhpcy4KClRoYW5rcywKCglNLgoKLS0gCldpdGhvdXQgZGV2aWF0aW9uIGZyb20gdGhlIG5vcm0s IHByb2dyZXNzIGlzIG5vdCBwb3NzaWJsZS4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFy bS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0949C433EF for ; Tue, 26 Jul 2022 10:00:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232848AbiGZKAe (ORCPT ); Tue, 26 Jul 2022 06:00:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33720 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232558AbiGZKA1 (ORCPT ); Tue, 26 Jul 2022 06:00:27 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2DE039589 for ; Tue, 26 Jul 2022 03:00:25 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C5399615CD for ; Tue, 26 Jul 2022 10:00:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1B096C341C0; Tue, 26 Jul 2022 10:00:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1658829624; bh=lVR454/l8b9nh35sqhdWBxPKaE+Kv5ClI+XinX72svY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=GOf5SmE4BZFpHTm6PQb6Aome4X/MvjdlYbEAgGBqFm8lJuEAn8958GavDeHoF9MXA +fXbhsWjZ+gSsNaICj/kPuMWScev/6w7EKtRhdQ505jGW1m5rEllHBZ9ybkWIjoOz1 c3q4cm40QlIHR14ra9jRa/Owk1cJITYS4Qz1hMJgxJUQPW//xBF5oOl1J67hhjy0Tp wUt2/Ir96FOPEfWyJtXs1ls5GZMRgm4NLphkT4dhP2NOrzFYpguUwTTyrU0JvyAc5p e/CtU5IXiibo9ZdPw3xVAyJIL4riB8DbdQSpUGYv14iqQsoYDgksj26a6yBV1mXD+5 44B3X9gmdl7xA== Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1oGHMT-00A3QI-Nn; Tue, 26 Jul 2022 11:00:21 +0100 Date: Tue, 26 Jul 2022 11:00:21 +0100 Message-ID: <87a68wxkga.wl-maz@kernel.org> From: Marc Zyngier To: Kalesh Singh Cc: mark.rutland@arm.com, broonie@kernel.org, madvenka@linux.microsoft.com, tabba@google.com, oliver.upton@linux.dev, will@kernel.org, qperret@google.com, james.morse@arm.com, alexandru.elisei@arm.com, suzuki.poulose@arm.com, catalin.marinas@arm.com, andreyknvl@gmail.com, vincenzo.frascino@arm.com, mhiramat@kernel.org, ast@kernel.org, wangkefeng.wang@huawei.com, elver@google.com, keirf@google.com, yuzenghui@huawei.com, ardb@kernel.org, oupton@google.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, android-mm@google.com, kernel-team@android.com Subject: Re: [PATCH v6 12/17] KVM: arm64: Add PROTECTED_NVHE_STACKTRACE Kconfig In-Reply-To: <20220726073750.3219117-13-kaleshsingh@google.com> References: <20220726073750.3219117-1-kaleshsingh@google.com> <20220726073750.3219117-13-kaleshsingh@google.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: kaleshsingh@google.com, mark.rutland@arm.com, broonie@kernel.org, madvenka@linux.microsoft.com, tabba@google.com, oliver.upton@linux.dev, will@kernel.org, qperret@google.com, james.morse@arm.com, alexandru.elisei@arm.com, suzuki.poulose@arm.com, catalin.marinas@arm.com, andreyknvl@gmail.com, vincenzo.frascino@arm.com, mhiramat@kernel.org, ast@kernel.org, wangkefeng.wang@huawei.com, elver@google.com, keirf@google.com, yuzenghui@huawei.com, ardb@kernel.org, oupton@google.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, android-mm@google.com, kernel-team@android.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 26 Jul 2022 08:37:45 +0100, Kalesh Singh wrote: >=20 > This can be used to disable stacktrace for the protected KVM > nVHE hypervisor, in order to save on the associated memory usage. >=20 > This option is disabled by default, since protected KVM is not widely > used on platforms other than Android currently. >=20 > Signed-off-by: Kalesh Singh > Reviewed-by: Fuad Tabba > Tested-by: Fuad Tabba > --- >=20 > Changes in v6: > - Add Fuad=E2=80=99s Reviewed-by and Tested-by tags >=20 > Changes in v5: > - Make PROTECTED_NVHE_STACKTRACE depend on NVHE_EL2_DEBUG, per Marc >=20 > arch/arm64/kvm/Kconfig | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) >=20 > diff --git a/arch/arm64/kvm/Kconfig b/arch/arm64/kvm/Kconfig > index 8a5fbbf084df..09c995869916 100644 > --- a/arch/arm64/kvm/Kconfig > +++ b/arch/arm64/kvm/Kconfig > @@ -46,6 +46,21 @@ menuconfig KVM > =20 > If unsure, say N. > =20 > +config PROTECTED_NVHE_STACKTRACE > + bool "Protected KVM hypervisor stacktraces" > + depends on NVHE_EL2_DEBUG > + default n > + help > + Say Y here to enable pKVM hypervisor stacktraces on hyp_panic() > + > + If you are not using protected nVHE (pKVM), say N. > + > + If using protected nVHE mode, but cannot afford the associated > + memory cost (less than 0.75 page per CPU) of pKVM stacktraces, > + say N. > + > + If unsure, say N. > + > config NVHE_EL2_DEBUG > bool "Debug mode for non-VHE EL2 object" > depends on KVM Having NVHE_EL2_DEBUG after PROTECTED_NVHE_STACKTRACE is pretty odd when you use 'make menuconfig', as the new option appears out of sequence. I'll move it around, no need to respin for this. Thanks, M. --=20 Without deviation from the norm, progress is not possible.