From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by smtp.lore.kernel.org (Postfix) with ESMTP id BACEFC43334 for ; Wed, 20 Jul 2022 09:25:51 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 0A9114CF73; Wed, 20 Jul 2022 05:25:51 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@kernel.org Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5+pFW+HqjG0y; Wed, 20 Jul 2022 05:25:50 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id EE5DF4CF76; Wed, 20 Jul 2022 05:25:49 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id EF3AB4CF6C for ; Wed, 20 Jul 2022 05:25:48 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id DwDQVkacrehg for ; Wed, 20 Jul 2022 05:25:47 -0400 (EDT) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id C186B4CF67 for ; Wed, 20 Jul 2022 05:25:47 -0400 (EDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D657B61AF6; Wed, 20 Jul 2022 09:25:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3C47EC3411E; Wed, 20 Jul 2022 09:25:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1658309146; bh=aRfV00jPYBkhj3AAFRLIgZ2Svrr0Xhq4W7IMudBuVXI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=EQ8tbim40ZtsikX4yucRuTf9Zuqpv2mUalzppCtwxbUZbSBJJBHDIWNdPdjr9LySO Kx9PanK++xw9j6M8SmbhGsSMezJSuKuAMexZCuLo7qFOCiYFmFKHwlsHo1Elkbufx0 NC4DDMIk/ANuwYKpF7bvGVgIBYvD4faWDHEkpMW3M2EQB/NSpmBO6LaUYutw2SJeQR B6zMeJcNfBIpEYZatgXO+T3ssfzewuvLOimPMIon/RtoyJJoLbSt5p3zzw9RUrjm4+ nFmCNd6zcJ56dCIUygnfDHTWqgXWoQ4eWq3S+CJwx+cMM9qm6hbEnrkoNbPujTWCyJ 8YU6ocWeRB+EA== Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1oE5xf-008juE-Q3; Wed, 20 Jul 2022 10:25:44 +0100 Date: Wed, 20 Jul 2022 10:25:43 +0100 Message-ID: <87a694yw2w.wl-maz@kernel.org> From: Marc Zyngier To: Sean Christopherson Subject: Re: [PATCH v2 00/24] KVM: arm64: Introduce pKVM shadow state at EL2 In-Reply-To: References: <20220630135747.26983-1-will@kernel.org> <20220708162359.GA6286@willie-the-truck> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: seanjc@google.com, will@kernel.org, kvmarm@lists.cs.columbia.edu, ardb@kernel.org, alexandru.elisei@arm.com, luto@amacapital.net, catalin.marinas@arm.com, james.morse@arm.com, chao.p.peng@linux.intel.com, qperret@google.com, suzuki.poulose@arm.com, michael.roth@amd.com, mark.rutland@arm.com, tabba@google.com, oliver.upton@linux.dev, kernel-team@android.com, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Cc: kernel-team@android.com, kvm@vger.kernel.org, Will Deacon , Oliver Upton , Andy Lutomirski , linux-arm-kernel@lists.infradead.org, Michael Roth , Catalin Marinas , Chao Peng , kvmarm@lists.cs.columbia.edu X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On Tue, 19 Jul 2022 17:11:32 +0100, Sean Christopherson wrote: > Honestly, I think pKVM is simply being too cute in picking names. I don't know what you mean by "cute" here, but I assume this is not exactly a flattering qualifier. > And not just for "shadow", e.g. IMO the flush/sync terminology in > patch 24 is also unnecessarily cute. Instead of coming up with > clever names, just be explicit in what the code is doing. > E.g. something like: > > flush_shadow_state() => sync_host_to_pkvm_vcpu() > sync_shadow_state() => sync_pkvm_to_host_vcpu() As much as I like bikesheding, this isn't going to happen. We have had the sync/flush duality since day one, we have a lot of code based around this naming, and departing from it seems counter productive. M. -- Without deviation from the norm, progress is not possible. _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 323A5C433EF for ; Wed, 20 Jul 2022 09:26:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/gODN61x21cRfOll1U+J8Y1Idn3SPC2VV2qZvSZsRrY=; b=ohAQPK9lUN30lA 6urGcVpmk15rFi4rHcWDPjM+4wDpkgJjT9IXQ8byNBogDr1yaLD/nVx+BEdb+B4AHnQW38U0BFGGN DWHVeuJmOioylUE9yFjlqVNNvbg/J4rkMQcTycpMqbb7sUHfW8gfl8cY9WRME4Howl+L1maimNQvI 3vY+nH8dO/QtzDFqnylb2QbZcyVHgaH0Nlc6SpT1qV1IG4mcdZfLo51vxVpBzy3wg0r9rfV8UiEQU kfcrdaDIx+fJWwtQLVk+3o8tpFYBzPvQXorfYyqtxO1Bw0fU/UWYMC1BFIpXutmFuPCKkowr//ulN tdvaRQlTASQSzLZJhnfw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oE5xn-003F7H-AY; Wed, 20 Jul 2022 09:25:51 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oE5xk-003F3b-6R for linux-arm-kernel@lists.infradead.org; Wed, 20 Jul 2022 09:25:49 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D657B61AF6; Wed, 20 Jul 2022 09:25:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3C47EC3411E; Wed, 20 Jul 2022 09:25:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1658309146; bh=aRfV00jPYBkhj3AAFRLIgZ2Svrr0Xhq4W7IMudBuVXI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=EQ8tbim40ZtsikX4yucRuTf9Zuqpv2mUalzppCtwxbUZbSBJJBHDIWNdPdjr9LySO Kx9PanK++xw9j6M8SmbhGsSMezJSuKuAMexZCuLo7qFOCiYFmFKHwlsHo1Elkbufx0 NC4DDMIk/ANuwYKpF7bvGVgIBYvD4faWDHEkpMW3M2EQB/NSpmBO6LaUYutw2SJeQR B6zMeJcNfBIpEYZatgXO+T3ssfzewuvLOimPMIon/RtoyJJoLbSt5p3zzw9RUrjm4+ nFmCNd6zcJ56dCIUygnfDHTWqgXWoQ4eWq3S+CJwx+cMM9qm6hbEnrkoNbPujTWCyJ 8YU6ocWeRB+EA== Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1oE5xf-008juE-Q3; Wed, 20 Jul 2022 10:25:44 +0100 Date: Wed, 20 Jul 2022 10:25:43 +0100 Message-ID: <87a694yw2w.wl-maz@kernel.org> From: Marc Zyngier To: Sean Christopherson Cc: Will Deacon , kvmarm@lists.cs.columbia.edu, Ard Biesheuvel , Alexandru Elisei , Andy Lutomirski , Catalin Marinas , James Morse , Chao Peng , Quentin Perret , Suzuki K Poulose , Michael Roth , Mark Rutland , Fuad Tabba , Oliver Upton , kernel-team@android.com, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 00/24] KVM: arm64: Introduce pKVM shadow state at EL2 In-Reply-To: References: <20220630135747.26983-1-will@kernel.org> <20220708162359.GA6286@willie-the-truck> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: seanjc@google.com, will@kernel.org, kvmarm@lists.cs.columbia.edu, ardb@kernel.org, alexandru.elisei@arm.com, luto@amacapital.net, catalin.marinas@arm.com, james.morse@arm.com, chao.p.peng@linux.intel.com, qperret@google.com, suzuki.poulose@arm.com, michael.roth@amd.com, mark.rutland@arm.com, tabba@google.com, oliver.upton@linux.dev, kernel-team@android.com, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220720_022548_345873_A3AE73F3 X-CRM114-Status: GOOD ( 16.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 19 Jul 2022 17:11:32 +0100, Sean Christopherson wrote: > Honestly, I think pKVM is simply being too cute in picking names. I don't know what you mean by "cute" here, but I assume this is not exactly a flattering qualifier. > And not just for "shadow", e.g. IMO the flush/sync terminology in > patch 24 is also unnecessarily cute. Instead of coming up with > clever names, just be explicit in what the code is doing. > E.g. something like: > > flush_shadow_state() => sync_host_to_pkvm_vcpu() > sync_shadow_state() => sync_pkvm_to_host_vcpu() As much as I like bikesheding, this isn't going to happen. We have had the sync/flush duality since day one, we have a lot of code based around this naming, and departing from it seems counter productive. M. -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FD2CC433EF for ; Wed, 20 Jul 2022 09:25:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238470AbiGTJZw (ORCPT ); Wed, 20 Jul 2022 05:25:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56690 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229449AbiGTJZu (ORCPT ); Wed, 20 Jul 2022 05:25:50 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6A67B45F50 for ; Wed, 20 Jul 2022 02:25:48 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 78F6AB81EC0 for ; Wed, 20 Jul 2022 09:25:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3C47EC3411E; Wed, 20 Jul 2022 09:25:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1658309146; bh=aRfV00jPYBkhj3AAFRLIgZ2Svrr0Xhq4W7IMudBuVXI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=EQ8tbim40ZtsikX4yucRuTf9Zuqpv2mUalzppCtwxbUZbSBJJBHDIWNdPdjr9LySO Kx9PanK++xw9j6M8SmbhGsSMezJSuKuAMexZCuLo7qFOCiYFmFKHwlsHo1Elkbufx0 NC4DDMIk/ANuwYKpF7bvGVgIBYvD4faWDHEkpMW3M2EQB/NSpmBO6LaUYutw2SJeQR B6zMeJcNfBIpEYZatgXO+T3ssfzewuvLOimPMIon/RtoyJJoLbSt5p3zzw9RUrjm4+ nFmCNd6zcJ56dCIUygnfDHTWqgXWoQ4eWq3S+CJwx+cMM9qm6hbEnrkoNbPujTWCyJ 8YU6ocWeRB+EA== Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1oE5xf-008juE-Q3; Wed, 20 Jul 2022 10:25:44 +0100 Date: Wed, 20 Jul 2022 10:25:43 +0100 Message-ID: <87a694yw2w.wl-maz@kernel.org> From: Marc Zyngier To: Sean Christopherson Cc: Will Deacon , kvmarm@lists.cs.columbia.edu, Ard Biesheuvel , Alexandru Elisei , Andy Lutomirski , Catalin Marinas , James Morse , Chao Peng , Quentin Perret , Suzuki K Poulose , Michael Roth , Mark Rutland , Fuad Tabba , Oliver Upton , kernel-team@android.com, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 00/24] KVM: arm64: Introduce pKVM shadow state at EL2 In-Reply-To: References: <20220630135747.26983-1-will@kernel.org> <20220708162359.GA6286@willie-the-truck> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: seanjc@google.com, will@kernel.org, kvmarm@lists.cs.columbia.edu, ardb@kernel.org, alexandru.elisei@arm.com, luto@amacapital.net, catalin.marinas@arm.com, james.morse@arm.com, chao.p.peng@linux.intel.com, qperret@google.com, suzuki.poulose@arm.com, michael.roth@amd.com, mark.rutland@arm.com, tabba@google.com, oliver.upton@linux.dev, kernel-team@android.com, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Tue, 19 Jul 2022 17:11:32 +0100, Sean Christopherson wrote: > Honestly, I think pKVM is simply being too cute in picking names. I don't know what you mean by "cute" here, but I assume this is not exactly a flattering qualifier. > And not just for "shadow", e.g. IMO the flush/sync terminology in > patch 24 is also unnecessarily cute. Instead of coming up with > clever names, just be explicit in what the code is doing. > E.g. something like: > > flush_shadow_state() => sync_host_to_pkvm_vcpu() > sync_shadow_state() => sync_pkvm_to_host_vcpu() As much as I like bikesheding, this isn't going to happen. We have had the sync/flush duality since day one, we have a lot of code based around this naming, and departing from it seems counter productive. M. -- Without deviation from the norm, progress is not possible.