From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2B9EC433F5 for ; Fri, 27 May 2022 06:09:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242436AbiE0GJc (ORCPT ); Fri, 27 May 2022 02:09:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58644 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231739AbiE0GJ2 (ORCPT ); Fri, 27 May 2022 02:09:28 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6B8B4EC30F for ; Thu, 26 May 2022 23:09:26 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3516560E86 for ; Fri, 27 May 2022 06:09:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6A7F7C385A9; Fri, 27 May 2022 06:09:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1653631765; bh=e2bx8g1ZSPXC8wVCgZd27mdDgVxjXuh4ERx10fHKwto=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=dEn55Vpme8voFhxOcXrvIz5WpS9pBITqTeBWK7Fd36L6v0xruj1c48cW73FvNh0fM 0+Vi2GCkQ+EvqARVhDLiGexXkK5yxfcT1LCFvQskH20UN2uQdpIQZw/TTCNaLn5GoQ D/GiIA9faPcDx6qRXepCqp/VQKbuW77F5jCdp2XzIey0iyvIFflWmiV/pcbNXKJZYB vQtzdNsLBPgFVWBJaHw0YQP+GSeAB0sL4ZDKzV4xaAdpcvGrTLNKSHO8Y88b2CBFDO lORwO+NXWCJDmSuC6SaWhhi6clt4unX8P8z1w08BfzYqHg655uZVbnS/iSrEa1jeJG RzkUG+kke5jJw== From: Kalle Valo To: Johannes Berg Cc: viktor.barna@celeno.com, linux-wireless@vger.kernel.org, "David S . Miller" , Jakub Kicinski , Aviad Brikman , Eliav Farber , Maksym Kokhan , Oleksandr Savchenko , Shay Bar Subject: Re: [RFC v2 03/96] cl8k: add Kconfig References: <20220524113502.1094459-1-viktor.barna@celeno.com> <20220524113502.1094459-4-viktor.barna@celeno.com> Date: Fri, 27 May 2022 09:09:19 +0300 In-Reply-To: (Johannes Berg's message of "Thu, 26 May 2022 20:18:35 +0200") Message-ID: <87a6b3wlps.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Johannes Berg writes: > On Tue, 2022-05-24 at 14:33 +0300, viktor.barna@celeno.com wrote: >> + >> +config CL8K_VERSION >> + string "Version" >> + depends on CL8K >> + default "8.1.x" >> + help >> + Sets module version, which may be important for FW compatibility >> + analysis and syncing upstream codebase with the internal codebase. >> > > This, along with the def.h stuff using it, and MODULE_VERSION(), is all > rather pointless, I think you should remove it. s/should/need to/ :) -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches