From: Nikolaus Rath <Nikolaus@rath.org>
To: "yukuai (C)" <yukuai3@huawei.com>
Cc: "Richard W.M. Jones" <rjones@redhat.com>, <libguestfs@redhat.com>,
<linux-block@vger.kernel.org>, Josef Bacik <josef@toxicpanda.com>
Subject: Re: [Libguestfs] Communication issues between NBD driver and NBDKit server
Date: Tue, 17 May 2022 22:16:01 +0100 [thread overview]
Message-ID: <87a6bflv1q.fsf@vostro.rath.org> (raw)
In-Reply-To: <1f37a75a-83b5-af8e-0dd3-6475652ab218@huawei.com> (yukuai's message of "Mon, 16 May 2022 09:08:08 +0800")
On May 16 2022, "yukuai (C)" <yukuai3@huawei.com> wrote:
> On 2022/05/16 3:25, Richard W.M. Jones wrote:
>> On Sun, May 15, 2022 at 08:12:59PM +0100, Nikolaus Rath wrote:
>>> Do you see any way for this to happen?
>> I think it's impossible. A more likely explanation follows.
>> If you look at the kernel code, the NBD_CMD_INFLIGHT command flag is
>> cleared when a command times out:
>> https://github.com/torvalds/linux/blob/0cdd776ec92c0fec768c7079331804d3e52d4b27/drivers/block/nbd.c#L407
>> That's the place where it would have printed the "Possible stuck
>> request" message.
>> Some time later, nbdkit actually replies to the message (for the first
>> and only time) and in that code the flag is checked and found to be
>> clear already, causing the "Suspicious reply" message to be printed:
> Hi,
>
> You are right, can you try the following patch?
>
> https://lists.debian.org/nbd/2022/04/msg00212.html
Ah, I guess that makes sense. I thought that not specifying a timeout
meant "never time out".
I'll set this to a large value and report back if the problem recurs.
Thanks!
-Nikolaus
--
GPG Fingerprint: ED31 791B 2C5C 1613 AF38 8B8A D113 FCAC 3C4E 599F
»Time flies like an arrow, fruit flies like a Banana.«
prev parent reply other threads:[~2022-05-17 21:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <04a0a06b-e6dc-48b7-bc29-105dab888a56@www.fastmail.com>
2022-05-15 15:51 ` Communication issues between NBD driver and NBDKit server Josef Bacik
2022-05-15 16:39 ` Nikolaus Rath
2022-05-15 18:05 ` [Libguestfs] " Richard W.M. Jones
2022-05-15 19:12 ` Nikolaus Rath
2022-05-15 19:25 ` Richard W.M. Jones
2022-05-16 1:08 ` yukuai (C)
2022-05-17 21:16 ` Nikolaus Rath [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a6bflv1q.fsf@vostro.rath.org \
--to=nikolaus@rath.org \
--cc=josef@toxicpanda.com \
--cc=libguestfs@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=rjones@redhat.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.