From: Michael Ellerman <mpe@ellerman.id.au>
To: Kajol Jain <kjain@linux.ibm.com>, linuxppc-dev@lists.ozlabs.org
Cc: kjain@linux.ibm.com, atrajeev@linux.vnet.ibm.com,
maddy@linux.ibm.com, disgoel@linux.vnet.ibm.com,
rnsastry@linux.ibm.com
Subject: Re: [PATCH 00/35] Add group constraints and event code test as part of selftest
Date: Wed, 18 May 2022 23:23:21 +1000 [thread overview]
Message-ID: <87a6bfnfee.fsf@mpe.ellerman.id.au> (raw)
In-Reply-To: <20220506084544.56527-1-kjain@linux.ibm.com>
Kajol Jain <kjain@linux.ibm.com> writes:
> Patch series extends the perf interface selftests
> to cover scenarios for event code checking,
> group constraints, and also thresholding/branch related
> interface tests in sampling area.
There are build failures in CI:
https://github.com/ruscur/linux-ci/actions/runs/2317863271
If you follow the instructions here:
https://github.com/linuxppc/wiki/wiki/Testing-with-GitHub-Actions
You can have the same tests run against your own tree before you post to
the list.
cheers
> In this series, patches 1 to 14 adds additional tests under
> "powerpc/sampling_tests". These adds support for handling
> sample type PERF_SAMPLE_BRANCH_STACK along with interrupt regs.
> It adds utility functions and test for thresh_cmp and branch
> filters programmed in control register. Some of the tests needs
> to be skipped for "Generic Compat PMU" environment. Hence utility
> functions are added in "include/utils.c" and "sampling_tests/misc.h"
> to detect platform based on "auxv" entries.
>
> Currently in other architectures (like x86), the pmu_name is
> exposed via sysfs caps folder ie:
> "sys/bus/event_source/devices/<pmu>/caps". But in powerpc,
> "caps" is not supported. So, though the approach for detecting
> compat mode currently uses auxv, patchset adds an
> utility function considering a possibility of
> getting "caps" added for powerpc.
>
> Link to the patch to add support for caps under sysfs in powerpc:
> http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=297293
>
> Patches 15 to 35 covers test related to group constraints and event codes.
> These new set of changes are added under new folder:
> "selftests/powerpc/pmu/event_code_tests"
>
> Patch 15 covers changes required for new folder with Makefile changes.
> The other patches add tests for perf interface to check the event
> group constraints, valid/invalid event codes, blacklisted events etc.
> Also add required utility functions under header file "misc.h"
> in sampling_tests folder.
>
> Patch 33 and 34 depend upon thresh_cmp group constraint fix patches
> sent in upstream mailing list.
>
> Link to the thresh_cmp fix patchset:
> http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=298742
>
> Patch 13 of the patchset add selftest for mmcr1 pmcxsel/unit/cache fields,
> which was initially dropeed from sampling test patchset (patch number: 16)
>
> Link to the patch:
> http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20220127072012.662451-17-kjain@linux.ibm.com/
>
> Athira Rajeev (20):
> testing/selftests/powerpc: Add support to fetch "platform" and "base
> platform" from auxv to detect platform.
> selftest/powerpc/pmu: Refactor the platform check and add macros to
> find array size/PVR
> selftest/powerpc/pmu: Add selftest to check branch stack enablement
> will not crash on any platforms
> selftest/powerpc/pmu: Add selftest to check PERF_SAMPLE_REGS_INTR
> option will not crash on any platforms
> selftest/powerpc/pmu: Add selftest for checking valid and invalid bhrb
> filter maps
> selftest/powerpc/pmu: Add selftest for mmcr1 pmcxsel/unit/cache fields
> selftest/powerpc/pmu: Add support for perf event code tests
> selftest/powerpc/pmu: Add selftest for group constraint check for PMC5
> and PMC6
> selftest/powerpc/pmu: Add selftest to check PMC5/6 is excluded from
> some constraint checks
> selftest/powerpc/pmu: Add selftest to check constraint for number of
> counters in use.
> selftest/powerpc/pmu: Add selftest for group constraint check when
> using same PMC
> selftest/powerpc/pmu: Add selftest for group constraint check for
> radix_scope_qual field
> selftest/powerpc/pmu: Add selftest for group constraint for MMCRA
> Sampling Mode field
> selftest/powerpc/pmu: Add selftest for group constraint check MMCRA
> sample bits
> selftest/powerpc/pmu: Add selftest for checking invalid bits in event
> code
> selftest/powerpc/pmu: Add selftest for reserved bit check for MMCRA
> thresh_ctl field
> selftest/powerpc/pmu: Add selftest for blacklist events check in
> power9
> selftest/powerpc/pmu: Add selftest for event alternatives for power9
> selftest/powerpc/pmu: Add selftest for event alternatives for power10
> selftest/powerpc/pmu: Add selftest for PERF_TYPE_HARDWARE events valid
> check
>
> Kajol Jain (15):
> selftest/powerpc/pmu: Add mask/shift bits for extracting threshold
> compare field
> selftest/powerpc/pmu: Add interface test for mmcra_thresh_cmp fields
> selftest/powerpc/pmu: Add support for branch sampling in get_intr_regs
> function
> selftest/powerpc/pmu: Add interface test for mmcra_ifm field of
> indirect call type
> selftest/powerpc/pmu: Add interface test for mmcra_ifm field for any
> branch type
> selftest/powerpc/pmu: Add interface test for mmcra_ifm field for
> conditional branch type
> selftest/powerpc/pmu: Add interface test for bhrb disable field
> selftest/powerpc/pmu: Add interface test for bhrb disable field for
> non-branch samples
> selftest/powerpc/pmu: Add selftest for group constraint check for
> MMCR0 l2l3_sel bits
> selftest/powerpc/pmu: Add selftest for group constraint check for
> MMCR1 cache bits
> selftest/powerpc/pmu: Add selftest for group constraint check for
> MMCRA thresh_cmp field
> selftest/powerpc/pmu: Add selftest for group constraint for unit and
> pmc field in p9
> selftest/powerpc/pmu: Add selftest for group constraint check for
> MMCRA thresh_ctl field
> selftest/powerpc/pmu: Add selftest for group constraint check for
> MMCRA thresh_sel field
> selftest/powerpc/pmu: Add test for hardware cache events
>
> tools/testing/selftests/powerpc/include/reg.h | 4 +
> .../testing/selftests/powerpc/include/utils.h | 10 ++
> tools/testing/selftests/powerpc/pmu/Makefile | 11 +-
> .../selftests/powerpc/pmu/branch_loops.S | 28 ++++
> .../powerpc/pmu/event_code_tests/Makefile | 15 ++
> .../blacklisted_events_test.c | 132 +++++++++++++++++
> .../event_alternatives_tests_p10.c | 109 ++++++++++++++
> .../event_alternatives_tests_p9.c | 116 +++++++++++++++
> .../generic_events_valid_test.c | 130 +++++++++++++++++
> .../group_constraint_cache_test.c | 60 ++++++++
> .../group_constraint_l2l3_sel_test.c | 64 +++++++++
> .../group_constraint_mmcra_sample_test.c | 54 +++++++
> .../group_constraint_pmc56_test.c | 63 ++++++++
> .../group_constraint_pmc_count_test.c | 70 +++++++++
> .../group_constraint_radix_scope_qual_test.c | 56 ++++++++
> .../group_constraint_repeat_test.c | 56 ++++++++
> .../group_constraint_thresh_cmp_test.c | 96 +++++++++++++
> .../group_constraint_thresh_ctl_test.c | 64 +++++++++
> .../group_constraint_thresh_sel_test.c | 63 ++++++++
> .../group_constraint_unit_test.c | 74 ++++++++++
> .../group_pmc56_exclude_constraints_test.c | 64 +++++++++
> .../hw_cache_event_type_test.c | 88 ++++++++++++
> .../invalid_event_code_test.c | 67 +++++++++
> ...eserved_bits_mmcra_sample_elig_mode_test.c | 77 ++++++++++
> .../reserved_bits_mmcra_thresh_ctl_test.c | 44 ++++++
> .../powerpc/pmu/sampling_tests/Makefile | 7 +-
> .../pmu/sampling_tests/bhrb_filter_map_test.c | 115 +++++++++++++++
> .../bhrb_no_crash_wo_pmu_test.c | 59 ++++++++
> .../intr_regs_no_crash_wo_pmu_test.c | 57 ++++++++
> .../powerpc/pmu/sampling_tests/misc.c | 135 +++++++++++++++++-
> .../powerpc/pmu/sampling_tests/misc.h | 9 +-
> .../mmcr1_sel_unit_cache_test.c | 77 ++++++++++
> .../pmu/sampling_tests/mmcra_bhrb_any_test.c | 65 +++++++++
> .../pmu/sampling_tests/mmcra_bhrb_cond_test.c | 69 +++++++++
> .../mmcra_bhrb_disable_no_branch_test.c | 64 +++++++++
> .../sampling_tests/mmcra_bhrb_disable_test.c | 66 +++++++++
> .../sampling_tests/mmcra_bhrb_ind_call_test.c | 69 +++++++++
> .../sampling_tests/mmcra_thresh_cmp_test.c | 74 ++++++++++
> 38 files changed, 2471 insertions(+), 10 deletions(-)
> create mode 100644 tools/testing/selftests/powerpc/pmu/branch_loops.S
> create mode 100644 tools/testing/selftests/powerpc/pmu/event_code_tests/Makefile
> create mode 100644 tools/testing/selftests/powerpc/pmu/event_code_tests/blacklisted_events_test.c
> create mode 100644 tools/testing/selftests/powerpc/pmu/event_code_tests/event_alternatives_tests_p10.c
> create mode 100644 tools/testing/selftests/powerpc/pmu/event_code_tests/event_alternatives_tests_p9.c
> create mode 100644 tools/testing/selftests/powerpc/pmu/event_code_tests/generic_events_valid_test.c
> create mode 100644 tools/testing/selftests/powerpc/pmu/event_code_tests/group_constraint_cache_test.c
> create mode 100644 tools/testing/selftests/powerpc/pmu/event_code_tests/group_constraint_l2l3_sel_test.c
> create mode 100644 tools/testing/selftests/powerpc/pmu/event_code_tests/group_constraint_mmcra_sample_test.c
> create mode 100644 tools/testing/selftests/powerpc/pmu/event_code_tests/group_constraint_pmc56_test.c
> create mode 100644 tools/testing/selftests/powerpc/pmu/event_code_tests/group_constraint_pmc_count_test.c
> create mode 100644 tools/testing/selftests/powerpc/pmu/event_code_tests/group_constraint_radix_scope_qual_test.c
> create mode 100644 tools/testing/selftests/powerpc/pmu/event_code_tests/group_constraint_repeat_test.c
> create mode 100644 tools/testing/selftests/powerpc/pmu/event_code_tests/group_constraint_thresh_cmp_test.c
> create mode 100644 tools/testing/selftests/powerpc/pmu/event_code_tests/group_constraint_thresh_ctl_test.c
> create mode 100644 tools/testing/selftests/powerpc/pmu/event_code_tests/group_constraint_thresh_sel_test.c
> create mode 100644 tools/testing/selftests/powerpc/pmu/event_code_tests/group_constraint_unit_test.c
> create mode 100644 tools/testing/selftests/powerpc/pmu/event_code_tests/group_pmc56_exclude_constraints_test.c
> create mode 100644 tools/testing/selftests/powerpc/pmu/event_code_tests/hw_cache_event_type_test.c
> create mode 100644 tools/testing/selftests/powerpc/pmu/event_code_tests/invalid_event_code_test.c
> create mode 100644 tools/testing/selftests/powerpc/pmu/event_code_tests/reserved_bits_mmcra_sample_elig_mode_test.c
> create mode 100644 tools/testing/selftests/powerpc/pmu/event_code_tests/reserved_bits_mmcra_thresh_ctl_test.c
> create mode 100644 tools/testing/selftests/powerpc/pmu/sampling_tests/bhrb_filter_map_test.c
> create mode 100644 tools/testing/selftests/powerpc/pmu/sampling_tests/bhrb_no_crash_wo_pmu_test.c
> create mode 100644 tools/testing/selftests/powerpc/pmu/sampling_tests/intr_regs_no_crash_wo_pmu_test.c
> create mode 100644 tools/testing/selftests/powerpc/pmu/sampling_tests/mmcr1_sel_unit_cache_test.c
> create mode 100644 tools/testing/selftests/powerpc/pmu/sampling_tests/mmcra_bhrb_any_test.c
> create mode 100644 tools/testing/selftests/powerpc/pmu/sampling_tests/mmcra_bhrb_cond_test.c
> create mode 100644 tools/testing/selftests/powerpc/pmu/sampling_tests/mmcra_bhrb_disable_no_branch_test.c
> create mode 100644 tools/testing/selftests/powerpc/pmu/sampling_tests/mmcra_bhrb_disable_test.c
> create mode 100644 tools/testing/selftests/powerpc/pmu/sampling_tests/mmcra_bhrb_ind_call_test.c
> create mode 100644 tools/testing/selftests/powerpc/pmu/sampling_tests/mmcra_thresh_cmp_test.c
>
> --
> 2.31.1
next prev parent reply other threads:[~2022-05-18 13:24 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-06 8:45 [PATCH 00/35] Add group constraints and event code test as part of selftest Kajol Jain
2022-05-06 8:45 ` [PATCH 01/35] selftest/powerpc/pmu: Add mask/shift bits for extracting threshold compare field Kajol Jain
2022-05-06 8:45 ` [PATCH 02/35] testing/selftests/powerpc: Add support to fetch "platform" and "base platform" from auxv to detect platform Kajol Jain
2022-05-06 8:45 ` [PATCH 03/35] selftest/powerpc/pmu: Add interface test for mmcra_thresh_cmp fields Kajol Jain
2022-05-06 8:45 ` [PATCH 04/35] selftest/powerpc/pmu: Add support for branch sampling in get_intr_regs function Kajol Jain
2022-05-06 8:45 ` [PATCH 05/35] selftest/powerpc/pmu: Add interface test for mmcra_ifm field of indirect call type Kajol Jain
2022-05-06 8:45 ` [PATCH 06/35] selftest/powerpc/pmu: Add interface test for mmcra_ifm field for any branch type Kajol Jain
2022-05-06 8:45 ` [PATCH 07/35] selftest/powerpc/pmu: Add interface test for mmcra_ifm field for conditional " Kajol Jain
2022-05-06 8:45 ` [PATCH 08/35] selftest/powerpc/pmu: Add interface test for bhrb disable field Kajol Jain
2022-05-06 8:45 ` [PATCH 09/35] selftest/powerpc/pmu: Refactor the platform check and add macros to find array size/PVR Kajol Jain
2022-05-06 8:45 ` [PATCH 10/35] selftest/powerpc/pmu: Add selftest to check branch stack enablement will not crash on any platforms Kajol Jain
2022-05-06 8:45 ` [PATCH 11/35] selftest/powerpc/pmu: Add selftest to check PERF_SAMPLE_REGS_INTR option " Kajol Jain
2022-05-06 8:45 ` [PATCH 12/35] selftest/powerpc/pmu: Add selftest for checking valid and invalid bhrb filter maps Kajol Jain
2022-05-06 8:45 ` [PATCH 13/35] selftest/powerpc/pmu: Add selftest for mmcr1 pmcxsel/unit/cache fields Kajol Jain
2022-05-06 8:45 ` [PATCH 14/35] selftest/powerpc/pmu: Add interface test for bhrb disable field for non-branch samples Kajol Jain
2022-05-06 8:45 ` [PATCH 15/35] selftest/powerpc/pmu: Add support for perf event code tests Kajol Jain
2022-05-06 8:45 ` [PATCH 16/35] selftest/powerpc/pmu: Add selftest for group constraint check for PMC5 and PMC6 Kajol Jain
2022-05-06 8:45 ` [PATCH 17/35] selftest/powerpc/pmu: Add selftest to check PMC5/6 is excluded from some constraint checks Kajol Jain
2022-05-06 8:45 ` [PATCH 18/35] selftest/powerpc/pmu: Add selftest to check constraint for number of counters in use Kajol Jain
2022-05-06 8:45 ` [PATCH 19/35] selftest/powerpc/pmu: Add selftest for group constraint check when using same PMC Kajol Jain
2022-05-06 8:45 ` [PATCH 20/35] selftest/powerpc/pmu: Add selftest for group constraint check for radix_scope_qual field Kajol Jain
2022-05-06 8:45 ` [PATCH 21/35] selftest/powerpc/pmu: Add selftest for group constraint for MMCRA Sampling Mode field Kajol Jain
2022-05-06 8:45 ` [PATCH 22/35] selftest/powerpc/pmu: Add selftest for group constraint check MMCRA sample bits Kajol Jain
2022-05-06 8:45 ` [PATCH 23/35] selftest/powerpc/pmu: Add selftest for checking invalid bits in event code Kajol Jain
2022-05-06 8:45 ` [PATCH 24/35] selftest/powerpc/pmu: Add selftest for reserved bit check for MMCRA thresh_ctl field Kajol Jain
2022-05-06 8:45 ` [PATCH 25/35] selftest/powerpc/pmu: Add selftest for blacklist events check in power9 Kajol Jain
2022-05-06 8:45 ` [PATCH 26/35] selftest/powerpc/pmu: Add selftest for event alternatives for power9 Kajol Jain
2022-05-06 8:45 ` [PATCH 27/35] selftest/powerpc/pmu: Add selftest for event alternatives for power10 Kajol Jain
2022-05-06 8:45 ` [PATCH 28/35] selftest/powerpc/pmu: Add selftest for PERF_TYPE_HARDWARE events valid check Kajol Jain
2022-05-06 8:45 ` [PATCH 29/35] selftest/powerpc/pmu: Add selftest for group constraint check for MMCR0 l2l3_sel bits Kajol Jain
2022-05-06 8:45 ` [PATCH 30/35] selftest/powerpc/pmu: Add selftest for group constraint check for MMCR1 cache bits Kajol Jain
2022-05-06 8:45 ` [PATCH 31/35] selftest/powerpc/pmu: Add selftest for group constraint check for MMCRA thresh_cmp field Kajol Jain
2022-05-06 8:45 ` [PATCH 32/35] selftest/powerpc/pmu: Add selftest for group constraint for unit and pmc field in p9 Kajol Jain
2022-05-06 8:45 ` [PATCH 33/35] selftest/powerpc/pmu: Add selftest for group constraint check for MMCRA thresh_ctl field Kajol Jain
2022-05-06 8:45 ` [PATCH 34/35] selftest/powerpc/pmu: Add selftest for group constraint check for MMCRA thresh_sel field Kajol Jain
2022-05-06 8:45 ` [PATCH 35/35] selftest/powerpc/pmu: Add test for hardware cache events Kajol Jain
2022-05-18 13:23 ` Michael Ellerman [this message]
2022-05-19 16:26 ` [PATCH 00/35] Add group constraints and event code test as part of selftest Athira Rajeev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a6bfnfee.fsf@mpe.ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=atrajeev@linux.vnet.ibm.com \
--cc=disgoel@linux.vnet.ibm.com \
--cc=kjain@linux.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.ibm.com \
--cc=rnsastry@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.