Re: QCA6390 power saving issue

From: Kalle Valo <kvalo@kernel.org>
To: Mark Herbert <mark.herbert42@gmail.com>
Cc: ath11k@lists.infradead.org
Subject: Re: QCA6390 power saving issue
Date: Wed, 30 Mar 2022 15:47:13 +0300	[thread overview]
Message-ID: <87a6d7wqsu.fsf@kernel.org> (raw)
In-Reply-To: <da91be76-d609-ba29-76e6-5365ea1db9d4@gmail.com> (Mark Herbert's message of "Wed, 30 Mar 2022 12:43:01 +0300")

+ ath11k list

Mark Herbert <mark.herbert42@gmail.com> writes:

> Done - https://bugzilla.kernel.org/show_bug.cgi?id=215775

Thanks!

> Checked the previous bug - the powersave activation is done only on
> change of something - so when the driver is loaded but never connected
> so this IF did not become true at least one time - the powersave is
> not yet enabled and card remains in the initial setting keeping PC3 as
> a lowest state. Seems that when we initialize the driver we need to
> call this ath11k_mac_config_ps(ar) one time - then on each change of
> the connection the current code will handle that.
>
> @@ -2942,6 +3019,16 @@ static void ath11k_mac_op_bss_info_changed(struct ieee80211_hw
> *hw,
> ath11k_mac_txpower_recalc(ar);
> }
> + if (changed & BSS_CHANGED_PS &&
> + ar->ab->hw_params.supports_sta_ps) {
> + arvif->ps = vif->bss_conf.ps;
> +
> + ret = ath11k_mac_config_ps(ar);
> + if (ret)
> + ath11k_warn(ar->ab, "failed to setup ps on vdev %i: %d\n",
> + arvif->vdev_id, ret);
> + }

Didn't check the code, but makes sense. Can you or someone else send a
patch, please?

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

-- 
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k