From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CE76C433EF for ; Wed, 23 Mar 2022 16:05:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245305AbiCWQG1 (ORCPT ); Wed, 23 Mar 2022 12:06:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37154 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234639AbiCWQG0 (ORCPT ); Wed, 23 Mar 2022 12:06:26 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 932AB14093; Wed, 23 Mar 2022 09:04:56 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 01B01B81F9C; Wed, 23 Mar 2022 16:04:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 377EEC340E8; Wed, 23 Mar 2022 16:04:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1648051493; bh=J6Jj3uWyZKjJ9PzohwOMwt8OqyngKpQ+spVUMeqUv28=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=Nma3Zy9b+SImVRKKJ4m/jQvhdePFX4Ogdo2X7Hi0o2lZBBUA6DIa835nJbIwFSeJa k0KBST/EBjBw9icoS8QpUlxeRokAd+fFYxwcedzDkytHzdNTbHlh28YvrWXeNAAvg7 pouH5z8cw0UuENpv5UVF/zZm6FTLYEvb5lrLBtH6Bc/ETVzFj0FyMzBkayQpG4WF4F HAk+9SPOxtyfjdFpliFkZTaSL2dtexKGPTVj1s+1U20bjYliqCMC/x2bSC6IohZwUI KJI4MhvmRaPXtw7ySwTEMdoMvRjFgwfP/Xe2ikFYCd0tSh4r4lwYOXwAYy94GY6hGf ftgMup5HN4aDA== From: Kalle Valo To: Yann Gautier Cc: Ulf Hansson , , Christophe ROULLIER-SCND-02 , Arend van Spriel , Franky Lin , Hante Meuleman , Gustavo Padovan , Adrian Ratiu , , , Christophe KERELLO - foss Subject: Re: [PATCH v2] brcmfmac: Avoid keeping power to SDIO card unless WOWL is used References: <20220323083950.414783-1-ulf.hansson@linaro.org> <51b4917b-823d-263a-2412-a4b17cb38420@foss.st.com> Date: Wed, 23 Mar 2022 18:04:46 +0200 In-Reply-To: <51b4917b-823d-263a-2412-a4b17cb38420@foss.st.com> (Yann Gautier's message of "Wed, 23 Mar 2022 14:20:36 +0100") Message-ID: <87a6dgk63l.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Yann Gautier writes: > On 3/23/22 09:39, Ulf Hansson wrote: >> Keeping the power to the SDIO card during system wide suspend, consumes >> energy. Especially on battery driven embedded systems, this can be a >> problem. Therefore, let's change the behaviour into allowing the SDIO card >> to be powered off, unless WOWL is supported and enabled. >> >> Note that, the downside from this change, is that during system resume the >> SDIO card needs to be re-initialized and the FW must be re-programmed. Even >> if this may take some time to complete, it should we worth it, rather than >> draining the battery. >> >> Signed-off-by: Ulf Hansson > > Thanks for the patch, it is OK, and tested by Christophe (R.). > So you can add: > Tested-by: Christophe Roullier > Acked-by: Yann Gautier Acked-by is used by the driver maintainer, so I assume you mean Reviewed-by? -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches