From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3C06C433EF for ; Sat, 12 Feb 2022 10:59:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232230AbiBLK7q (ORCPT ); Sat, 12 Feb 2022 05:59:46 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:59596 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230370AbiBLK7p (ORCPT ); Sat, 12 Feb 2022 05:59:45 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 64DA824BD6; Sat, 12 Feb 2022 02:59:42 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 0FF01B802BD; Sat, 12 Feb 2022 10:59:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C155DC340E7; Sat, 12 Feb 2022 10:59:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1644663579; bh=CEMuvy2r1KPNQwE5XFJkNJGu4R8eD6T2pmx2Vd1YYOs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=e3GL42LcXKYTWMdPP6WeRXd5zHkyvrTIPqdOzvCElBMswHLZciV3hzpMnL7Pu9b8l 5OboDCWvEronnqPUvrSXmYtKbzYulA/5D8Wk5CATxkR0jyru02yYYyLhkvbTU1DnL3 UxPC18BUtVVZjzBTurGq7MI4s+KTCwtLqh8ggnE5w+Rq5J0QoOTbsLHlfZ2sODS3du /q6c1uKR38ZLODTkRpdFnezEId1Ahmjz2wx59SlsgaypT/0nXi9UQm46VyO3z9mxV8 P3/ZY6PZjtwRb7ImblUKa/djrmNp4UreU4lm63LdzJzScJJyL8NqRIUf3jMYPdWItq GEhCVQ+c77DFg== Received: from sofa.misterjones.org ([185.219.108.64] helo=billy-the-mountain.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nIq7t-007Lli-IC; Sat, 12 Feb 2022 10:59:37 +0000 Date: Sat, 12 Feb 2022 10:59:37 +0000 Message-ID: <87a6ewl59i.wl-maz@kernel.org> From: Marc Zyngier To: Lorenzo Pieralisi Cc: Pali =?UTF-8?B?Um9ow6Fy?= , robh+dt@kernel.org, Bjorn Helgaas , Thomas Petazzoni , Krzysztof =?UTF-8?B?V2lsY3p5xYRza2k=?= , Marek =?UTF-8?B?QmVow7pu?= , Russell King , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 10/11] PCI: mvebu: Implement support for legacy INTx interrupts In-Reply-To: <20220211182137.GA2492@lpieralisi> References: <20220105150239.9628-1-pali@kernel.org> <20220112151814.24361-1-pali@kernel.org> <20220112151814.24361-11-pali@kernel.org> <20220211171917.GA740@lpieralisi> <20220211175202.gku5pkwn5wmjo5al@pali> <20220211182137.GA2492@lpieralisi> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: lorenzo.pieralisi@arm.com, pali@kernel.org, robh+dt@kernel.org, bhelgaas@google.com, thomas.petazzoni@bootlin.com, kw@linux.com, kabel@kernel.org, rmk+kernel@armlinux.org.uk, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Fri, 11 Feb 2022 18:21:37 +0000, Lorenzo Pieralisi wrote: >=20 > On Fri, Feb 11, 2022 at 06:52:02PM +0100, Pali Roh=C3=A1r wrote: >=20 > [...] >=20 > > > > @@ -1121,6 +1247,21 @@ static int mvebu_pcie_parse_port(struct mveb= u_pcie *pcie, > > > > port->io_attr =3D -1; > > > > } > > > > =20 > > > > + /* > > > > + * Old DT bindings do not contain "intx" interrupt > > > > + * so do not fail probing driver when interrupt does not exist. > > > > + */ > > > > + port->intx_irq =3D of_irq_get_byname(child, "intx"); > > > > + if (port->intx_irq =3D=3D -EPROBE_DEFER) { > > > > + ret =3D port->intx_irq; > > > > + goto err; > > > > + } > > > > + if (port->intx_irq <=3D 0) { > > > > + dev_warn(dev, "%s: legacy INTx interrupts cannot be masked indiv= idually, " > > > > + "%pOF does not contain intx interrupt\n", > > > > + port->name, child); > > >=20 > > > Here you end up with a new warning on existing firmware. Is it > > > legitimate ? I would remove the dev_warn(). > >=20 > > I added this warning in v2 because Marc wanted it. > >=20 > > Should I (again) remove it in v3? >=20 > No, I asked a question and gave an opinion, I appreciate Marc's concern > so leave it (ie not everyone running a new kernel with new warnings on > existing firmware would be happy - maybe it is a good way of forcing a > firmware upgrade, you will tell me). My concern is that short of being able to mask these interrupts, it is possible for a device to assert an interrupt that no driver handles, and the kernel spurious interrupt detector won't be able to shut it up. At this stage, the machine is totally dead (screaming *level* interrupt). The dev_warn() could toned down to a dev_warn_once() though. M. --=20 Without deviation from the norm, progress is not possible. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DB4E3C433EF for ; Sat, 12 Feb 2022 11:01:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=IQJNdjpw0ZLH4p1jh7qqgChPhJu8KFzZn86FGr7AAPs=; b=Bebkj/arBVqjCQ gG2Qg1NeQbhnYnUNbhlecmhNdWWGQQPXqxdH2yph845YjsLD7ST/J9mDlb5xREOUFYUTK5ACXqr5m dYwlMhq6zb5a08wNn14IStrHtFdr8FXPD6tflQaavwrAI8I0IuyZ6xgxjfSwF7BcTDMmn5qh/hP+5 E+xh0lir3NUOozFLYpMql4JX9u7V9eswM0V0SBAnpik9Kb7iDA0QXRW+0SLYSrb6/T9odFLu5CuT9 DvLTIhyStRYq80+ZJuAUlczcE3haKKCJxb+ITup2T8kbc4k6SzlwQyjoO8Nc3F4FvD9ddU1VjAwN5 Mu/yz6O3DWss+8QlY4bA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nIq80-009lZ3-SW; Sat, 12 Feb 2022 10:59:45 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nIq7x-009lYR-RW for linux-arm-kernel@lists.infradead.org; Sat, 12 Feb 2022 10:59:43 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 705D960C34; Sat, 12 Feb 2022 10:59:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C155DC340E7; Sat, 12 Feb 2022 10:59:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1644663579; bh=CEMuvy2r1KPNQwE5XFJkNJGu4R8eD6T2pmx2Vd1YYOs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=e3GL42LcXKYTWMdPP6WeRXd5zHkyvrTIPqdOzvCElBMswHLZciV3hzpMnL7Pu9b8l 5OboDCWvEronnqPUvrSXmYtKbzYulA/5D8Wk5CATxkR0jyru02yYYyLhkvbTU1DnL3 UxPC18BUtVVZjzBTurGq7MI4s+KTCwtLqh8ggnE5w+Rq5J0QoOTbsLHlfZ2sODS3du /q6c1uKR38ZLODTkRpdFnezEId1Ahmjz2wx59SlsgaypT/0nXi9UQm46VyO3z9mxV8 P3/ZY6PZjtwRb7ImblUKa/djrmNp4UreU4lm63LdzJzScJJyL8NqRIUf3jMYPdWItq GEhCVQ+c77DFg== Received: from sofa.misterjones.org ([185.219.108.64] helo=billy-the-mountain.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nIq7t-007Lli-IC; Sat, 12 Feb 2022 10:59:37 +0000 Date: Sat, 12 Feb 2022 10:59:37 +0000 Message-ID: <87a6ewl59i.wl-maz@kernel.org> From: Marc Zyngier To: Lorenzo Pieralisi Cc: Pali =?UTF-8?B?Um9ow6Fy?= , robh+dt@kernel.org, Bjorn Helgaas , Thomas Petazzoni , Krzysztof =?UTF-8?B?V2lsY3p5xYRza2k=?= , Marek =?UTF-8?B?QmVow7pu?= , Russell King , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 10/11] PCI: mvebu: Implement support for legacy INTx interrupts In-Reply-To: <20220211182137.GA2492@lpieralisi> References: <20220105150239.9628-1-pali@kernel.org> <20220112151814.24361-1-pali@kernel.org> <20220112151814.24361-11-pali@kernel.org> <20220211171917.GA740@lpieralisi> <20220211175202.gku5pkwn5wmjo5al@pali> <20220211182137.GA2492@lpieralisi> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: lorenzo.pieralisi@arm.com, pali@kernel.org, robh+dt@kernel.org, bhelgaas@google.com, thomas.petazzoni@bootlin.com, kw@linux.com, kabel@kernel.org, rmk+kernel@armlinux.org.uk, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220212_025941_997031_AC413D63 X-CRM114-Status: GOOD ( 26.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gRnJpLCAxMSBGZWIgMjAyMiAxODoyMTozNyArMDAwMCwKTG9yZW56byBQaWVyYWxpc2kgPGxv cmVuem8ucGllcmFsaXNpQGFybS5jb20+IHdyb3RlOgo+IAo+IE9uIEZyaSwgRmViIDExLCAyMDIy IGF0IDA2OjUyOjAyUE0gKzAxMDAsIFBhbGkgUm9ow6FyIHdyb3RlOgo+IAo+IFsuLi5dCj4gCj4g PiA+ID4gQEAgLTExMjEsNiArMTI0NywyMSBAQCBzdGF0aWMgaW50IG12ZWJ1X3BjaWVfcGFyc2Vf cG9ydChzdHJ1Y3QgbXZlYnVfcGNpZSAqcGNpZSwKPiA+ID4gPiAgCQlwb3J0LT5pb19hdHRyID0g LTE7Cj4gPiA+ID4gIAl9Cj4gPiA+ID4gIAo+ID4gPiA+ICsJLyoKPiA+ID4gPiArCSAqIE9sZCBE VCBiaW5kaW5ncyBkbyBub3QgY29udGFpbiAiaW50eCIgaW50ZXJydXB0Cj4gPiA+ID4gKwkgKiBz byBkbyBub3QgZmFpbCBwcm9iaW5nIGRyaXZlciB3aGVuIGludGVycnVwdCBkb2VzIG5vdCBleGlz dC4KPiA+ID4gPiArCSAqLwo+ID4gPiA+ICsJcG9ydC0+aW50eF9pcnEgPSBvZl9pcnFfZ2V0X2J5 bmFtZShjaGlsZCwgImludHgiKTsKPiA+ID4gPiArCWlmIChwb3J0LT5pbnR4X2lycSA9PSAtRVBS T0JFX0RFRkVSKSB7Cj4gPiA+ID4gKwkJcmV0ID0gcG9ydC0+aW50eF9pcnE7Cj4gPiA+ID4gKwkJ Z290byBlcnI7Cj4gPiA+ID4gKwl9Cj4gPiA+ID4gKwlpZiAocG9ydC0+aW50eF9pcnEgPD0gMCkg ewo+ID4gPiA+ICsJCWRldl93YXJuKGRldiwgIiVzOiBsZWdhY3kgSU5UeCBpbnRlcnJ1cHRzIGNh bm5vdCBiZSBtYXNrZWQgaW5kaXZpZHVhbGx5LCAiCj4gPiA+ID4gKwkJCSAgICAgICIlcE9GIGRv ZXMgbm90IGNvbnRhaW4gaW50eCBpbnRlcnJ1cHRcbiIsCj4gPiA+ID4gKwkJCSBwb3J0LT5uYW1l LCBjaGlsZCk7Cj4gPiA+IAo+ID4gPiBIZXJlIHlvdSBlbmQgdXAgd2l0aCBhIG5ldyB3YXJuaW5n IG9uIGV4aXN0aW5nIGZpcm13YXJlLiBJcyBpdAo+ID4gPiBsZWdpdGltYXRlID8gSSB3b3VsZCBy ZW1vdmUgdGhlIGRldl93YXJuKCkuCj4gPiAKPiA+IEkgYWRkZWQgdGhpcyB3YXJuaW5nIGluIHYy IGJlY2F1c2UgTWFyYyB3YW50ZWQgaXQuCj4gPiAKPiA+IFNob3VsZCBJIChhZ2FpbikgcmVtb3Zl IGl0IGluIHYzPwo+IAo+IE5vLCBJIGFza2VkIGEgcXVlc3Rpb24gYW5kIGdhdmUgYW4gb3Bpbmlv biwgSSBhcHByZWNpYXRlIE1hcmMncyBjb25jZXJuCj4gc28gbGVhdmUgaXQgKGllIG5vdCBldmVy eW9uZSBydW5uaW5nIGEgbmV3IGtlcm5lbCB3aXRoIG5ldyB3YXJuaW5ncyBvbgo+IGV4aXN0aW5n IGZpcm13YXJlIHdvdWxkIGJlIGhhcHB5IC0gbWF5YmUgaXQgaXMgYSBnb29kIHdheSBvZiBmb3Jj aW5nIGEKPiBmaXJtd2FyZSB1cGdyYWRlLCB5b3Ugd2lsbCB0ZWxsIG1lKS4KCk15IGNvbmNlcm4g aXMgdGhhdCBzaG9ydCBvZiBiZWluZyBhYmxlIHRvIG1hc2sgdGhlc2UgaW50ZXJydXB0cywgaXQg aXMKcG9zc2libGUgZm9yIGEgZGV2aWNlIHRvIGFzc2VydCBhbiBpbnRlcnJ1cHQgdGhhdCBubyBk cml2ZXIgaGFuZGxlcywKYW5kIHRoZSBrZXJuZWwgc3B1cmlvdXMgaW50ZXJydXB0IGRldGVjdG9y IHdvbid0IGJlIGFibGUgdG8gc2h1dCBpdAp1cC4gQXQgdGhpcyBzdGFnZSwgdGhlIG1hY2hpbmUg aXMgdG90YWxseSBkZWFkIChzY3JlYW1pbmcgKmxldmVsKgppbnRlcnJ1cHQpLgoKVGhlIGRldl93 YXJuKCkgY291bGQgdG9uZWQgZG93biB0byBhIGRldl93YXJuX29uY2UoKSB0aG91Z2guCgoJTS4K Ci0tIApXaXRob3V0IGRldmlhdGlvbiBmcm9tIHRoZSBub3JtLCBwcm9ncmVzcyBpcyBub3QgcG9z c2libGUuCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwps aW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJh ZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51 eC1hcm0ta2VybmVsCg==