From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: "Zbigniew Kempczyński" <zbigniew.kempczynski@intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] i915/api_intel_bb: Correct size for munmap
Date: Wed, 02 Feb 2022 08:08:39 -0800 [thread overview]
Message-ID: <87a6f945fc.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <20220202062527.8284-1-zbigniew.kempczynski@intel.com>
On Tue, 01 Feb 2022 22:25:27 -0800, Zbigniew Kempczyński wrote:
>
> If we don't release the entirety of the mmap we create, it still holds a
> reference to the fd/object.
>
> v2: changed to intel_buf_size() (ZK)
Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
> Signed-off-by: Chris Wilson <chris.p.wilson@intel.com>
> Cc: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
> ---
> tests/i915/api_intel_bb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/i915/api_intel_bb.c b/tests/i915/api_intel_bb.c
> index 5c996f644..e37472fb4 100644
> --- a/tests/i915/api_intel_bb.c
> +++ b/tests/i915/api_intel_bb.c
> @@ -1169,7 +1169,7 @@ static void delta_check(struct buf_ops *bops)
> ptr = gem_mmap__device_coherent(i915, buf->handle, 0,
> intel_buf_size(buf), PROT_READ);
> val = ptr[0x2000 / sizeof(uint32_t)];
> - gem_munmap(ptr, ibb->size);
> + gem_munmap(ptr, intel_buf_size(buf));
next prev parent reply other threads:[~2022-02-02 16:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-02 6:25 [igt-dev] [PATCH i-g-t] i915/api_intel_bb: Correct size for munmap Zbigniew Kempczyński
2022-02-02 7:10 ` [igt-dev] ✓ Fi.CI.BAT: success for i915/api_intel_bb: Correct size for munmap (rev3) Patchwork
2022-02-02 8:07 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2022-02-02 16:08 ` Dixit, Ashutosh [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-01-31 16:48 [igt-dev] [PATCH i-g-t] i915/api_intel_bb: Correct size for munmap Zbigniew Kempczyński
2022-02-01 21:53 ` Dixit, Ashutosh
2022-02-02 6:21 ` Zbigniew Kempczyński
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a6f945fc.wl-ashutosh.dixit@intel.com \
--to=ashutosh.dixit@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=zbigniew.kempczynski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.