From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0D76BC433F5 for ; Thu, 25 Nov 2021 14:05:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=XIGLVDtGO4rC3Cpi6qeCI7k1KVJUlS2ydqwcq+DG92U=; b=J+ucHWPP1C1CYQ mScQA4Fn2ExO4T6oYgrA/MpB7+sC06VXZwJeJz4WjkyNkxCXFH561qMCrfv6pqO3gjYmZz+VV/ouT Ql6sHhWWyNhPkt//hYLW+BbCnyP58d9nZ2dJ26gIoVo7r95sKL8vX9wTagOvW/50U6COdt69/czqx n9NwEIrfbcAmjSUcQ7MepvDsMts/hxknIy+EhHCUf1Q07oM901YNJzlTXH+XRNCLsapzTTEr9vCUG jKU9nc0ZZ/nX4AABlbLAn0KpL67E1r1Wu0iXaBk0MxnL+vy98XcNK91EV+wKN1FO4uUByCVx7oTfx aKSUV2UW+dVbR59MsmSQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mqFLi-007ktO-KK; Thu, 25 Nov 2021 14:03:42 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mqFLf-007kt5-IS for linux-arm-kernel@lists.infradead.org; Thu, 25 Nov 2021 14:03:40 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2F59E60FD8; Thu, 25 Nov 2021 14:03:39 +0000 (UTC) Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mqFLc-007oyD-VE; Thu, 25 Nov 2021 14:03:37 +0000 Date: Thu, 25 Nov 2021 14:03:36 +0000 Message-ID: <87a6hscoxz.wl-maz@kernel.org> From: Marc Zyngier To: Pali =?UTF-8?B?Um9ow6Fy?= Cc: Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Thomas Gleixner , Marek =?UTF-8?B?QmVow7pu?= , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] irqchip/armada-370-xp: Fix support for Multi-MSI interrupts In-Reply-To: <20211125130057.26705-2-pali@kernel.org> References: <20211125130057.26705-1-pali@kernel.org> <20211125130057.26705-2-pali@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: pali@kernel.org, andrew@lunn.ch, gregory.clement@bootlin.com, sebastian.hesselbarth@gmail.com, tglx@linutronix.de, kabel@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211125_060339_693589_92745818 X-CRM114-Status: GOOD ( 23.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVGh1LCAyNSBOb3YgMjAyMSAxMzowMDo1NyArMDAwMCwKUGFsaSBSb2jDoXIgPHBhbGlAa2Vy bmVsLm9yZz4gd3JvdGU6Cj4gCj4gaXJxLWFybWFkYS0zNzAteHAgZHJpdmVyIGFscmVhZHkgc2V0 cyBNU0lfRkxBR19NVUxUSV9QQ0lfTVNJIGZsYWcgaW50bwo+IG1zaV9kb21haW5faW5mbyBzdHJ1 Y3R1cmUuIEJ1dCBhbGxvY2F0ZWQgaW50ZXJydXB0IG51bWJlcnMgZm9yIE11bHRpLU1TSQo+IG5l ZWRzIHRvIGJlIHByb3Blcmx5IGFsaWduZWQgb3RoZXJ3aXNlIGRldmljZXMgc2VuZCBNU0kgaW50 ZXJydXB0IHdpdGgKPiB3cm9uZyBudW1iZXIuCj4gCj4gRml4IHRoaXMgaXNzdWUgYnkgdXNpbmcg ZnVuY3Rpb24gYml0bWFwX2ZpbmRfZnJlZV9yZWdpb24oKSBpbnN0ZWFkIG9mCj4gYml0bWFwX2Zp bmRfbmV4dF96ZXJvX2FyZWEoKSB0byBhbGxvY2F0ZSBhbGlnbmVkIGludGVycnVwdCBudW1iZXJz Lgo+IAo+IFNpZ25lZC1vZmYtYnk6IFBhbGkgUm9ow6FyIDxwYWxpQGtlcm5lbC5vcmc+Cj4gRml4 ZXM6IGE3MWI5NDEyYzkwYyAoImlycWNoaXAvYXJtYWRhLTM3MC14cDogQWxsb3cgYWxsb2NhdGlv biBvZiBtdWx0aXBsZSBNU0lzIikKPiBDYzogc3RhYmxlQHZnZXIua2VybmVsLm9yZwo+IC0tLQo+ ICBkcml2ZXJzL2lycWNoaXAvaXJxLWFybWFkYS0zNzAteHAuYyB8IDE0ICsrKysrLS0tLS0tLS0t Cj4gIDEgZmlsZSBjaGFuZ2VkLCA1IGluc2VydGlvbnMoKyksIDkgZGVsZXRpb25zKC0pCj4gCj4g ZGlmZiAtLWdpdCBhL2RyaXZlcnMvaXJxY2hpcC9pcnEtYXJtYWRhLTM3MC14cC5jIGIvZHJpdmVy cy9pcnFjaGlwL2lycS1hcm1hZGEtMzcwLXhwLmMKPiBpbmRleCA0MWFkNzQ1Y2YzNDMuLjViOGQ1 NzFjMDQxZCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2lycWNoaXAvaXJxLWFybWFkYS0zNzAteHAu Ywo+ICsrKyBiL2RyaXZlcnMvaXJxY2hpcC9pcnEtYXJtYWRhLTM3MC14cC5jCj4gQEAgLTIzMiwx NiArMjMyLDEyIEBAIHN0YXRpYyBpbnQgYXJtYWRhXzM3MF94cF9tc2lfYWxsb2Moc3RydWN0IGly cV9kb21haW4gKmRvbWFpbiwgdW5zaWduZWQgaW50IHZpcnEsCj4gIAlpbnQgaHdpcnEsIGk7Cj4g IAo+ICAJbXV0ZXhfbG9jaygmbXNpX3VzZWRfbG9jayk7Cj4gKwlod2lycSA9IGJpdG1hcF9maW5k X2ZyZWVfcmVnaW9uKG1zaV91c2VkLCBQQ0lfTVNJX0RPT1JCRUxMX05SLAo+ICsJCQkJCW9yZGVy X2Jhc2VfMihucl9pcnFzKSk7Cj4gKwltdXRleF91bmxvY2soJm1zaV91c2VkX2xvY2spOwo+ICAK PiAtCWh3aXJxID0gYml0bWFwX2ZpbmRfbmV4dF96ZXJvX2FyZWEobXNpX3VzZWQsIFBDSV9NU0lf RE9PUkJFTExfTlIsCj4gLQkJCQkJICAgMCwgbnJfaXJxcywgMCk7Cj4gLQlpZiAoaHdpcnEgPj0g UENJX01TSV9ET09SQkVMTF9OUikgewo+IC0JCW11dGV4X3VubG9jaygmbXNpX3VzZWRfbG9jayk7 Cj4gKwlpZiAoaHdpcnEgPCAwKQo+ICAJCXJldHVybiAtRU5PU1BDOwo+IC0JfQo+IC0KPiAtCWJp dG1hcF9zZXQobXNpX3VzZWQsIGh3aXJxLCBucl9pcnFzKTsKPiAtCW11dGV4X3VubG9jaygmbXNp X3VzZWRfbG9jayk7Cj4gIAo+ICAJZm9yIChpID0gMDsgaSA8IG5yX2lycXM7IGkrKykgewo+ICAJ CWlycV9kb21haW5fc2V0X2luZm8oZG9tYWluLCB2aXJxICsgaSwgaHdpcnEgKyBpLAo+IEBAIC0y NTksNyArMjU1LDcgQEAgc3RhdGljIHZvaWQgYXJtYWRhXzM3MF94cF9tc2lfZnJlZShzdHJ1Y3Qg aXJxX2RvbWFpbiAqZG9tYWluLAo+ICAJc3RydWN0IGlycV9kYXRhICpkID0gaXJxX2RvbWFpbl9n ZXRfaXJxX2RhdGEoZG9tYWluLCB2aXJxKTsKPiAgCj4gIAltdXRleF9sb2NrKCZtc2lfdXNlZF9s b2NrKTsKPiAtCWJpdG1hcF9jbGVhcihtc2lfdXNlZCwgZC0+aHdpcnEsIG5yX2lycXMpOwo+ICsJ Yml0bWFwX3JlbGVhc2VfcmVnaW9uKG1zaV91c2VkLCBkLT5od2lycSwgb3JkZXJfYmFzZV8yKG5y X2lycXMpKTsKPiAgCW11dGV4X3VubG9jaygmbXNpX3VzZWRfbG9jayk7Cj4gIH0KPiAgCj4gLS0g Cj4gMi4yMC4xCj4gCj4gCgpBY2tlZC1ieTogTWFyYyBaeW5naWVyIDxtYXpAa2VybmVsLm9yZz4K CglNLgoKLS0gCldpdGhvdXQgZGV2aWF0aW9uIGZyb20gdGhlIG5vcm0sIHByb2dyZXNzIGlzIG5v dCBwb3NzaWJsZS4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMu aW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2xpbnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FDFEC433F5 for ; Thu, 25 Nov 2021 14:05:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1355553AbhKYOIv convert rfc822-to-8bit (ORCPT ); Thu, 25 Nov 2021 09:08:51 -0500 Received: from mail.kernel.org ([198.145.29.99]:37334 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239231AbhKYOGu (ORCPT ); Thu, 25 Nov 2021 09:06:50 -0500 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2F59E60FD8; Thu, 25 Nov 2021 14:03:39 +0000 (UTC) Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mqFLc-007oyD-VE; Thu, 25 Nov 2021 14:03:37 +0000 Date: Thu, 25 Nov 2021 14:03:36 +0000 Message-ID: <87a6hscoxz.wl-maz@kernel.org> From: Marc Zyngier To: Pali =?UTF-8?B?Um9ow6Fy?= Cc: Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Thomas Gleixner , Marek =?UTF-8?B?QmVow7pu?= , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] irqchip/armada-370-xp: Fix support for Multi-MSI interrupts In-Reply-To: <20211125130057.26705-2-pali@kernel.org> References: <20211125130057.26705-1-pali@kernel.org> <20211125130057.26705-2-pali@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: pali@kernel.org, andrew@lunn.ch, gregory.clement@bootlin.com, sebastian.hesselbarth@gmail.com, tglx@linutronix.de, kabel@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 25 Nov 2021 13:00:57 +0000, Pali Rohár wrote: > > irq-armada-370-xp driver already sets MSI_FLAG_MULTI_PCI_MSI flag into > msi_domain_info structure. But allocated interrupt numbers for Multi-MSI > needs to be properly aligned otherwise devices send MSI interrupt with > wrong number. > > Fix this issue by using function bitmap_find_free_region() instead of > bitmap_find_next_zero_area() to allocate aligned interrupt numbers. > > Signed-off-by: Pali Rohár > Fixes: a71b9412c90c ("irqchip/armada-370-xp: Allow allocation of multiple MSIs") > Cc: stable@vger.kernel.org > --- > drivers/irqchip/irq-armada-370-xp.c | 14 +++++--------- > 1 file changed, 5 insertions(+), 9 deletions(-) > > diff --git a/drivers/irqchip/irq-armada-370-xp.c b/drivers/irqchip/irq-armada-370-xp.c > index 41ad745cf343..5b8d571c041d 100644 > --- a/drivers/irqchip/irq-armada-370-xp.c > +++ b/drivers/irqchip/irq-armada-370-xp.c > @@ -232,16 +232,12 @@ static int armada_370_xp_msi_alloc(struct irq_domain *domain, unsigned int virq, > int hwirq, i; > > mutex_lock(&msi_used_lock); > + hwirq = bitmap_find_free_region(msi_used, PCI_MSI_DOORBELL_NR, > + order_base_2(nr_irqs)); > + mutex_unlock(&msi_used_lock); > > - hwirq = bitmap_find_next_zero_area(msi_used, PCI_MSI_DOORBELL_NR, > - 0, nr_irqs, 0); > - if (hwirq >= PCI_MSI_DOORBELL_NR) { > - mutex_unlock(&msi_used_lock); > + if (hwirq < 0) > return -ENOSPC; > - } > - > - bitmap_set(msi_used, hwirq, nr_irqs); > - mutex_unlock(&msi_used_lock); > > for (i = 0; i < nr_irqs; i++) { > irq_domain_set_info(domain, virq + i, hwirq + i, > @@ -259,7 +255,7 @@ static void armada_370_xp_msi_free(struct irq_domain *domain, > struct irq_data *d = irq_domain_get_irq_data(domain, virq); > > mutex_lock(&msi_used_lock); > - bitmap_clear(msi_used, d->hwirq, nr_irqs); > + bitmap_release_region(msi_used, d->hwirq, order_base_2(nr_irqs)); > mutex_unlock(&msi_used_lock); > } > > -- > 2.20.1 > > Acked-by: Marc Zyngier M. -- Without deviation from the norm, progress is not possible.