From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: Petri Latvala <petri.latvala@intel.com>
Cc: "Teres Alexis, Alan Previn" <alan.previn.teres.alexis@intel.com>,
"igt-dev@lists.freedesktop.org" <igt-dev@lists.freedesktop.org>
Subject: Re: [igt-dev] [PATCH i-g-t v9 01/16] Add PXP UAPI support in i915_drm.h
Date: Mon, 06 Sep 2021 14:23:02 -0700 [thread overview]
Message-ID: <87a6kpl7pl.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <YTWzdjyUV49hy5/f@platvala-desk.ger.corp.intel.com>
On Sun, 05 Sep 2021 23:21:42 -0700, Petri Latvala wrote:
>
> On Sat, Sep 04, 2021 at 12:11:47AM +0300, Teres Alexis, Alan Previn wrote:
> > oops - my bad - didnt realize we had that - will do.
> >
> > While on this, would it make sense to permanently include
> > lib/i915/i915_drm_local.h from include/drm- uapi/i915_drm.h (but latter
> > would always remain empty on upstream)?. This way, when kernel support
> > is added for UAPI changes, we move the definitions across but dont add
> > and need remove the '#include "lib/i915/i915_drm_local.h" from the
> > other source files (requiring another change)?
>
> It would, but it's impossible. include/drm-uapi/i915_drm.h is supposed
> to be a pristine unchanged drop from the kernel.
>
> The other way around might work but looks more odd from the .c side.
But each source file does not have to include i915_drm_local.h since it is
included in igt_gt.h. So as long as igt_gt.h is included (which should be,
directly or indirectly) i915_drm_local.h is automatically included and does
not have to be explicitly included.
next prev parent reply other threads:[~2021-09-06 21:23 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-02 17:30 [igt-dev] [PATCH i-g-t v9 00/16] Introduce PXP Test Alan Previn
2021-09-02 17:30 ` [igt-dev] [PATCH i-g-t v9 01/16] Add PXP UAPI support in i915_drm.h Alan Previn
2021-09-03 10:31 ` Petri Latvala
2021-09-03 21:11 ` Teres Alexis, Alan Previn
2021-09-06 6:21 ` Petri Latvala
2021-09-06 21:23 ` Dixit, Ashutosh [this message]
2021-09-02 17:30 ` [igt-dev] [PATCH i-g-t v9 02/16] Add basic PXP testing of buffer and context alloc Alan Previn
2021-09-02 17:30 ` [igt-dev] [PATCH i-g-t v9 03/16] Perform a regular 3d copy as a control checkpoint Alan Previn
2021-09-02 17:30 ` [igt-dev] [PATCH i-g-t v9 04/16] Add PXP attribute support in batchbuffer and buffer_ops libs Alan Previn
2021-09-02 17:30 ` [igt-dev] [PATCH i-g-t v9 05/16] Add MI_SET_APPID instruction definition Alan Previn
2021-09-02 17:30 ` [igt-dev] [PATCH i-g-t v9 06/16] Enable protected session cmd in gen12_render_copyfunc Alan Previn
2021-09-02 17:30 ` [igt-dev] [PATCH i-g-t v9 07/16] Add subtest to copy raw source to protected dest Alan Previn
2021-09-02 17:30 ` [igt-dev] [PATCH i-g-t v9 08/16] Add test where both src and dest are protected Alan Previn
2021-09-02 17:30 ` [igt-dev] [PATCH i-g-t v9 09/16] Verify PXP teardown occurred through suspend-resume Alan Previn
2021-09-03 16:47 ` Rodrigo Vivi
2021-09-03 21:00 ` Teres Alexis, Alan Previn
2021-09-02 17:30 ` [igt-dev] [PATCH i-g-t v9 10/16] Verify execbuf fails with stale PXP context after teardown Alan Previn
2021-09-10 18:53 ` Rodrigo Vivi
2021-09-10 19:04 ` Teres Alexis, Alan Previn
2021-09-10 19:12 ` Rodrigo Vivi
2021-09-10 21:23 ` Teres Alexis, Alan Previn
2021-09-02 17:30 ` [igt-dev] [PATCH i-g-t v9 11/16] Verify execbuf fails with stale PXP buffer " Alan Previn
2021-09-10 19:09 ` Rodrigo Vivi
2021-09-10 19:11 ` Rodrigo Vivi
2021-09-02 17:30 ` [igt-dev] [PATCH i-g-t v9 12/16] Verify execbuf ok with stale PXP buf in opt-out use Alan Previn
2021-09-10 19:12 ` Rodrigo Vivi
2021-09-02 17:30 ` [igt-dev] [PATCH i-g-t v9 13/16] Verify execution behavior with stale PXP assets through suspend-resume Alan Previn
2021-09-02 17:30 ` [igt-dev] [PATCH i-g-t v9 14/16] Ensure RESET_STATS reports invalidated protected contexts Alan Previn
2021-09-02 17:30 ` [igt-dev] [PATCH i-g-t v9 15/16] Verify protected surfaces are dma buffer sharable Alan Previn
2021-09-02 17:30 ` [igt-dev] [PATCH i-g-t v9 16/16] tests/i915_pxp: CRC validation for display tests Alan Previn
2021-09-02 18:19 ` [igt-dev] ✓ Fi.CI.BAT: success for Introduce PXP Test (rev9) Patchwork
2021-09-02 22:32 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a6kpl7pl.wl-ashutosh.dixit@intel.com \
--to=ashutosh.dixit@intel.com \
--cc=alan.previn.teres.alexis@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=petri.latvala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.