From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41E40C4338F for ; Wed, 28 Jul 2021 08:19:05 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F1F1660BD3 for ; Wed, 28 Jul 2021 08:19:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org F1F1660BD3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MkXN2iAJFAeOREdaRe5v3UOrXAr2zcouDhWnF0vUcHE=; b=cFqulphX2lTXhr No9bH2d/cVjlAAIsByAiEm4hNvlVbzeXmv+ogAgBOnXRslciRdahpIE4GYaQ5YIqSns6lautMXFTj rBg0mhAo2F4mozB553EXRIq5luEqGgzHWxSNIxI5Kgi/3B0toMYEF61AAz3wLdIwuY2xlLloKtXhn SUIRxRbYCT88au2CbT6Jhy9UrnftcDByVVuOgpJFymszJZwVf+mcXvppQm4XsnRf64yUcEvLol5ba fk5SRWPISxMZQ+xbOdebf/K1uMsGD0suxBH0Ycp1qy1nORHkDgZQcacBz8hAZjeLO1A7KOWsS5Lne fpIsjucs5iEWp0m95L3w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m8ekO-00HVyv-62; Wed, 28 Jul 2021 08:17:00 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m8ekK-00HVyE-1H for linux-arm-kernel@lists.infradead.org; Wed, 28 Jul 2021 08:16:57 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9ADA860BD3; Wed, 28 Jul 2021 08:16:55 +0000 (UTC) Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1m8ekH-001Txx-Hj; Wed, 28 Jul 2021 09:16:53 +0100 Date: Wed, 28 Jul 2021 09:16:52 +0100 Message-ID: <87a6m6etu3.wl-maz@kernel.org> From: Marc Zyngier To: Linus Walleij Cc: Linux ARM , Imre Kaloz , Krzysztof Halasa Subject: Re: [PATCH v2] ARM: dts: ixp4xx: Add Arcom Vulcan device tree In-Reply-To: References: <20210726122458.2579760-1-linus.walleij@linaro.org> <87bl6negvk.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: linus.walleij@linaro.org, linux-arm-kernel@lists.infradead.org, kaloz@openwrt.org, khalasa@piap.pl X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210728_011656_160555_6FE9D047 X-CRM114-Status: GOOD ( 25.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 28 Jul 2021 00:45:19 +0100, Linus Walleij wrote: > > On Tue, Jul 27, 2021 at 8:44 PM Marc Zyngier wrote: > > > Thanks a lot for doing this. I'm slowly getting this box up and > > running again, and noticed a couple of issues with the DT, see below. > > Hey :) > > Do you want me to do my best to fix it up or will you send me > a patch on top I can just fold in to get it the way you want it? Here's the state of my tree (everything else is just kernel config). Just fold it into your current patch it you're happy with it. I'll keep hacking at it when I have some spare time. Thanks, M. diff --git a/arch/arm/boot/dts/intel-ixp42x-arcom-vulcan.dts b/arch/arm/boot/dts/intel-ixp42x-arcom-vulcan.dts index 16806deab559..f8a29a88f0c5 100644 --- a/arch/arm/boot/dts/intel-ixp42x-arcom-vulcan.dts +++ b/arch/arm/boot/dts/intel-ixp42x-arcom-vulcan.dts @@ -17,7 +17,6 @@ / { #size-cells = <1>; memory@0 { - /* CHECKME: 64 MB SDRAM - based on dma zone in boardfile */ device_type = "memory"; reg = <0x00000000 0x4000000>; }; @@ -44,7 +59,11 @@ flash@0,0 { bank-width = <2>; /* * 32 MB of Flash in 0x20000 byte blocks - * mapped in at CS0 and CS1 + * mapped in at CS0 and CS1. + * + * The documentation mentions the existence + * of a 16MB version, which we conveniently + * ignore. Shout if you own one! */ reg = <0 0x00000000 0x2000000>; @@ -55,15 +74,14 @@ flash@0,0 { partitions { compatible = "redboot-fis"; - /* CHECKME: FIS eraseblock at 0x1fe0000? */ - fis-index-block = <0xff>; + fis-index-block = <0x1ff>; }; }; sram@2,0 { /* 256 KB SDRAM memory at CS2 */ compatible = "shared-dma-pool"; device_type = "memory"; - reg = <1 0x00000000 0x40000>; + reg = <2 0x00000000 0x40000>; no-map; /* Expansion bus settings */ intel,ixp4xx-eb-t3 = <1>; @@ -117,20 +135,18 @@ pci@c0000000 { * * We have 2 slots (IDSEL) 1 and 2 with one dedicated interrupt * per slot. This interrupt is shared (OR:ed) by all four pins. - * - * CHECKME: is the interrupt setup on Vulcan really this cheap? */ interrupt-map = - /* IDSEL 1 */ - <0x0800 0 0 1 &gpio0 2 3>, /* INT A on slot 1 is irq 2 */ - <0x0800 0 0 2 &gpio0 2 3>, /* INT B on slot 1 is irq 2 */ - <0x0800 0 0 3 &gpio0 2 3>, /* INT C on slot 1 is irq 2 */ - <0x0800 0 0 4 &gpio0 2 3>, /* INT D on slot 1 is irq 2 */ - /* IDSEL 2 */ - <0x1000 0 0 1 &gpio0 3 3>, /* INT A on slot 2 is irq 3 */ - <0x1000 0 0 2 &gpio0 3 3>, /* INT B on slot 2 is irq 3 */ - <0x1000 0 0 3 &gpio0 3 3>, /* INT C on slot 2 is irq 3 */ - <0x1000 0 0 4 &gpio0 3 3>; /* INT D on slot 2 is irq 3 */ + /* IDSEL 1, all INTx are mapped to irq 2 */ + <0x0800 0 0 1 &gpio0 2 IRQ_TYPE_LEVEL_LOW>, + <0x0800 0 0 2 &gpio0 2 IRQ_TYPE_LEVEL_LOW>, + <0x0800 0 0 3 &gpio0 2 IRQ_TYPE_LEVEL_LOW>, + <0x0800 0 0 4 &gpio0 2 IRQ_TYPE_LEVEL_LOW>, + /* IDSEL 2, all INTx are mapped to irq 3 */ + <0x1000 0 0 1 &gpio0 3 IRQ_TYPE_LEVEL_LOW>, + <0x1000 0 0 2 &gpio0 3 IRQ_TYPE_LEVEL_LOW>, + <0x1000 0 0 3 &gpio0 3 IRQ_TYPE_LEVEL_LOW>, + <0x1000 0 0 4 &gpio0 3 IRQ_TYPE_LEVEL_LOW>; }; /* EthB */ -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel