From: "Alex Bennée" <alex.bennee@linaro.org>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: peter.maydell@linaro.org, mark.cave-ayland@ilande.co.uk,
qemu-devel@nongnu.org, f4bug@amsat.org
Subject: Re: [PATCH for-6.1 v5 12/15] accel/tcg: Move breakpoint recognition outside translation
Date: Tue, 20 Jul 2021 14:16:45 +0100 [thread overview]
Message-ID: <87a6mhm8f8.fsf@linaro.org> (raw)
In-Reply-To: <20210720011800.483966-13-richard.henderson@linaro.org>
Richard Henderson <richard.henderson@linaro.org> writes:
> Trigger breakpoints before beginning translation of a TB
> that would begin with a BP. Thus we never generate code
> for the BP at all.
>
> Single-step instructions within a page containing a BP so
> that we are sure to check each insn for the BP as above.
>
> We no longer need to flush any TBs when changing BPs.
>
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/286
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/404
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/489
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Nice ;-)
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
--
Alex Bennée
next prev parent reply other threads:[~2021-07-20 13:24 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-20 1:17 [PATCH for-6.1 v5 00/15] tcg: breakpoint reorg Richard Henderson
2021-07-20 1:17 ` [PATCH for-6.1 v5 01/15] accel/tcg: Reduce CF_COUNT_MASK to match TCG_MAX_INSNS Richard Henderson
2021-07-20 1:17 ` [PATCH for-6.1 v5 02/15] accel/tcg: Move curr_cflags into cpu-exec.c Richard Henderson
2021-07-20 1:17 ` [PATCH for-6.1 v5 03/15] target/alpha: Drop goto_tb path in gen_call_pal Richard Henderson
2021-07-20 11:55 ` Philippe Mathieu-Daudé
2021-07-20 1:17 ` [PATCH for-6.1 v5 04/15] accel/tcg: Add CF_NO_GOTO_TB and CF_NO_GOTO_PTR Richard Henderson
2021-07-20 1:17 ` [PATCH for-6.1 v5 05/15] accel/tcg: Drop CF_NO_GOTO_PTR from -d nochain Richard Henderson
2021-07-20 1:17 ` [PATCH for-6.1 v5 06/15] accel/tcg: Handle -singlestep in curr_cflags Richard Henderson
2021-07-20 1:17 ` [PATCH for-6.1 v5 07/15] accel/tcg: Use CF_NO_GOTO_{TB, PTR} in cpu_exec_step_atomic Richard Henderson
2021-07-20 1:17 ` [PATCH for-6.1 v5 08/15] hw/core: Introduce TCGCPUOps.debug_check_breakpoint Richard Henderson
2021-07-20 11:52 ` Philippe Mathieu-Daudé
2021-07-20 1:17 ` [PATCH for-6.1 v5 09/15] target/arm: Implement debug_check_breakpoint Richard Henderson
2021-07-20 11:52 ` Philippe Mathieu-Daudé
2021-07-20 1:17 ` [PATCH for-6.1 v5 10/15] target/i386: " Richard Henderson
2021-07-20 13:06 ` Alex Bennée
2021-07-20 1:17 ` [PATCH for-6.1 v5 11/15] accel/tcg: Merge tb_find into its only caller Richard Henderson
2021-07-20 13:15 ` Alex Bennée
2021-07-20 1:17 ` [PATCH for-6.1 v5 12/15] accel/tcg: Move breakpoint recognition outside translation Richard Henderson
2021-07-20 13:16 ` Alex Bennée [this message]
2021-07-20 16:12 ` Alex Bennée
2021-07-20 1:17 ` [PATCH for-6.1 v5 13/15] accel/tcg: Remove TranslatorOps.breakpoint_check Richard Henderson
2021-07-20 1:17 ` [PATCH for-6.1 v5 14/15] accel/tcg: Hoist tb_cflags to a local in translator_loop Richard Henderson
2021-07-20 11:54 ` Philippe Mathieu-Daudé
2021-07-20 1:18 ` [PATCH for-6.1 v5 15/15] accel/tcg: Record singlestep_enabled in tb->cflags Richard Henderson
2021-07-20 2:04 ` [PATCH for-6.1 v5 00/15] tcg: breakpoint reorg Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a6mhm8f8.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=f4bug@amsat.org \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.