From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9527C07E96 for ; Thu, 15 Jul 2021 05:50:06 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4FFB1611C0 for ; Thu, 15 Jul 2021 05:50:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4FFB1611C0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:58208 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m3uG5-0002Ae-BF for qemu-devel@archiver.kernel.org; Thu, 15 Jul 2021 01:50:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48294) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m3uFT-0001LO-I2 for qemu-devel@nongnu.org; Thu, 15 Jul 2021 01:49:27 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:35215) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m3uFP-0004CG-Bg for qemu-devel@nongnu.org; Thu, 15 Jul 2021 01:49:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626328161; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ipA76JNxdxLDlSTCMwPxBIkeLK7x4efnQus0oNxIGW0=; b=KCZvx566I8ILL8J0N4xL/1cPmco9XNkkBfV6mKz7jCJPVYBT/5sQkfpHjAgvQqqyCF38Sz gAbLlinfICmzdCJsZvpBLVs9753XaDJ6OcGRjr1uydppNhDZX7oanz+Ht00nJkRpKsxxD5 m1lwHZsH5VzTALD7MfOahqpRyno5R/o= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-178-y2nLD1pHMMycJJkp57J-zA-1; Thu, 15 Jul 2021 01:49:20 -0400 X-MC-Unique: y2nLD1pHMMycJJkp57J-zA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 080C880431B; Thu, 15 Jul 2021 05:49:19 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-112-81.ams2.redhat.com [10.36.112.81]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 02E9E5C232; Thu, 15 Jul 2021 05:49:15 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 8D8B1113865F; Thu, 15 Jul 2021 07:49:13 +0200 (CEST) From: Markus Armbruster To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Subject: Re: [PATCH v3 0/9] tests: Add test cases for TPM 1.2 ACPI tables References: <20210712150949.165725-1-stefanb@linux.vnet.ibm.com> <36bcf543-0b56-7e2f-26e7-648ca3cf58dd@linux.ibm.com> <87a6mpez2b.fsf@dusky.pond.sub.org> <97703096-ad9d-f676-ffcb-46ad4bf340c2@redhat.com> Date: Thu, 15 Jul 2021 07:49:13 +0200 In-Reply-To: <97703096-ad9d-f676-ffcb-46ad4bf340c2@redhat.com> ("Philippe =?utf-8?Q?Mathieu-Daud=C3=A9=22's?= message of "Wed, 14 Jul 2021 22:16:03 +0200") Message-ID: <87a6modt46.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=armbru@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=170.10.133.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.699, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , Stefan Berger , qemu-devel@nongnu.org, Paolo Bonzini , marcandre.lureau@redhat.com, Stefan Berger Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Philippe Mathieu-Daud=C3=A9 writes: > On 7/14/21 4:43 PM, Markus Armbruster wrote: >> Philippe Mathieu-Daud=C3=A9 writes: >>=20 >>> +Markus [...] >>> IMO the "right" solution is to check via QMP if TMP is supported >>> or not. This is now doable since commit caff255a546 ("tpm: Return >>> QMP error when TPM is disabled in build"). >>> >>> Long term we'd like to decouple the tests/ build from the various >>> QEMU configurations, and build the tests once. >>=20 >> This argument applies only to macros from target-specific headers like >> $TARGET-config-target.h, not to macros from config-host.h. #ifdef >> CONFIG_TPM should be fine, shouldn't it? > > Some definitions depend on the host (OS, libraries installed, ...), > others depend on the --enable/--disable ./configure options. > > IMO it would be nice if we could get qtests independent of the latter. Why? > I suppose config-host.h holds both kinds. Yes.