From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB4EFC11F68 for ; Fri, 2 Jul 2021 10:36:32 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 58D7761206 for ; Fri, 2 Jul 2021 10:36:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 58D7761206 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:46494 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lzGX9-0006WN-JL for qemu-devel@archiver.kernel.org; Fri, 02 Jul 2021 06:36:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57706) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lzGVH-0004kR-Ee for qemu-devel@nongnu.org; Fri, 02 Jul 2021 06:34:35 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:27930) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lzGVD-0001UN-Cl for qemu-devel@nongnu.org; Fri, 02 Jul 2021 06:34:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1625222070; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=y8CNIkOogZE5KM5ERH5WGEw12t6pJeMBCRNPjvkYJfQ=; b=CucUAZQPrvF7QwiEBKf/K9n1vTpe296q1DD0ZNu3tFNvR5NleUHD+U7rIhQXblJtWr6xiR mscGlzMQaURpI7reXdWUMTDh9Yd4NfvU72APieaJGo27VoCbyh1DZ88mcxB3aLZ6AkzApQ EHnyNvXk35Ul6SXll8Lcu8iADZwOYU8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-497-yje1l0KIM9eh6-x0nfbyqw-1; Fri, 02 Jul 2021 06:34:28 -0400 X-MC-Unique: yje1l0KIM9eh6-x0nfbyqw-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E18F21023F46; Fri, 2 Jul 2021 10:34:26 +0000 (UTC) Received: from localhost (ovpn-112-239.ams2.redhat.com [10.36.112.239]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A049D1ABD1; Fri, 2 Jul 2021 10:34:22 +0000 (UTC) From: Cornelia Huck To: Ilya Leoshkevich , Richard Henderson , David Hildenbrand , Laurent Vivier Subject: Re: [PATCH v5 0/2] target/s390x: Fix SIGILL/SIGFPE/SIGTRAP psw.addr reporting In-Reply-To: <20210623023250.3667563-1-iii@linux.ibm.com> Organization: Red Hat GmbH References: <20210623023250.3667563-1-iii@linux.ibm.com> User-Agent: Notmuch/0.32.1 (https://notmuchmail.org) Date: Fri, 02 Jul 2021 12:34:21 +0200 Message-ID: <87a6n5j976.fsf@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=cohuck@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Received-SPF: pass client-ip=216.205.24.124; envelope-from=cohuck@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.402, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "jonathan . albrecht" , Ilya Leoshkevich , Ulrich Weigand , qemu-devel@nongnu.org, Christian Borntraeger , qemu-s390x@nongnu.org, Andreas Krebbel Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, Jun 23 2021, Ilya Leoshkevich wrote: > qemu-s390x puts a wrong value into SIGILL's siginfo_t's psw.addr: it > should be a pointer to the instruction following the illegal > instruction, but at the moment it is a pointer to the illegal > instruction itself. This breaks OpenJDK, which relies on this value. > A similar problem exists for SIGFPE and SIGTRAP. > > Patch 1 fixes the issue, patch 2 adds a test. > > v1: https://lists.nongnu.org/archive/html/qemu-devel/2021-05/msg06592.html > v1 -> v2: Use a better buglink (Cornelia), simplify the inline asm > magic in the test and add an explanation (David). > > v2: https://lists.nongnu.org/archive/html/qemu-devel/2021-05/msg06649.html > v2 -> v3: Fix SIGSEGV handling (found when trying to run valgrind under > qemu-user). > > v3: https://lists.nongnu.org/archive/html/qemu-devel/2021-06/msg00299.html > v3 -> v4: Fix compiling the test on Ubuntu 20.04 (Jonathan). > > v4: https://lists.nongnu.org/archive/html/qemu-devel/2021-06/msg05848.html > v4 -> v5: Greatly simplify the fix (Ulrich). > > Note: the compare-and-trap SIGFPE issue is being fixed separately. > https://lists.nongnu.org/archive/html/qemu-devel/2021-06/msg05690.html > > Ilya Leoshkevich (2): > target/s390x: Fix SIGILL/SIGFPE/SIGTRAP psw.addr reporting > tests/tcg/s390x: Test SIGILL and SIGSEGV handling > > linux-user/s390x/cpu_loop.c | 5 + > tests/tcg/s390x/Makefile.target | 1 + > tests/tcg/s390x/signal.c | 165 ++++++++++++++++++++++++++++++++ > 3 files changed, 171 insertions(+) > create mode 100644 tests/tcg/s390x/signal.c What's the status of this and <20210621141452.2045-1-jonathan.albrecht@linux.vnet.ibm.com>? linux-user is not really my turf, but it would be sad if this fell through the cracks.