From: Petr Lautrbach <plautrba@redhat.com>
To: "Christian Göttsche" <cgzones@googlemail.com>, selinux@vger.kernel.org
Subject: Re: [PATCH 00/25] libselinux: misc compiler and static analyzer findings
Date: Tue, 18 May 2021 20:37:22 +0200 [thread overview]
Message-ID: <87a6orlwgt.fsf@redhat.com> (raw)
In-Reply-To: <20210503175350.55954-1-cgzones@googlemail.com>
Christian Göttsche <cgzones@googlemail.com> writes:
> Several changes found by compilers and static analyzer regarding const
> qualifiers, dead code, code smells and resource cleanup.
>
> Contains no changes with regard to libselinux callers.
Acked-by: Petr Lautrbach <plautrba@redhat.com>
All merged.
Thanks!
>
> Christian Göttsche (25):
> libselinux: sidtab_hash(): do not discard const qualifier
> libselinux: selinux_file_context_cmp(): do not discard const qualifier
> libselinux: label_common(): do not discard const qualifier
> libselinux: Sha1Finalise(): do not discard const qualifier
> libselinux: sefcontext_compile: mark local variable static
> libselinux: avcstat: use standard length modifier for unsigned long
> long
> libselinux: selinux_restorecon: mark local variable static
> libselinux: selabel_get_digests_all_partial_matches: free memory after
> FTS_D block
> libselinux: getconlist: free memory on multiple level arguments
> libselinux: exclude_non_seclabel_mounts(): drop unused variable
> libselinux: context_new(): drop dead assignment
> libselinux: label_x::init(): drop dead assignment
> libselinux: label_media::init(): drop dead assignment
> libselinux: setexecfilecon(): drop dead assignment
> libselinux: getdefaultcon: free memory on multiple same arguments
> libselinux: store_stem(): do not free possible non-heap object
> libselinux: matchmediacon(): close file on error
> libselinux: init_selinux_config(): free resources on error
> libselinux: label_file::init(): do not pass NULL to strdup
> libselinux: matchpathcon: free memory on realloc failure
> libselinux: label_db::db_init(): open file with CLOEXEC mode
> libselinux: drop redundant casts to the same type
> libselinux: sidtab_sid_stats(): unify parameter name
> libselinux: regex: unify parameter names
> libselinux: label_file.c: fix indent
>
> libselinux/src/audit2why.c | 2 +-
> libselinux/src/avc_sidtab.c | 15 ++++-----
> libselinux/src/context.c | 2 +-
> libselinux/src/is_customizable_type.c | 2 +-
> libselinux/src/label_db.c | 2 +-
> libselinux/src/label_file.c | 16 ++++++----
> libselinux/src/label_file.h | 8 +++--
> libselinux/src/label_media.c | 1 -
> libselinux/src/label_x.c | 1 -
> libselinux/src/matchmediacon.c | 1 +
> libselinux/src/matchpathcon.c | 32 +++++++++++--------
> libselinux/src/regex.c | 4 +--
> libselinux/src/selinux_config.c | 7 +++-
> libselinux/src/selinux_restorecon.c | 7 ++--
> libselinux/src/setexecfilecon.c | 1 -
> libselinux/src/sha1.c | 10 +++---
> libselinux/src/sha1.h | 2 +-
> libselinux/utils/avcstat.c | 4 +--
> libselinux/utils/getconlist.c | 1 +
> libselinux/utils/getdefaultcon.c | 3 ++
> libselinux/utils/sefcontext_compile.c | 2 +-
> .../selabel_get_digests_all_partial_matches.c | 10 +++---
> 22 files changed, 76 insertions(+), 57 deletions(-)
>
> --
> 2.31.1
prev parent reply other threads:[~2021-05-18 18:37 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-03 17:53 [PATCH 00/25] libselinux: misc compiler and static analyzer findings Christian Göttsche
2021-05-03 17:53 ` [PATCH 01/25] libselinux: sidtab_hash(): do not discard const qualifier Christian Göttsche
2021-05-03 17:53 ` [PATCH 02/25] libselinux: selinux_file_context_cmp(): " Christian Göttsche
2021-05-03 17:53 ` [PATCH 03/25] libselinux: label_common(): " Christian Göttsche
2021-05-03 17:53 ` [PATCH 04/25] libselinux: Sha1Finalise(): " Christian Göttsche
2021-05-03 17:53 ` [PATCH 05/25] libselinux: sefcontext_compile: mark local variable static Christian Göttsche
2021-05-03 17:53 ` [PATCH 06/25] libselinux: avcstat: use standard length modifier for unsigned long long Christian Göttsche
2021-05-03 17:53 ` [PATCH 07/25] libselinux: selinux_restorecon: mark local variable static Christian Göttsche
2021-05-03 17:53 ` [PATCH 08/25] libselinux: selabel_get_digests_all_partial_matches: free memory after FTS_D block Christian Göttsche
2021-05-03 17:53 ` [PATCH 09/25] libselinux: getconlist: free memory on multiple level arguments Christian Göttsche
2021-05-03 17:53 ` [PATCH 10/25] libselinux: exclude_non_seclabel_mounts(): drop unused variable Christian Göttsche
2021-05-03 17:53 ` [PATCH 11/25] libselinux: context_new(): drop dead assignment Christian Göttsche
2021-05-03 17:53 ` [PATCH 12/25] libselinux: label_x::init(): " Christian Göttsche
2021-05-03 17:53 ` [PATCH 13/25] libselinux: label_media::init(): " Christian Göttsche
2021-05-03 17:53 ` [PATCH 14/25] libselinux: setexecfilecon(): " Christian Göttsche
2021-05-03 17:53 ` [PATCH 15/25] libselinux: getdefaultcon: free memory on multiple same arguments Christian Göttsche
2021-05-03 17:53 ` [PATCH 16/25] libselinux: store_stem(): do not free possible non-heap object Christian Göttsche
2021-05-03 17:53 ` [PATCH 17/25] libselinux: matchmediacon(): close file on error Christian Göttsche
2021-05-03 17:53 ` [PATCH 18/25] libselinux: init_selinux_config(): free resources " Christian Göttsche
2021-05-03 17:53 ` [PATCH 19/25] libselinux: label_file::init(): do not pass NULL to strdup Christian Göttsche
2021-05-03 17:53 ` [PATCH 20/25] libselinux: matchpathcon: free memory on realloc failure Christian Göttsche
2021-05-03 17:53 ` [PATCH 21/25] libselinux: label_db::db_init(): open file with CLOEXEC mode Christian Göttsche
2021-05-03 17:53 ` [PATCH 22/25] libselinux: drop redundant casts to the same type Christian Göttsche
2021-05-03 17:53 ` [PATCH 23/25] libselinux: sidtab_sid_stats(): unify parameter name Christian Göttsche
2021-05-03 17:53 ` [PATCH 24/25] libselinux: regex: unify parameter names Christian Göttsche
2021-05-03 17:53 ` [PATCH 25/25] libselinux: label_file.c: fix indent Christian Göttsche
2021-05-18 18:37 ` Petr Lautrbach [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a6orlwgt.fsf@redhat.com \
--to=plautrba@redhat.com \
--cc=cgzones@googlemail.com \
--cc=selinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.