All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marc Zyngier <maz@kernel.org>
To: Andrew Scull <ascull@google.com>
Cc: kernel-team@android.com, catalin.marinas@arm.com,
	will@kernel.org, kvmarm@lists.cs.columbia.edu
Subject: Re: [PATCH 2/2] KVM: arm64: Log source when panicking from nVHE hyp
Date: Tue, 23 Feb 2021 15:18:37 +0000	[thread overview]
Message-ID: <87a6ru24oi.wl-maz@kernel.org> (raw)
In-Reply-To: <YDT2TvFFxre5i3KN@google.com>

On Tue, 23 Feb 2021 12:34:22 +0000,
Andrew Scull <ascull@google.com> wrote:
> 
> On Tue, Feb 23, 2021 at 11:29:54AM +0000, Marc Zyngier wrote:

[...]

> > Would it be worth making it a helper that lives there? Something
> > like
> > 
> > struct bug_entry *bug_get_entry(unsigned long pc, char **file,
> > 				unsigned int *line);
> > 
> > that hides the #ifdefery and the fund_bug() call away? The
> > disable_trace_on_warning() call isn't a problem, as we're about to die
> > anyway.
> 
> Yeah, that'd make a lot of sense. Please protect me from the wrath of
> the community when I touch the common code..

The community should be pleased if you gifted it with a piece of
reusable code instead of some less palatable copy-paste! :-)

	M.

-- 
Without deviation from the norm, progress is not possible.
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm

      reply	other threads:[~2021-02-23 15:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-23  9:49 [PATCH 0/2] Debug info for nVHE hyp panics Andrew Scull
2021-02-23  9:49 ` [PATCH 1/2] KVM: arm64: Use BUG and BUG_ON in nVHE hyp Andrew Scull
2021-02-23  9:49 ` [PATCH 2/2] KVM: arm64: Log source when panicking from " Andrew Scull
2021-02-23 11:29   ` Marc Zyngier
2021-02-23 12:34     ` Andrew Scull
2021-02-23 15:18       ` Marc Zyngier [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a6ru24oi.wl-maz@kernel.org \
    --to=maz@kernel.org \
    --cc=ascull@google.com \
    --cc=catalin.marinas@arm.com \
    --cc=kernel-team@android.com \
    --cc=kvmarm@lists.cs.columbia.edu \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.