All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@codeaurora.org>
To: Doug Anderson <dianders@chromium.org>
Cc: Abhishek Kumar <kuabhs@chromium.org>,
	Brian Norris <briannorris@chromium.org>,
	linux-wireless <linux-wireless@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	ath10k <ath10k@lists.infradead.org>,
	Rakesh Pillai <pillair@codeaurora.org>
Subject: Re: [PATCH v3] ath10k: Fix the parsing error in service available event
Date: Wed, 02 Dec 2020 20:31:55 +0200	[thread overview]
Message-ID: <87a6uwhxes.fsf@codeaurora.org> (raw)
In-Reply-To: <CAD=FV=Xnk-VeZKy3vzr4VZNW+OogfwEAjU-QVHQRYD-yix8LPQ@mail.gmail.com> (Doug Anderson's message of "Fri, 20 Nov 2020 16:26:07 -0800")

Doug Anderson <dianders@chromium.org> writes:

> Hi,
>
> On Sun, Nov 15, 2020 at 8:35 PM Rakesh Pillai <pillair@codeaurora.org> wrote:
>>
>> The wmi service available event has been
>> extended to contain extra 128 bit for new services
>> to be indicated by firmware.
>>
>> Currently the presence of any optional TLVs in
>> the wmi service available event leads to a parsing
>> error with the below error message:
>> ath10k_snoc 18800000.wifi: failed to parse svc_avail tlv: -71
>>
>> The wmi service available event parsing should
>> not return error for the newly added optional TLV.
>> Fix this parsing for service available event message.
>>
>> Tested-on: WCN3990 hw1.0 SNOC WLAN.HL.3.2.2-00720-QCAHLSWMTPL-1
>>
>> Fixes: cea19a6ce8bf ("ath10k: add WMI_SERVICE_AVAILABLE_EVENT support")
>> Signed-off-by: Rakesh Pillai <pillair@codeaurora.org>
>> ---
>> Changes from v2:
>> - Add code documentation explaining the necessity of variable
>>   initialization for the logic to work.
>> ---
>>  drivers/net/wireless/ath/ath10k/wmi-tlv.c | 4 +++-
>>  drivers/net/wireless/ath/ath10k/wmi.c     | 9 +++++++--
>>  drivers/net/wireless/ath/ath10k/wmi.h     | 1 +
>>  3 files changed, 11 insertions(+), 3 deletions(-)
>
> This looks nice to me now.  I will let Kalle decide what to do about
> the checkpatch issue that Abhishek found (ignore, fix himself, or
> request another spin).

Currently ath10k uses mixed of both comment styles and I have disabled
that patchwork check in my ath10k-check script. I should finally try to
unify that and make all ath10k comments to use the networking style,
patches very welcome :)

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@codeaurora.org>
To: Doug Anderson <dianders@chromium.org>
Cc: Rakesh Pillai <pillair@codeaurora.org>,
	Abhishek Kumar <kuabhs@chromium.org>,
	Brian Norris <briannorris@chromium.org>,
	linux-wireless <linux-wireless@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	ath10k <ath10k@lists.infradead.org>
Subject: Re: [PATCH v3] ath10k: Fix the parsing error in service available event
Date: Wed, 02 Dec 2020 20:31:55 +0200	[thread overview]
Message-ID: <87a6uwhxes.fsf@codeaurora.org> (raw)
In-Reply-To: <CAD=FV=Xnk-VeZKy3vzr4VZNW+OogfwEAjU-QVHQRYD-yix8LPQ@mail.gmail.com> (Doug Anderson's message of "Fri, 20 Nov 2020 16:26:07 -0800")

Doug Anderson <dianders@chromium.org> writes:

> Hi,
>
> On Sun, Nov 15, 2020 at 8:35 PM Rakesh Pillai <pillair@codeaurora.org> wrote:
>>
>> The wmi service available event has been
>> extended to contain extra 128 bit for new services
>> to be indicated by firmware.
>>
>> Currently the presence of any optional TLVs in
>> the wmi service available event leads to a parsing
>> error with the below error message:
>> ath10k_snoc 18800000.wifi: failed to parse svc_avail tlv: -71
>>
>> The wmi service available event parsing should
>> not return error for the newly added optional TLV.
>> Fix this parsing for service available event message.
>>
>> Tested-on: WCN3990 hw1.0 SNOC WLAN.HL.3.2.2-00720-QCAHLSWMTPL-1
>>
>> Fixes: cea19a6ce8bf ("ath10k: add WMI_SERVICE_AVAILABLE_EVENT support")
>> Signed-off-by: Rakesh Pillai <pillair@codeaurora.org>
>> ---
>> Changes from v2:
>> - Add code documentation explaining the necessity of variable
>>   initialization for the logic to work.
>> ---
>>  drivers/net/wireless/ath/ath10k/wmi-tlv.c | 4 +++-
>>  drivers/net/wireless/ath/ath10k/wmi.c     | 9 +++++++--
>>  drivers/net/wireless/ath/ath10k/wmi.h     | 1 +
>>  3 files changed, 11 insertions(+), 3 deletions(-)
>
> This looks nice to me now.  I will let Kalle decide what to do about
> the checkpatch issue that Abhishek found (ignore, fix himself, or
> request another spin).

Currently ath10k uses mixed of both comment styles and I have disabled
that patchwork check in my ath10k-check script. I should finally try to
unify that and make all ath10k comments to use the networking style,
patches very welcome :)

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

  reply	other threads:[~2020-12-02 18:32 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-16  4:34 [PATCH v3] ath10k: Fix the parsing error in service available event Rakesh Pillai
2020-11-16  4:34 ` Rakesh Pillai
2020-11-19  0:20 ` Abhishek Kumar
2020-11-19  0:20   ` Abhishek Kumar
2020-11-21  0:26 ` Doug Anderson
2020-11-21  0:26   ` Doug Anderson
2020-12-02 18:31   ` Kalle Valo [this message]
2020-12-02 18:31     ` Kalle Valo
2020-12-02 18:28 ` Kalle Valo
2020-12-02 18:28 ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a6uwhxes.fsf@codeaurora.org \
    --to=kvalo@codeaurora.org \
    --cc=ath10k@lists.infradead.org \
    --cc=briannorris@chromium.org \
    --cc=dianders@chromium.org \
    --cc=kuabhs@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=pillair@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.