From: Kalle Valo <kvalo@codeaurora.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 8/8] cfg80211: remove WDS code
Date: Mon, 09 Nov 2020 13:33:02 +0200 [thread overview]
Message-ID: <87a6vqg3yp.fsf@codeaurora.org> (raw)
In-Reply-To: <ef27c87e34c173e015ce41242dab3bdf2d312d8d.camel@sipsolutions.net> (Johannes Berg's message of "Mon, 09 Nov 2020 12:12:21 +0100")
Johannes Berg <johannes@sipsolutions.net> writes:
> On Mon, 2020-11-09 at 13:11 +0200, Kalle Valo wrote:
>> Johannes Berg <johannes@sipsolutions.net> writes:
>>
>> > From: Johannes Berg <johannes.berg@intel.com>
>> >
>> > Remove all the code that was there to configure WDS interfaces,
>> > now that there's no way to reach it anymore.
>> >
>> > Signed-off-by: Johannes Berg <johannes.berg@intel.com>
>>
>> [...]
>>
>> > @@ -675,10 +673,8 @@ int wiphy_register(struct wiphy *wiphy)
>> > !(wiphy->nan_supported_bands & BIT(NL80211_BAND_2GHZ)))))
>> > return -EINVAL;
>> >
>> > -#ifndef CONFIG_WIRELESS_WDS
>> > if (WARN_ON(wiphy->interface_modes & BIT(NL80211_IFTYPE_WDS)))
>> > return -EINVAL;
>> > -#endif
>>
>> What about out-of-tree drivers? Should we have (or do we already have?)
>> a some kind safe guard if an out of tree driver tries to use WDS?
>
> That's what happens here, no? We warn and return invalid - now
> unconditionally, before we allowed it if CONFIG_WIRELESS_WDS was
> enabled.
Argh, I'm blind. I read that the whole if block was removed :) Sorry for
the noise.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2020-11-09 11:36 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-09 9:57 [PATCH 0/8] wireless: remove WDS mode Johannes Berg
2020-11-09 9:57 ` [PATCH 1/8] wireless: remove CONFIG_WIRELESS_WDS Johannes Berg
2020-11-09 9:57 ` [PATCH 2/8] ath9k: remove WDS code Johannes Berg
2020-11-09 9:57 ` [PATCH 3/8] carl9170: " Johannes Berg
2020-11-09 9:57 ` [PATCH 4/8] b43: " Johannes Berg
2020-11-09 9:57 ` [PATCH 5/8] b43legacy: " Johannes Berg
2020-11-09 9:57 ` [PATCH 6/8] rt2x00: " Johannes Berg
2020-11-09 9:57 ` [PATCH 7/8] mac80211: remove WDS-related code Johannes Berg
2020-11-10 4:58 ` kernel test robot
2020-11-10 4:58 ` kernel test robot
2020-11-11 11:23 ` kernel test robot
2020-11-09 9:57 ` [PATCH 8/8] cfg80211: remove WDS code Johannes Berg
2020-11-09 11:11 ` Kalle Valo
2020-11-09 11:12 ` Johannes Berg
2020-11-09 11:33 ` Kalle Valo [this message]
2020-11-09 11:13 ` [PATCH 0/8] wireless: remove WDS mode Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a6vqg3yp.fsf@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.