From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DBABC4363A for ; Tue, 27 Oct 2020 07:28:29 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9806422264 for ; Tue, 27 Oct 2020 07:28:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="KVyYXkNk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9806422264 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:55080 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kXJP9-0004Xk-PD for qemu-devel@archiver.kernel.org; Tue, 27 Oct 2020 03:28:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50656) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kXJOV-0003oN-L9 for qemu-devel@nongnu.org; Tue, 27 Oct 2020 03:27:47 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:34736) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kXJOS-0004Gv-PK for qemu-devel@nongnu.org; Tue, 27 Oct 2020 03:27:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1603783662; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7Ig1CWcOxDOOuOk5A4QxcLVHh6Vb5X6ag8N7FoO/Ucw=; b=KVyYXkNkdAGqFm9BV9eLuUYnKEe5A/T+hEXeGyY49wIpQiJzElKHbQb4cj1L20CTLMF6pM 8zyML8K3GLIQkx8njQhjcE6Y0owCu2TkqRtYgEMCzIv8PZbJlNpfvRUJu2nnaeYCzN0+vd d0Ml0CP/1Bsn4bVd4ZqNnEFwfj75ZRw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-69-gq7P3_9HODiESralYTXPtw-1; Tue, 27 Oct 2020 03:27:40 -0400 X-MC-Unique: gq7P3_9HODiESralYTXPtw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id AC7781006CA4 for ; Tue, 27 Oct 2020 07:27:39 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-112-182.ams2.redhat.com [10.36.112.182]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1A59E5D9E4; Tue, 27 Oct 2020 07:27:30 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id AB122113865F; Tue, 27 Oct 2020 08:27:28 +0100 (CET) From: Markus Armbruster To: marcandre.lureau@redhat.com Subject: Re: [PATCH 2/3] console: modify ppm_save to take a pixman image ref References: <20201010204106.1368710-1-marcandre.lureau@redhat.com> <20201010204106.1368710-3-marcandre.lureau@redhat.com> Date: Tue, 27 Oct 2020 08:27:28 +0100 In-Reply-To: <20201010204106.1368710-3-marcandre.lureau@redhat.com> (marcandre lureau's message of "Sun, 11 Oct 2020 00:41:05 +0400") Message-ID: <87a6w8163j.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=armbru@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=216.205.24.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/27 01:06:06 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Gerd Hoffmann , qemu-devel@nongnu.org, Stefan Hajnoczi , "Dr. David Alan Gilbert" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" marcandre.lureau@redhat.com writes: > From: Marc-Andr=C3=A9 Lureau > > The function is going to be called from a coroutine, and may yields. s/yields/yield/ > Let's ensure our image reference doesn't change over time (due to resize > etc) by keeping a ref. > > Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Markus Armbruster