From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 528C0C4724C for ; Fri, 1 May 2020 19:32:21 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 144182137B for ; Fri, 1 May 2020 19:32:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="TqqqZFq+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 144182137B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:54288 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jUbOW-0004gj-7l for qemu-devel@archiver.kernel.org; Fri, 01 May 2020 15:32:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37310) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jUbNh-0003ms-Aa for qemu-devel@nongnu.org; Fri, 01 May 2020 15:31:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jUbNf-0005n2-Ga for qemu-devel@nongnu.org; Fri, 01 May 2020 15:31:28 -0400 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]:41847) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jUbNe-0005hF-Ac for qemu-devel@nongnu.org; Fri, 01 May 2020 15:31:27 -0400 Received: by mail-wr1-x442.google.com with SMTP id g13so12619966wrb.8 for ; Fri, 01 May 2020 12:31:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version:content-transfer-encoding; bh=GVigOjc7WbcFaD6+3bkBGFuI8NHRRREkHfYH7x4RLm4=; b=TqqqZFq+8fhBkW9LXJCkS6o3RlvqlYyRQl8w7KiHbgo6ZBCUA1YZvHvDV7kDyB+wk8 iPhJmirzx4PSBG2moREolDTmTPOF84uP5+dxuaRZoeEMZYJ+viU2m0nzRn3dCZHKrpYg PP9kk4EHU5BGgSVITSV5dsyD0j049m0ZagRoCU5sm8DmDNbhP3788JB0fTsR/jbrR3Rk Q7UUcYXg1mMAlTVeZT7GqWPnb0BoNScya+tNddlFcmUSacp8bEVlyjzKAGARFM2dK5FQ 16OMemdsUykeT2jzSp/jkoDJ81frD7jdbDp6/t9fQKNmvnw0GQc3wUwNYVaRr/TN0JV7 xSuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version:content-transfer-encoding; bh=GVigOjc7WbcFaD6+3bkBGFuI8NHRRREkHfYH7x4RLm4=; b=WKuTixJEPWqlKjHqe7fhO0H+k1eZkaqvqf1HIlBTRMFi1gv6GP0REpw5YsN8rHMHKl 33BKJiHK0T4jQ8Yd+GvDj1irKDkh6Kt2vRkjzRK27oRiWetpiQljRsmKt0ds1fsq8wzM uLNwBG+RjCat6iGFtDSwlOx0jFq3i1UmXIkKnDES0Hn/71c0QMZieIJoO0pJu0LiRfJu T9fUj+fVOV8j/3W0DsdLKp8JIDclISdNip1njLcgONCT+haxWD643gK2rve8nq8uxtIG FjGtKf7mv28V604Nx3EtDqSfMKFfY9Y7njEdBIqq2ofIuEejUUz+JbqJrb4NddyReal7 lKeg== X-Gm-Message-State: AGi0PuZTUOymqeTfM1KLydVm66OGnEz0Z7NZmaDNAragcxgWeZcN5g8e wdc0u6QgC7N0PSozggNMbqUa+5Waxdw= X-Google-Smtp-Source: APiQypIm7Ikugn87SAA1LV0fMn+TnJwDFhFku5oubXZ6hMBptFaJ7rPpWEyyl6zzKy+rP86ZJJA+jw== X-Received: by 2002:a5d:4711:: with SMTP id y17mr3284223wrq.49.1588361484340; Fri, 01 May 2020 12:31:24 -0700 (PDT) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id d133sm823018wmc.27.2020.05.01.12.31.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 May 2020 12:31:23 -0700 (PDT) Received: from zen (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 7166A1FF7E; Fri, 1 May 2020 20:31:22 +0100 (BST) References: <87d07niidw.fsf@linaro.org> User-agent: mu4e 1.4.1; emacs 28.0.50 From: Alex =?utf-8?Q?Benn=C3=A9e?= To: Joseph Myers Subject: Re: [PATCH 3/4] softfloat: fix floatx80 pseudo-denormal comparisons In-reply-to: Date: Fri, 01 May 2020 20:31:22 +0100 Message-ID: <87a72rih9x.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::442; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x442.google.com X-detected-operating-system: by eggs.gnu.org: Error: [-] PROGRAM ABORT : Malformed IPv6 address (bad octet value). Location : parse_addr6(), p0f-client.c:67 X-Received-From: 2a00:1450:4864:20::442 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Joseph Myers writes: > On Fri, 1 May 2020, Alex Benn=C3=A9e wrote: > >>=20 >> Joseph Myers writes: >>=20 >> > The softfloat floatx80 comparisons fail to allow for pseudo-denormals, >> > which should compare equal to corresponding values with biased >> > exponent 1 rather than 0. Add an adjustment for that case when >> > comparing numbers with the same sign. >> > >> > Note that this fix only changes floatx80_compare_internal, not the >> > other more specific comparison operations. That is the only >> > comparison function for floatx80 used in the i386 port, which is the >> > only supported port with these pseudo-denormal semantics. >>=20 >> Again I can't see anything that triggers this although I noticed >> le_quiet has been fixed in the meantime. lt_quiet still fails with: > > It looks like this test is only testing the separate comparison functions= ,=20 > which aren't used in the i386 port and which I didn't change, not anythin= g=20 > that uses floatx80_compare_internal. (That's apart from probably not=20 > covering pseudo-denormals either.) OK - so these only turn up in i386? I think then the things we need for v2 are: a) ensure we don't break the existing working TestFloat tests b) try an enable the previously broken tests for areas touched c) introduce some i386 specific tests to guard the pseudo-denormal behaviour We have two tests currently (float_convs and float_madds) which currently exercise the various combinations of limits and NaN types using some common float_helpers.c support. Maybe extend it for have a table of the various ext80 types and write a i386 only test case to exercise the functions you fixed? --=20 Alex Benn=C3=A9e