From: "Alex Bennée" <alex.bennee@linaro.org>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: Thomas Huth <thuth@redhat.com>,
Eduardo Habkost <ehabkost@redhat.com>,
Riku Voipio <riku.voipio@iki.fi>,
qemu-devel@nongnu.org, Laurent Vivier <laurent@vivier.eu>,
Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [PATCH v2 4/6] Makefile: Remove unhelpful comment
Date: Mon, 20 Jan 2020 11:04:02 +0000 [thread overview]
Message-ID: <87a76i4cf1.fsf@linaro.org> (raw)
In-Reply-To: <20200118140619.26333-5-philmd@redhat.com>
Philippe Mathieu-Daudé <philmd@redhat.com> writes:
> It is pointless to keep qapi/ object separate from the other
> common-objects. Drop the comment.
>
> Reviewed-by: Thomas Huth <thuth@redhat.com>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> Makefile.objs | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/Makefile.objs b/Makefile.objs
> index 395dd1e670..c6321d0465 100644
> --- a/Makefile.objs
> +++ b/Makefile.objs
> @@ -71,11 +71,9 @@ qemu-seccomp.o-libs := $(SECCOMP_LIBS)
>
> common-obj-$(CONFIG_FDT) += device_tree.o
>
> -######################################################################
> -# qapi
> -
> common-obj-y += qapi/
> -endif
> +
> +endif # CONFIG_SOFTMMU
>
> #######################################################################
> # Target-independent parts used in system and user emulation
--
Alex Bennée
next prev parent reply other threads:[~2020-01-20 11:15 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-18 14:06 [PATCH v2 0/6] buildsys: Build faster (mostly tools and linux-user) Philippe Mathieu-Daudé
2020-01-18 14:06 ` [PATCH v2 1/6] configure: Do not build libfdt if not required Philippe Mathieu-Daudé
2020-01-20 11:02 ` Alex Bennée
2020-01-18 14:06 ` [PATCH v2 2/6] Makefile: Clarify all the codebase requires qom/ objects Philippe Mathieu-Daudé
2020-01-20 11:03 ` Alex Bennée
2020-01-18 14:06 ` [PATCH v2 3/6] Makefile: Restrict system emulation and tools objects Philippe Mathieu-Daudé
2020-01-20 11:03 ` Alex Bennée
2020-01-18 14:06 ` [PATCH v2 4/6] Makefile: Remove unhelpful comment Philippe Mathieu-Daudé
2020-01-20 11:04 ` Alex Bennée [this message]
2020-01-18 14:06 ` [PATCH v2 5/6] hw/core: Restrict reset handlers API to system-mode Philippe Mathieu-Daudé
2020-01-20 5:27 ` Thomas Huth
2020-01-20 11:07 ` Alex Bennée
2020-01-21 10:59 ` Philippe Mathieu-Daudé
2020-01-18 14:06 ` [PATCH v2 6/6] hw/core/Makefile: Group generic objects versus system-mode objects Philippe Mathieu-Daudé
2020-01-20 11:14 ` Alex Bennée
2020-01-18 14:22 ` [PATCH v2 0/6] buildsys: Build faster (mostly tools and linux-user) Philippe Mathieu-Daudé
2020-01-21 10:54 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a76i4cf1.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=ehabkost@redhat.com \
--cc=laurent@vivier.eu \
--cc=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
--cc=rth@twiddle.net \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.