From: Markus Armbruster <armbru@redhat.com>
To: Yury Kotov <yury-kotov@yandex-team.ru>
Cc: "Daniel P. Berrangé" <berrange@redhat.com>,
qemu-devel@nongnu.org,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
"Denis Plotnikov" <dplotnikov@virtuozzo.com>,
yc-core@yandex-team.ru, "Denis V. Lunev" <den@openvz.org>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: Re: [PATCH 0/2] Speed up QMP stream reading
Date: Fri, 20 Dec 2019 17:09:31 +0100 [thread overview]
Message-ID: <87a77ndlms.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <20191219160756.22389-1-yury-kotov@yandex-team.ru> (Yury Kotov's message of "Thu, 19 Dec 2019 19:07:54 +0300")
Yury Kotov <yury-kotov@yandex-team.ru> writes:
> Hi,
>
> This series is continuation of another one:
> [PATCH] monitor: Fix slow reading
> https://lists.gnu.org/archive/html/qemu-devel/2019-11/msg03722.html
>
> Which also tried to read more than one byte from a stream at a time,
> but had some problems with OOB and HMP:
> https://lists.gnu.org/archive/html/qemu-devel/2019-11/msg05018.html
>
> This series is an attempt to fix problems described.
Two problems: (1) breaks HMP migrate -d, and (2) need to think through
how this affects reading of QMP input, in particular OOB.
This series refrains from changing HMP, thus avoids (1). Good.
What about (2)? I'm feeling denser than usual today... Can you explain
real slow how QMP input works? PATCH 2 appears to splice in a ring
buffer. Why is that needed?
next prev parent reply other threads:[~2019-12-20 16:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-19 16:07 [PATCH 0/2] Speed up QMP stream reading Yury Kotov
2019-12-19 16:07 ` [PATCH 1/2] monitor: Split monitor_can_read for QMP and HMP Yury Kotov
2019-12-19 16:07 ` [PATCH 2/2] monitor: Add an input buffer for QMP reading Yury Kotov
2020-01-22 9:42 ` Markus Armbruster
2019-12-20 16:09 ` Markus Armbruster [this message]
2019-12-23 12:41 ` [PATCH 0/2] Speed up QMP stream reading Yury Kotov
2020-01-03 11:07 ` Dr. David Alan Gilbert
2020-01-03 19:06 ` Peter Xu
2020-01-03 19:36 ` Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a77ndlms.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=den@openvz.org \
--cc=dgilbert@redhat.com \
--cc=dplotnikov@virtuozzo.com \
--cc=marcandre.lureau@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=yc-core@yandex-team.ru \
--cc=yury-kotov@yandex-team.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.