From: "Toke Høiland-Jørgensen" <toke@redhat.com>
To: Kan Yan <kyan@google.com>
Cc: Dave Taht <dave.taht@gmail.com>,
Rajkumar Manoharan <rmanohar@codeaurora.org>,
Kevin Hayes <kevinhayes@google.com>,
Make-Wifi-fast <make-wifi-fast@lists.bufferbloat.net>,
linux-wireless <linux-wireless@vger.kernel.org>,
Yibo Zhao <yiboz@codeaurora.org>, John Crispin <john@phrozen.org>,
Johannes Berg <johannes@sipsolutions.net>,
Lorenzo Bianconi <lorenzo@kernel.org>,
Felix Fietkau <nbd@nbd.name>
Subject: Re: [Make-wifi-fast] [PATCH v8 0/2] Implement Airtime-based Queue Limit (AQL)
Date: Thu, 21 Nov 2019 11:05:16 +0100 [thread overview]
Message-ID: <87a78p8rz7.fsf@toke.dk> (raw)
In-Reply-To: <CA+iem5tpfEmaWJ5Mw7xF9fb=XLceZpC1LM4Avo89Mn1fL7YZVw@mail.gmail.com>
Kan Yan <kyan@google.com> writes:
>> It would be interesting to get some samples of the actual sojourn time
>> as seen by CoDel in mac80211. Might be doable with bpftrace...
>
> I will try to add some trace event to get the sojourn time for the
> next round of tests.
In theory, this ought to produce a histogram of sojourn times (in
microseconds):
bpftrace -e 'kretprobe:codel_skb_time_func { @sojourn = lhist((nsecs - (retval << 10))/1000, 0, 100000, 1000); }'
Can't get the CoDel drop mechanism to trigger on my system at all,
though (a laptop running on iwl). I guess because there's queue
backpressure to userspace first?
It would be interesting to see if it works for you, assuming you can get
bpftrace to work on your test system :)
-Toke
next prev parent reply other threads:[~2019-11-21 10:05 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-15 1:48 [PATCH v8 0/2] Implement Airtime-based Queue Limit (AQL) Kan Yan
2019-11-15 1:48 ` [v8 PATCH 1/2] mac80211: Import airtime calculation code from mt76 Kan Yan
2019-11-15 1:48 ` [v8 PATCH 2/2] mac80211: Implement Airtime-based Queue Limit (AQL) Kan Yan
2019-11-15 12:56 ` Toke Høiland-Jørgensen
2019-11-16 2:21 ` Kan Yan
2019-11-15 2:04 ` [PATCH v8 0/2] " Kan Yan
2019-11-15 2:07 ` [Make-wifi-fast] " Dave Taht
[not found] ` <CA+iem5s4ZY239Q4=Gwy3WrmVhcdhesirXph6XQoOP5w-nuWcYw@mail.gmail.com>
2019-11-18 21:08 ` Dave Taht
2019-11-20 0:40 ` Kan Yan
2019-11-20 10:14 ` Toke Høiland-Jørgensen
2019-11-21 2:05 ` Kan Yan
2019-11-21 10:05 ` Toke Høiland-Jørgensen [this message]
[not found] ` <CA+iem5tNz2jjEOVmbh3aPTXLLZfkRjZ60-+bon1vDEJ8D4hQJw@mail.gmail.com>
2019-11-22 10:45 ` Toke Høiland-Jørgensen
2019-11-26 5:04 ` Kan Yan
2019-11-26 9:19 ` Toke Høiland-Jørgensen
2019-11-27 2:13 ` Dave Taht
2019-12-03 19:02 ` Kan Yan
2019-12-04 4:47 ` Kalle Valo
[not found] ` <0101016ecf3bc899-6e391bba-96ed-4495-a7be-1aa8dd8f1bf2-000000@us-west-2.amazonses.com>
2019-12-04 8:07 ` Johannes Berg
2019-12-04 14:34 ` Toke Høiland-Jørgensen
2019-12-06 19:53 ` Dave Taht
2019-12-06 22:04 ` Kan Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a78p8rz7.fsf@toke.dk \
--to=toke@redhat.com \
--cc=dave.taht@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=john@phrozen.org \
--cc=kevinhayes@google.com \
--cc=kyan@google.com \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo@kernel.org \
--cc=make-wifi-fast@lists.bufferbloat.net \
--cc=nbd@nbd.name \
--cc=rmanohar@codeaurora.org \
--cc=yiboz@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.