From: jouni.hogander@unikie.com (Jouni Högander)
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: netdev@vger.kernel.org, David Miller <davem@davemloft.net>,
Lukas Bulwahn <lukas.bulwahn@gmail.com>
Subject: Re: [PATCH v3] net-sysfs: Fix reference count leak
Date: Tue, 19 Nov 2019 11:00:19 +0200 [thread overview]
Message-ID: <87a78ss0kc.fsf@unikie.com> (raw)
In-Reply-To: <20191119075812.GB1858193@kroah.com> (Greg Kroah-Hartman's message of "Tue, 19 Nov 2019 08:58:12 +0100")
Greg Kroah-Hartman <gregkh@linuxfoundation.org> writes:
> On Tue, Nov 19, 2019 at 09:45:02AM +0200, Jouni Högander wrote:
>> Do you think better choise would be to remove BUG_ON completely rather
>> than replacing it with WARN_ON?
>
> I don't know this code, and I'm not the maintainer of it, so I don't
> have a strong opinion. Other than if this was code I was maintaining, I
> would not want it there :)
>
> Anyway, your original fix looks sane to me, and that's probably a good
> thing to just do now and then you can work on these other things.
>
> thanks,
>
> greg k-h
Thank you a lot for your help on this patch.
BR,
Jouni Högander
next prev parent reply other threads:[~2019-11-19 9:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-18 12:32 [PATCH v3] net-sysfs: Fix reference count leak jouni.hogander
2019-11-18 13:27 ` Greg Kroah-Hartman
2019-11-19 7:45 ` Jouni Högander
2019-11-19 7:58 ` Greg Kroah-Hartman
2019-11-19 9:00 ` Jouni Högander [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-11-18 12:06 jouni.hogander
2019-11-18 12:25 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a78ss0kc.fsf@unikie.com \
--to=jouni.hogander@unikie.com \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=lukas.bulwahn@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.