From: Ashutosh Dixit <ashutosh.dixit@intel.com>
To: Katarzyna Dec <katarzyna.dec@intel.com>
Cc: igt-dev@lists.freedesktop.org,
Lucas De Marchi <lucas.demarchi@intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t 1/3] lib/gpgpu_fill/tgl: Implement gpgpu_fillfunc for TGL
Date: Tue, 17 Sep 2019 22:06:49 -0700 [thread overview]
Message-ID: <87a7b22nx2.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <20190918045649.GH25026@kdec5-desk.ger.corp.intel.com>
On Tue, 17 Sep 2019 21:56:49 -0700, Katarzyna Dec wrote:
>
> On Tue, Sep 17, 2019 at 09:51:50PM -0700, Ashutosh Dixit wrote:
> > I ran the kernel checkpatch on the patch and found a couple of minor
> > issues. Perhaps it is a good idea to run checkpatch even on non-kernel
> > patches in the future and fix up whatever can be fixed up.
>
> I am using checkpatch on daily basis and I didn't found any issues. I run it
> again and only '--strct' option shows hints (not warnings). I can change that,
> but in my opinion it is not needed.
> Let me know what you think.
Well checkpatch --strict has found small issues which I have mentioned in
the two patches under the affected lines. IMO they should be fixed
up. Thanks!
--
Ashutosh
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-09-18 5:06 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-17 9:13 [igt-dev] [PATCH i-g-t 0/3] Adding gpgpu_fill and media_fill on TGL Katarzyna Dec
2019-09-17 9:13 ` [igt-dev] [PATCH i-g-t 1/3] lib/gpgpu_fill/tgl: Implement gpgpu_fillfunc for TGL Katarzyna Dec
2019-09-18 4:51 ` Ashutosh Dixit
2019-09-18 4:56 ` Katarzyna Dec
2019-09-18 5:06 ` Ashutosh Dixit [this message]
2019-09-18 8:35 ` Katarzyna Dec
2019-09-17 9:13 ` [igt-dev] [PATCH i-g-t 2/3] lib/media_fill/tgl: Implement media_fillfunc " Katarzyna Dec
2019-09-18 4:55 ` Ashutosh Dixit
2019-09-18 8:24 ` Katarzyna Dec
2019-09-17 9:13 ` [igt-dev] [PATCH i-g-t 3/3] HAX: run gpgpu_fill and media_fill in BAT Katarzyna Dec
2019-09-18 5:27 ` Ashutosh Dixit
2019-09-18 7:31 ` Katarzyna Dec
2019-09-18 14:12 ` Arkadiusz Hiler
2019-09-17 10:01 ` [igt-dev] ✓ Fi.CI.BAT: success for Adding gpgpu_fill and media_fill on TGL Patchwork
2019-09-17 15:42 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-09-18 5:05 ` [igt-dev] [PATCH i-g-t 0/3] " Ashutosh Dixit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a7b22nx2.wl-ashutosh.dixit@intel.com \
--to=ashutosh.dixit@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=katarzyna.dec@intel.com \
--cc=lucas.demarchi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.