From: Kalle Valo <kvalo@codeaurora.org>
To: Tom Psyborg <pozega.tomislav@gmail.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] ath10k: use ath10k_pci_soc_ functions for all warm_reset instances
Date: Tue, 17 Sep 2019 20:30:24 +0300 [thread overview]
Message-ID: <87a7b2bzkf.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <CAKR_QVKtLM7fWs94y_KqndSXmUNTVHO7xqBK3sr5M44DSO_K0g@mail.gmail.com> (Tom Psyborg's message of "Tue, 17 Sep 2019 18:54:07 +0200")
Tom Psyborg <pozega.tomislav@gmail.com> writes:
> On 17/09/2019, Kalle Valo <kvalo@codeaurora.org> wrote:
>> Tomislav Požega wrote:
>>
>>> Use ath10k_pci_soc_read32 / ath10k_pci_soc_write32 functions for
>>> the rest of warm_reset functions. Until now these have been used
>>> only for ath10k_pci_warm_reset_si0, but since they already exist
>>> it makes sense to simplify code a bit.
>>> Runtime tested with QCA9862.
>>>
>>> Signed-off-by: Tomislav Požega <pozega.tomislav@gmail.com>
>>> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
>
> is this a typo or should've I add your SoB line to that commit?
This is just because of my pwcli patchwork script and it's stgit mode.
It takes the commit log directly from the pending branch, where I need
to add my s-o-b as I publish the branch.
In general you should only add your own s-o-b line:
https://www.kernel.org/doc/html/latest/process/submitting-patches.html#sign-your-work-the-developer-s-certificate-of-origin
> btw what about this patch it's been sent out quite a several months
> ago? https://patchwork.kernel.org/patch/10860301/
I have not looked at that yet but it's in my queue.
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2019-09-17 17:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-28 9:11 [PATCH] ath10k: use ath10k_pci_soc_ functions for all warm_reset instances Tomislav Požega
2019-09-17 14:10 ` Kalle Valo
[not found] ` <20190917141014.6A1DA602F3@smtp.codeaurora.org>
2019-09-17 16:54 ` Tom Psyborg
2019-09-17 17:30 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a7b2bzkf.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=pozega.tomislav@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.