From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,URIBL_SBL,URIBL_SBL_A autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9E11C433FF for ; Sat, 27 Jul 2019 10:25:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B56572070D for ; Sat, 27 Jul 2019 10:25:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726384AbfG0KZN (ORCPT ); Sat, 27 Jul 2019 06:25:13 -0400 Received: from mail-ed1-f66.google.com ([209.85.208.66]:40231 "EHLO mail-ed1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725875AbfG0KZN (ORCPT ); Sat, 27 Jul 2019 06:25:13 -0400 Received: by mail-ed1-f66.google.com with SMTP id k8so55281506eds.7 for ; Sat, 27 Jul 2019 03:25:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=gRkoR81Uu5EiiHCvSASeMQn+rAcZzE3EOi2+08buUhM=; b=WLREo7XdRmHojfIKbw5P6B9qW4RqEuW5FDJR1VqMxUvlIKoNrcEJgPO1YGv18HV3sW iPDDhoR/49xnn9ojpio8Pmk4nEeBVeo8ERzUPStFSIFjAHWi2ZNUc8Lak4krq16vcIn1 W4MU1u7tGOzwJ3NJQSMNokiH3i1SZCTWK+zC21AUjLhUYJfPW5+Nj0jatmg7FUiJMdkO bXSdoNy9S0H4vAAmFauLDU9E2pKrYBHB5Uw+7MyHvt5G06pJY6ib/ES9j2qjQmKTbciX mq3Tk4YolFFtmvL1T8muzz8tylT/B6RHP4pmzq33zfaAwy4hflo9fxyPzBPTPq/pOBZs VYzA== X-Gm-Message-State: APjAAAVWwD+ATv6isGDBZY1P8hDSV0NXZ/IKzGDYQm1bcUf/1dUP7RNj wTaZWKdV2fG7WOfCJuTAq7p1oR9YWDE= X-Google-Smtp-Source: APXvYqxfgvdCQsk/WGaZtym0pWET2OA5SCXzb4sRRw5OXfrQhg3Q75+uUM1PJ5cUscOsDOw27qXnQQ== X-Received: by 2002:a50:b617:: with SMTP id b23mr86501083ede.135.1564223111914; Sat, 27 Jul 2019 03:25:11 -0700 (PDT) Received: from alrua-x1.borgediget.toke.dk (borgediget.toke.dk. [85.204.121.218]) by smtp.gmail.com with ESMTPSA id b53sm14785413edd.45.2019.07.27.03.25.11 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Sat, 27 Jul 2019 03:25:11 -0700 (PDT) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id 64BFB1800C5; Sat, 27 Jul 2019 12:25:10 +0200 (CEST) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Jiri Pirko Cc: netdev@vger.kernel.org, davem@davemloft.net, jakub.kicinski@netronome.com, sthemmin@microsoft.com, dsahern@gmail.com, mlxsw@mellanox.com Subject: Re: [patch iproute2 1/2] devlink: introduce cmdline option to switch to a different namespace In-Reply-To: <20190727102116.GC2843@nanopsycho> References: <20190727094459.26345-1-jiri@resnulli.us> <20190727100544.28649-1-jiri@resnulli.us> <87ef2bwztr.fsf@toke.dk> <20190727102116.GC2843@nanopsycho> X-Clacks-Overhead: GNU Terry Pratchett Date: Sat, 27 Jul 2019 12:25:10 +0200 Message-ID: <87a7czwz95.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Jiri Pirko writes: > Sat, Jul 27, 2019 at 12:12:48PM CEST, toke@redhat.com wrote: >>Jiri Pirko writes: >> >>> From: Jiri Pirko >>> >>> Signed-off-by: Jiri Pirko >>> --- >>> devlink/devlink.c | 12 ++++++++++-- >>> man/man8/devlink.8 | 4 ++++ >>> 2 files changed, 14 insertions(+), 2 deletions(-) >>> >>> diff --git a/devlink/devlink.c b/devlink/devlink.c >>> index d8197ea3a478..9242cc05ad0c 100644 >>> --- a/devlink/devlink.c >>> +++ b/devlink/devlink.c >>> @@ -32,6 +32,7 @@ >>> #include "mnlg.h" >>> #include "json_writer.h" >>> #include "utils.h" >>> +#include "namespace.h" >>> >>> #define ESWITCH_MODE_LEGACY "legacy" >>> #define ESWITCH_MODE_SWITCHDEV "switchdev" >>> @@ -6332,7 +6333,7 @@ static int cmd_health(struct dl *dl) >>> static void help(void) >>> { >>> pr_err("Usage: devlink [ OPTIONS ] OBJECT { COMMAND | help }\n" >>> - " devlink [ -f[orce] ] -b[atch] filename\n" >>> + " devlink [ -f[orce] ] -b[atch] filename -N[etns] >>> netnsname\n" >> >>'ip' uses lower-case n for this; why not be consistent? > > Because "n" is taken :/ Ah, right, that was right there on the line below in the patch context. Oops, by bad (and too bad!) -Toke